Thanks for the patch! It definitely seems to resolve the issue with v2018.03-rc1, but unfortunately I haven't had success building it with v2018.01 yet:
/<<BUILDDIR>>/u-boot-2018.01+dfsg1/lib/efi_loader/efi_image_loader.c: In function ‘efi_load_pe’: /<<BUILDDIR>>/u-boot-2018.01+dfsg1/lib/efi_loader/efi_image_loader.c:208:7: error: ‘IMAGE_SUBSYSTEM_SAL_RUNTIME_DRIVER’ undeclared (first use in this function); did you mean ‘IMAGE_SUBSYSTEM_EFI_RUNTIME_DRIVER’? I get the impression that EFI related support in u-boot has been very active lately, which this code touches, which makes it harder to apply patches from upstream directly. live well, vagrant On 2018-01-31, Heinrich Schuchardt wrote: > Before the patch an undefined constant EFI_SUBSYSTEM was used in the > crt0 code. The current version of binutils does not swallow the error. > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888403 > > The necessary constant IMAGE_SUBSYSTEM_EFI_APPLICATION is already > defined in pe.h. So let's factor out asm-generic/pe.h for the > image subsystem constants and use it in our assembler code. > > IMAGE_SUBSYSTEM_SAL_RUNTIME_DRIVER does not exist in the specification > let's use IMAGE_SUBSYSTEM_EFI_ROM instead. > > The include pe.h is only used in code maintained by Alex so let him be the > maintainer here too. > > Reported-by: Andre Przywara <andre.przyw...@arm.com> > Cc: Alexander Graf <ag...@suse.de> > Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> > --- > MAINTAINERS | 2 ++ > arch/arm/lib/crt0_aarch64_efi.S | 4 +++- > arch/arm/lib/crt0_arm_efi.S | 4 +++- > include/asm-generic/pe.h | 21 +++++++++++++++++++++ > include/pe.h | 8 ++------ > lib/efi_loader/efi_image_loader.c | 2 +- > 6 files changed, 32 insertions(+), 9 deletions(-) > create mode 100644 include/asm-generic/pe.h
signature.asc
Description: PGP signature
