Your message dated Tue, 13 Feb 2018 21:04:23 +0000
with message-id <e1elhkv-0002b5...@fasolo.debian.org>
and subject line Bug#885885: fixed in broadcom-sta 6.30.223.271-8
has caused the Debian Bug report #885885,
regarding FTBTS with linux 4.15, severe warnings with linux 4.14
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
885885: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885885
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: broadcom-sta
Version: 6.30.223.271-7
Severity: serious
Tags: patch
Justification: fails to build from source

linux 4.14 changed the kernel_read function prototype.
linux 4.15 deprecated the init_timer function.

Both functions are used by this package.

I am currectly using linux 4.15-rc5 with the attached patches applied
(my NIC is a Broadcom BCM4352).

Not sure the patches are correct, though.

Best regards,
    Gerardo Malazdrewicz

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-rc5-amd64 (SMP w/8 CPU cores)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8), 
LANGUAGE=es_AR:es (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
--- a/amd64/src/shared/linux_osl.c      2017-12-29 22:59:17.000000000 -0400
+++ b/amd64/src/shared/linux_osl.c      2017-12-29 23:44:24.786247269 -0400
@@ -1076,11 +1076,21 @@
 {
        struct file *fp = (struct file *)image;
        int rdlen;
+       loff_t pos;
 
        if (!image)
                return 0;
 
-       rdlen = kernel_read(fp, fp->f_pos, buf, len);
+       pos = fp->f_pos;
+       rdlen = kernel_read(fp, 
+#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)
+                       pos, 
+#endif
+                       buf, len
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 14, 0)
+                       ,&pos 
+#endif
+       );
        if (rdlen > 0)
                fp->f_pos += rdlen;
 
--- a/amd64/src/wl/sys/wl_linux.c       2017-12-29 23:57:29.000000000 -0400
+++ b/amd64/src/wl/sys/wl_linux.c       2017-12-30 12:32:29.518324068 -0400
@@ -93,7 +93,13 @@
 
 #include <wlc_wowl.h>
 
-static void wl_timer(ulong data);
+static void wl_timer(
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0)
+               struct timer_list *tl
+#else
+               ulong data
+#endif
+               );
 static void _wl_timer(wl_timer_t *t);
 static struct net_device *wl_alloc_linux_if(wl_if_t *wlif);
 
@@ -2295,9 +2301,19 @@
 }
 
 static void
-wl_timer(ulong data)
-{
-       wl_timer_t *t = (wl_timer_t *)data;
+wl_timer(
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0)
+               struct timer_list *tl
+#else
+               ulong data
+#endif
+) {
+       wl_timer_t *t =
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0)
+               from_timer(t, tl, timer);
+#else
+               (wl_timer_t *)data;
+#endif
 
        if (!WL_ALL_PASSIVE_ENAB(t->wl))
                _wl_timer(t);
@@ -2349,9 +2365,13 @@
 
        bzero(t, sizeof(wl_timer_t));
 
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0)
+       timer_setup(&t->timer, wl_timer, 0);
+#else
        init_timer(&t->timer);
        t->timer.data = (ulong) t;
        t->timer.function = wl_timer;
+#endif
        t->wl = wl;
        t->fn = fn;
        t->arg = arg;

--- End Message ---
--- Begin Message ---
Source: broadcom-sta
Source-Version: 6.30.223.271-8

We believe that the bug you reported is fixed in the latest version of
broadcom-sta, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 885...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Eduard Bloch <bl...@debian.org> (supplier of updated broadcom-sta package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 13 Feb 2018 21:45:18 +0100
Source: broadcom-sta
Binary: broadcom-sta-common broadcom-sta-dkms broadcom-sta-source
Architecture: source all
Version: 6.30.223.271-8
Distribution: unstable
Urgency: low
Maintainer: Eduard Bloch <bl...@debian.org>
Changed-By: Eduard Bloch <bl...@debian.org>
Description:
 broadcom-sta-common - Common files for the Broadcom STA Wireless driver
 broadcom-sta-dkms - dkms source for the Broadcom STA Wireless driver
 broadcom-sta-source - Source for the Broadcom STA Wireless driver
Closes: 885885
Changes:
 broadcom-sta (6.30.223.271-8) unstable; urgency=low
 .
   [ Roger Shimizu ]
   * debian/patches:
     - Added 20-linux414.patch, and 21-linux415.patch to support
       Linux kernel 4.15
       (Thanks to Gerardo Esteban Malazdrewicz, closes: #885885)
     - Fix typo in 14-rdtscl.patch
 .
   [ Eduard Bloch ]
   * Dropped extra CHANGELOG file (ancient documentation)
   * Standard version update to 4.1.3 (added lintian override to
     broadcom-sta-source since debhelper is used on purpose therein)
Checksums-Sha1:
 0e76d2c026a38747a01934038f1e1a9f260855f3 2154 broadcom-sta_6.30.223.271-8.dsc
 3de05b3ac05a4e4d964c7d2ff2254a785d552cd9 21100 
broadcom-sta_6.30.223.271-8.debian.tar.xz
 343313827eaf1da8801eb8262d92e15d1f0d2323 12232 
broadcom-sta-common_6.30.223.271-8_all.deb
 a3aafd9c0f4f4db1a30ada93627f158a59168a11 2204516 
broadcom-sta-dkms_6.30.223.271-8_all.deb
 fe56b40d1bea3afcf972479bce811a19a147c84d 2220824 
broadcom-sta-source_6.30.223.271-8_all.deb
 2d82bd3d7952487d52e413a82d6a6e66f566b56e 7926 
broadcom-sta_6.30.223.271-8_amd64.buildinfo
Checksums-Sha256:
 1d66647e22b97e561d97c3caa2d21469442aa97936774822d6952e41d1b10909 2154 
broadcom-sta_6.30.223.271-8.dsc
 ef2f571b14f02401eca951c25d619e63cc0d5b982969f1430c4a6f87c8b901d4 21100 
broadcom-sta_6.30.223.271-8.debian.tar.xz
 9189e32d00e62675a7d01c0d55528b22f1e0a2419ee8cb7ce206950f5c704efc 12232 
broadcom-sta-common_6.30.223.271-8_all.deb
 3ef65152cd53a3784e68b28eb9b4c6e7bbd34d503c30ec786acfb85154b9b263 2204516 
broadcom-sta-dkms_6.30.223.271-8_all.deb
 bdd6bf56e035c4375236e86a1ee5b55d981bfffdd7a9b2ec4b8cd230f7d4cf0a 2220824 
broadcom-sta-source_6.30.223.271-8_all.deb
 a8bd59a5f4a8e508a854e0fcb06e6aca1b90bc90aa2856a3afc8f26b34ef27d5 7926 
broadcom-sta_6.30.223.271-8_amd64.buildinfo
Files:
 11844668cbe59632446c831ea1396984 2154 non-free/kernel optional 
broadcom-sta_6.30.223.271-8.dsc
 cea3b4fee629026eba9f0c9c601506c5 21100 non-free/kernel optional 
broadcom-sta_6.30.223.271-8.debian.tar.xz
 f5f73a596584e25b75dfdcfde661a807 12232 non-free/kernel optional 
broadcom-sta-common_6.30.223.271-8_all.deb
 a31ebf980ec9d7928281a9a66a131787 2204516 non-free/kernel optional 
broadcom-sta-dkms_6.30.223.271-8_all.deb
 6bdda0ab34063ebeef826012e3872115 2220824 non-free/kernel optional 
broadcom-sta-source_6.30.223.271-8_all.deb
 f5f01c84f150b60444b946fc715a6d20 7926 non-free/kernel optional 
broadcom-sta_6.30.223.271-8_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEZI3Zj0vEgpAXyw40aXQOXLNf7DwFAlqDT7sACgkQaXQOXLNf
7DxjKxAAivc9sajr+PShcfOdyTkwilIGTqjallmZ8c2TZUd/PO7Ll8uN7absZmzM
oFjCJzKRbb8SrpvhWPivmPcnJDnIcD+M6k2/JalVgLpMaF/CC5H59Jnd0k/8IO1V
PHq8R4FcAAvaHyvcvtFBLZ8EWcmygWDAtlRaiWqoaavF4DVU/aWqtCnKWNcawosr
W4/VRnVZBlpOKYLzqP51nYdOf1nx1MhaQrZ/ycXVn0zpmq7LIxWF2G8fKw+03Qqn
2U7/fkbnyUhlIySZEOT5ol3To9PiX7i+SmA+uFurml1p/7OAxeWzIXupZQw8c1B7
PBKRRCRej6yMbidE6gpvPtMz35WUpyyd8WZbvOHSOd8B/ZST1rskZqka44e0koBd
K5eDKOYwXnkSoyT88SX0mYRjP3RbyerfR7zKQDk/8b3jyy01Tiv6nCtz0WhKECfI
1wUERL9hmCvrUtmQAU7z3WnjowOM8JJSEsrAght1G7100kvHrMprZMk6dTJ8u2FA
mJvqTSljhWtbS0rizEx0zDwCKIPi39+YLhxGRrT0f8TDTz2V0dEMZnIK4llMefXS
Akr7nxb/zvVn5//FVfPKCNCqJor4YSFqJljkTj5XIaeHw+x/cy0ui46C40CKnyZW
DREvKPjLbIO/R9awfMtGzKDntj3BxUMJPUhqoqcc6op8uzszsQc=
=SKTW
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to