On April 12, 2018 2:48:32 AM GMT+05:30, Paolo Greppi <paolo.gre...@libpf.com> wrote: >Normally you'd expect to fix bugs with a new version, in this case >while trying to update node-define-property 1.0.0-1 -> 2.0.2 the >failing tests actually increased from 1 to 4. > >What puzzled me was that no tests fail on upstream's CI (travis), which >also tests nodejs version 8. > >Turns out that we have upgraded node-is-descriptor to version 2.0.0, >but the npm registry only has 1.0.2. > >I have forwarded the issue upstream, and I expect upstream to answer >that define-property correctly pins the major version of is-descriptor >with ^1.0.2 (https://docs.npmjs.com/misc/semver), stating that it won't >work with 2.x. > >^1.0.2 should be translated with >= 1.0.2 && < 2.0.0 but we can't >encode that in debian/control. > >So how can we check reverse dependencies for this type of issues in the >future ? > >Paolo
build-and-upload script from ruby-team/meta can help if we have enabled tests. If we used that, then is-descriptor 1.0 -> 2.0 update would notify the failure before upload. But its likely we added is-descriptor 2.0 directly. The best choice is upstream updating their dependency. Second choice is we update and send merge request. As a worse case, we can downgrade node-is-descriptor to 1.0 if we have no other reverse dependency or embed 1.0 in node-define-property. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.