Control: reopen -1 Hi Arturo,
On Wed, Apr 18, 2018 at 11:07:32AM +0200, Arturo Borrero Gonzalez wrote: > If you check debian/tests/systemd-service-test.sh [0], the interface > in use by the config file is decided at runtime. This code runs only for one of the tests. It doesn't change the fact that the suricata service as a whole is broken on install when eth0 is not present, and all commands which try to talk to the daemon prior to that point in the tests will fail. You could fix the autopkgtests to not depend on eth0 if you moved the systemd-service-test.sh to run before all other tests. But I don't think that would fix this bug, because I think the behavior of the package itself is still wrong. > What autopkgtest tests are you running? The ones shipped in your package. > This seem like an ubuntu specific issue. All tests in debian are going > fine, both in unstable and in testing [1]. The tests work fine in Debian because the testbed HAPPENS TO HAVE AN eth0 INTERFACE, as I said in the original bug report. I know the difference between Debian and Ubuntu and am not in the habit of gratuitously overinflating the severity of bugs filed in Debian for Ubuntu-specific issues. > This Debian bug may result in the package being removed from Debian > testing for no actual reason. I wrote the reason in my original bug report: I'm filing this as serious because it seems to me that neither of these behaviors - either starting up and being ineffective because it's running on the wrong interface, or failing to start up because the interface is hard-coded and not present - is a reasonable default behavior for an IDS. I think the interface should either be autodetected or prompted for at install time. I also wrote: Feel free to downgrade if you disagree. It's not clear to me that you disagree. It's not clear to me that you even read my bug report. So, reopening at original severity. > Closing this bug now as it seems totally bogus. There is at least one bug here in the package, which is that the autopkgtests make a brittle assumption that eth0 will be available in the test bed. eth0 is a legacy interface name in the kernel, and despite the fact that eth0 is currently present on the ci.debian.net testbeds, this is not a robust assumption. If you want to reorder the tests so that the config file setup is done first, then that would address the bug in the autopkgtests. I still also think it's a bug that the package installs successfully but the daemon fails to start if there is no eth0 interface. I think best practice is that a package ensures its daemons can be started before the package is configured, because it's better to surface a failure to the admin than to consider a package "configured" without providing core functionality to reverse-dependencies. This was in my view the issue that warranted a 'serious' severity, but you are free to disagree and downgrade the bug. > [0] > https://salsa.debian.org/pkg-suricata-team/pkg-suricata/blob/master/debian/tests/systemd-service-test.sh > [1] https://ci.debian.net/packages/s/suricata/ -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: PGP signature
