On Thu, May 24, 2018 at 06:33:45AM +0900, Mattia Dongili wrote: > On Wed, May 23, 2018 at 02:56:55PM +0200, Gianfranco Costamagna wrote: > > control: reassign -1 src:acpica-unix > > control: found -1 20180508-1 > > control: affects -1 virtualbox > > > > On Tue, 22 May 2018 19:12:32 +0200 Emilio Pozuelo Monfort > > <po...@debian.org> wrote: > > > Package: virtualbox > > > Version: 5.2.12-dfsg-1 > > > Severity: serious > > > > > > virtualbox fails to build on a clean sid chroot here: > > > > > > In file included from > > > /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp:45:0: > > > /build/virtualbox-5.2.12-dfsg/out/obj/VBoxDD/vboxssdt-standard.hex:16:23: > > > error: expected initializer before '-' token > > > unsigned char vboxssdt-standard_aml_code[] = > > > ^ > > > /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp: In > > > function 'int acpiPrepareDsdt(PPDMDEVINS, void**, size_t*)': > > > /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp:371:32: > > > error: 'AmlCode' was not declared in this scope > > > cbAmlCodeDsdt = sizeof(AmlCode); > > > ^~~~~~~ > > > /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp: In > > > function 'int acpiPrepareSsdt(PPDMDEVINS, void**, size_t*)': > > > /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp:423:30: > > > error: 'AmlCodeSsdtCpuHotPlug' was not declared in this scope > > > pabAmlCode = AmlCodeSsdtCpuHotPlug; > > > ^~~~~~~~~~~~~~~~~~~~~ > > > /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp:428:30: > > > error: 'AmlCodeSsdtStandard' was not declared in this scope > > > pabAmlCode = AmlCodeSsdtStandard; > > > ^~~~~~~~~~~~~~~~~~~ > > > kmk: *** [/usr/share/kBuild/footer-pass2-compiling-targets.kmk:226: > > > /build/virtualbox-5.2.12-dfsg/out/obj/VBoxDD/PC/ACPI/VBoxAcpi.o] Error 1 > > For the record, the DSL files are here: > https://salsa.debian.org/pkg-virtualbox-team/virtualbox/tree/master/src/VBox/Devices/PC > > and are compiled and post-processed as: > https://salsa.debian.org/pkg-virtualbox-team/virtualbox/blob/master/src/VBox/Devices/Makefile.kmk#L829-857
So, apparently upstream is aware of this. See comments on https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37#diff-95e84a7c99c268ce5433dea47cf17ec0 Gianfranco, if you need a work-around, changing the file prefix to something that is a legal C identifier might help. Either way, unless the offending change is not backed out (as Bob suggested in the discussion I linked), the "AmlCode" identifier is gone for good, so things like $(QUIET)$(SED) -e "s/AmlCode/AmlCodeSsdtStandard/g" \ $(QUIET)$(SED) -e "s/AmlCode/AmlCodeSsdtCpuHotPlug/g" \ won't work. -- mattia :wq!
