Your message dated Wed, 20 Jun 2018 22:34:11 +0000
with message-id <[email protected]>
and subject line Bug#901900: fixed in dgit 5.1
has caused the Debian Bug report #901900,
regarding dgit fails autopkgtest: true/false are no valid working-tree-encodings
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
901900: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901900
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: git
Version: 1:2.18.0~rc2-1
Severity: serious
Justification: breaks dgit test suite, breaks existing attempts not to corrupt
data
Firstly, apologies for filing this bug as RC. I wanted to prevent the
new git migrating. It breaks the dgit autopkgtest. For reasons I
don't understand, ci.debian.net thinks the dgit autopkgtest `always
failed' even though it passes just fine in testing. So britney has
reduced the migration delay to a mere 2 days, IMO wrongly. Can we
please keep this bug as RC for a little while at least while we decide
what to do about it ?
So, on to the actual problem:
Looking at the manpage for gitattributes(7) it mentions a new
attribute
working-tree-encoding
which affects the way files are checked in and out.
dgit and similar workflows need to disable this attribute, because
they require that git trees and source packages correspond, which
cannot be achieved if working trees made from source packages are not
identical to git trees once committed.
In #851679 I requested a way to disable all checkout-affecting
gitattributes. This has not yet been done AFAICT.
In lieu of that, dgit's test suite has a specific test to spot when
new attributes are introduced. It tries enabling them and seeing if
things go wrong. And indeed, that test has now tripped. (It failed,
in fact, simply because some of the values it attempted to set the
unknown working-tree-encoding attribute to were invalid, but IMO the
test has done its job.)
I think at the very least I will need to update dgit to disable
working-tree-encoding as well. I think the new git should probably
have a Breaks against the older dgit.
A proper fix for #851679 would stop this happening next time a new
gitattribute is introduced.
References:
Failing test log
https://ci.debian.net/data/autopkgtest/testing/amd64/d/dgit/473624/log.gz
Explanation of why dgit needs to disable things
https://manpages.debian.org/stretch/dgit/dgit.7.en.html#GITATTRIBUTES
Thanks for your attention and forbearance,
Ian.
--
Ian Jackson <[email protected]> These opinions are my own.
If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.
--- End Message ---
--- Begin Message ---
Source: dgit
Source-Version: 5.1
We believe that the bug you reported is fixed in the latest version of
dgit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ian Jackson <[email protected]> (supplier of updated dgit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 20 Jun 2018 23:20:57 +0100
Source: dgit
Binary: dgit git-debrebase dgit-infrastructure
Architecture: source
Version: 5.1
Distribution: unstable
Urgency: medium
Maintainer: Ian Jackson <[email protected]>
Changed-By: Ian Jackson <[email protected]>
Description:
dgit - git interoperability with the Debian archive
dgit-infrastructure - dgit server backend infrastructure
git-debrebase - rebasing git workflow tool for Debian packaging
Closes: 901809 901900
Changes:
dgit (5.1) unstable; urgency=medium
.
dgit gitattributes handling:
* Squash the working-tree-encoding attribute too.
* Update an existing `dgit-defuse-attrs' macro in .git/info/attributes.
* Test the working-tree-encoding attribute squashing properly.
Closes:#901900.
.
git-debrebase fixes:
* new-upstream: fix (this time for sure) ff check handling
of multi-piece upstreams.
* Suppress gbp pq export output, except in case of error.
Closes:#901809.
* Manpages: Fix typos and etc.
* Fix a typo in the package description.
.
Test suite:
* Triger ci.debian.net autopkgtests on: gnupg diffutils patch.
(A dummy test is used to add to Testsuite-Triggers.)
Checksums-Sha1:
401fa22489e834658ca8f44b6e48e4c6d53e4b1c 1607 dgit_5.1.dsc
3e440a0940e1da29c9174c170fa9c096639d25a4 450715 dgit_5.1.tar.gz
Checksums-Sha256:
da2db89428c4f17abeb68940323ed19ca7aea1b28b380cd815aac769cde11aac 1607
dgit_5.1.dsc
c218e5cb856d0f5e0472c0f7502b7b240fe867f95a745e23894483e0259aba83 450715
dgit_5.1.tar.gz
Files:
2eb246395d6c27bffc7b23eddb2ce442 1607 devel optional dgit_5.1.dsc
abf778faffdd4614f0434d4641a48eec 450715 devel optional dgit_5.1.tar.gz
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEVZrkbC1rbTJl58uh4+M5I0i1DTkFAlsq08AACgkQ4+M5I0i1
DTlcxwf7BCPf/P2lnYhofvXYvXcBhmWGPpBqZMKXjVbYyLezImq33DRZze9crgX9
pw8t/9WBanaJ31/a/nlkllfxA056VSTI2gLjmuwAHJbUk1loB+/TQy2E0N6E2mtF
Jb8SIFsnvpmAG7e+EdowV/M5OOl5ZXiyq4ynFmqbGD0e038eliciCEowXFgvGPup
ZWph0zkdq1OaCywgAsSQ95bZawajjdZ9PYw8QH2EzyFm5nia4Z7NvvF2K2iRcFJs
MYJV3azUOgKTiEqo8+QVZK5p7XxA/MOevyhFHTI+cUt6H7Hyv5ZEF/V3bhftiG9q
1gKKD9ENi14OXpxlGURo0izETaixMw==
=i+9I
-----END PGP SIGNATURE-----
--- End Message ---
