Control: tags -1 + patch

On Sat, 23 Jun 2018 at 16:33:40 +0100, Simon McVittie wrote:
> On Sat, 23 Jun 2018 at 12:52:01 +0300, Adrian Bunk wrote:
> > make[3]: *** No rule to make target 'ParagraphLayout.ao', needed by 
> > '../lib/libiculx.a'.  Stop.
> 
> It looks as though Ubuntu might have a fix for this
> ...
> +  * Don't build-depend on libicu-dev

This didn't work for me: even with a Build-Conflicts, I got the same
failure. However, a better solution seems to be to pass --disable-layoutex
to the bundled icu's configure script, as in the attached. That makes
some sense to me at least: the bundled icu's configure script has an
"automagic" dependency on the icu-le-hb layout engine library, which until
recently we didn't have. However, the bundled icu is incomplete/minimal
and doesn't actually have the source code for the optional paragraph
layout feature that requires icu-le-hb. We can resolve that by turning
the feature off, which isn't a regression because the versions of mozjs52
that compiled successfully didn't have it either.

Having fixed that, I get a different FTBFS: the mozjs command-line entry
point fails to start up. I'll open a separate bug to track that. I can
work around it, but I'm reasonably sure my workaround isn't the proper
solution.

    smcv
From: Mike Hommey <mh+mozi...@glandium.org>
Date: Sat, 19 May 2018 11:23:18 +0900
Subject: Add --disable-layoutex when running ICU configure. r=froydnj,
 a=RyanVM

In some recent ICU update, --enable-layoutex changed from defaulting
to the "same-as-layout" to "yes", so --disable-layout doesn't imply
--disable-layoutex anymore, but we removed the layoutex files.

Applied-upstream: https://hg.mozilla.org/mozilla-unified/rev/31d4880fde31
---
 intl/icu_sources_data.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/intl/icu_sources_data.py b/intl/icu_sources_data.py
index 7d2d983..fc95d6a 100644
--- a/intl/icu_sources_data.py
+++ b/intl/icu_sources_data.py
@@ -122,6 +122,7 @@ def update_data_file(topsrcdir):
              '--disable-extras',
              '--disable-icuio',
              '--disable-layout',
+             '--disable-layoutex',
              '--disable-tests',
              '--disable-samples',
              '--disable-strict'],

Reply via email to