Your message dated Wed, 26 Sep 2018 16:04:30 +0000
with message-id <[email protected]>
and subject line Bug#908929: fixed in google-authenticator 20170702-2
has caused the Debian Bug report #908929,
regarding libpam-google-authenticator: hardcoded dependency on libqrencode3
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
908929: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908929
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libpam-google-authenticator
Severity: serious
Tags: patch
libpam-google-authenticator depends on libqrencode3, which has no longer built
from the qrencode source package. It has been replaced by libqrencode4. This
dependency is hard coded and does not change after a re-build. Looking at the
code it seems that libqrencode is used via dlopen/dlsym.
The two functions used don't seem to have changed in ABI, so afaict it should
be ok to add the new .4 version to the list of sonames to try in the upstream
code and change debian/control
I have attached a debdiff that makes the aforementioned changes, I have tested
the package builds with the debdiff but I have not tested it beyond that.
diff -Nru google-authenticator-20170702/debian/changelog
google-authenticator-20170702/debian/changelog
--- google-authenticator-20170702/debian/changelog 2017-07-02
10:02:29.000000000 +0000
+++ google-authenticator-20170702/debian/changelog 2018-09-16
07:31:09.000000000 +0000
@@ -1,3 +1,10 @@
+google-authenticator (20170702-1.1) UNRELEASED; urgency=medium
+
+ * Patch proposed to BTS, no intent to NMU
+ * update for libqrcode4.
+
+ -- Peter Michal Green <[email protected]> Sun, 16 Sep 2018 07:31:09 +0000
+
google-authenticator (20170702-1) unstable; urgency=medium
* Upstream update (00065df) (Closes: #864187).
diff -Nru google-authenticator-20170702/debian/control
google-authenticator-20170702/debian/control
--- google-authenticator-20170702/debian/control 2016-06-07
17:49:06.000000000 +0000
+++ google-authenticator-20170702/debian/control 2018-09-16
07:31:01.000000000 +0000
@@ -8,7 +8,7 @@
Package: libpam-google-authenticator
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libqrencode3
+Depends: ${shlibs:Depends}, ${misc:Depends}, libqrencode4
Description: Two-step verification
The Google Authenticator project includes implementations of one-time
passcode generators for several mobile platforms, as well as a
diff -Nru google-authenticator-20170702/debian/patches/libqrencode4.patch
google-authenticator-20170702/debian/patches/libqrencode4.patch
--- google-authenticator-20170702/debian/patches/libqrencode4.patch
1970-01-01 00:00:00.000000000 +0000
+++ google-authenticator-20170702/debian/patches/libqrencode4.patch
2018-09-16 07:31:09.000000000 +0000
@@ -0,0 +1,18 @@
+Description: Add support for libqrencode4 and make it the first choice.
+Author: Peter Michal Green <[email protected]>
+Last-Update: 2018-09-16
+
+--- google-authenticator-20170702.orig/libpam/src/google-authenticator.c
++++ google-authenticator-20170702/libpam/src/google-authenticator.c
+@@ -203,7 +203,10 @@ static const char *getURL(const char *se
+
+ // Display QR code visually. If not possible, return 0.
+ static int displayQRCode(const char* url) {
+- void *qrencode = dlopen("libqrencode.so.2", RTLD_NOW | RTLD_LOCAL);
++ void *qrencode = dlopen("libqrencode.so.4", RTLD_NOW | RTLD_LOCAL);
++ if (!qrencode) {
++ qrencode = dlopen("libqrencode.so.2", RTLD_NOW | RTLD_LOCAL);
++ }
+ if (!qrencode) {
+ qrencode = dlopen("libqrencode.so.3", RTLD_NOW | RTLD_LOCAL);
+ }
diff -Nru google-authenticator-20170702/debian/patches/series
google-authenticator-20170702/debian/patches/series
--- google-authenticator-20170702/debian/patches/series 2016-06-07
16:17:33.000000000 +0000
+++ google-authenticator-20170702/debian/patches/series 2018-09-16
07:31:09.000000000 +0000
@@ -0,0 +1 @@
+libqrencode4.patch
--- End Message ---
--- Begin Message ---
Source: google-authenticator
Source-Version: 20170702-2
We believe that the bug you reported is fixed in the latest version of
google-authenticator, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Janos Lenart <[email protected]> (supplier of updated google-authenticator
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 26 Sep 2018 16:45:00 +0100
Source: google-authenticator
Binary: libpam-google-authenticator
Architecture: source amd64
Version: 20170702-2
Distribution: unstable
Urgency: medium
Maintainer: Janos Lenart <[email protected]>
Changed-By: Janos Lenart <[email protected]>
Description:
libpam-google-authenticator - Two-step verification
Closes: 908929
Changes:
google-authenticator (20170702-2) unstable; urgency=medium
.
* Updated to use libqrencode4 (Closes: #908929).
Checksums-Sha1:
af8754155105fb7c099e904205e2c184a209471d 1570
google-authenticator_20170702-2.dsc
8cc47f79adea15a14b1504028338fff08b6db014 4304
google-authenticator_20170702-2.debian.tar.xz
324b40d6540b3c52ef044fa9229e7bc80a200929 6835
google-authenticator_20170702-2_amd64.buildinfo
2ae9699fd6215bfbd2163f0adc4a570c858e8351 60170
libpam-google-authenticator-dbgsym_20170702-2_amd64.deb
9e9fab305450f9967a0cf0b6313ba35772a18b5c 32796
libpam-google-authenticator_20170702-2_amd64.deb
Checksums-Sha256:
7092fb84194239620548d401f03c686c0e963311c8b9d1406cf67ff51d06e031 1570
google-authenticator_20170702-2.dsc
c0bbba4e4724f21dfa7d49693c269695e02a48a4441f9958bc0d56d84355997b 4304
google-authenticator_20170702-2.debian.tar.xz
6e8c86a0a4d58040f03459715be98ae58f592a1b779d09e4db62eb0c8618f890 6835
google-authenticator_20170702-2_amd64.buildinfo
e064bb237259533c2039a033e05fe030afbf983861b5ab57176ff7c22b32e88a 60170
libpam-google-authenticator-dbgsym_20170702-2_amd64.deb
9c14385fc41ca53bb58c50b366bf6b2083d947d38f29c4376fbf35ad0603e675 32796
libpam-google-authenticator_20170702-2_amd64.deb
Files:
c47e2dc2d72ef8710d14a73117e0640d 1570 admin optional
google-authenticator_20170702-2.dsc
f993c59ab2f85264130c5c9a7772aaf8 4304 admin optional
google-authenticator_20170702-2.debian.tar.xz
897efc8ba3a6c39d8c35d61581fa62cb 6835 admin optional
google-authenticator_20170702-2_amd64.buildinfo
b2295e3036c829d46fd3e523d92109de 60170 debug extra
libpam-google-authenticator-dbgsym_20170702-2_amd64.deb
98de302417f3116a70fd616724d766c3 32796 admin optional
libpam-google-authenticator_20170702-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQFEBAEBCgAuFiEER8wRF8gFmDcPrXi0JHmvJU99vGUFAlurqeMQHG9jc2lAZGVi
aWFuLm9yZwAKCRAkea8lT328ZU60CACMtnz2vgN7lHgnuMmL1AkSPYpI0BanGWzL
mKSsrvpY3wysFRJJp7iJSQYhYNQ/KvBUsJF5B27/1QuGoqy8onHoRUptfEUxTwi5
aCTUqxYexycebmKwmv9+MWrgyrQCSbLA3B/KkS0Rl71+wM6Rl+c5SOcWIs5RfER3
ACurYb+7jxeJoIG9e1Euhkw0HXkHUCXeEi5akhzqOTy8Uq/P99WE2mRyBcSN6a3r
653UYGyptkoc8TsDnIHrmuBgs18F992lwUanLOG7tyDkzHhYA+s0EoTPOcrXrW5u
LFtOIAKsAqCOgNiL2i7Fvq2Kt1Kg8M5U0ACQIgIHAWCYLrvIy3xM
=PBoe
-----END PGP SIGNATURE-----
--- End Message ---
