Package: spampd
Version: 2.30-2
Severity: grave
Justification: renders package unusable
Upon upgrading to 2.30-2 (from 2.30-1):
---
Setting up spampd (2.30-2) ...
Starting spam checking proxy daemon: spampdScalar found where operator
expected at /usr/sbin/spampd line 598, near "$status"
(Missing semicolon on previous line?)
syntax error at /usr/sbin/spampd line 598, near "$status"
Global symbol "$status" requires explicit package name at
/usr/sbin/spampd line 598.
Global symbol "$previous_alarm" requires explicit package name
at /usr/sbin/spam pd line 601.
syntax error at /usr/sbin/spampd line 614, near "} else"
Execution of /usr/sbin/spampd aborted due to compilation errors.
invoke-rc.d: initscript spampd, action "start" failed.
---
Simple cause: two erroneous braces applied as part of the fix for
bug #344372. A trailing space was also missed in the "processing
message..." logging string.
A trivial patch is attached to this report.
Kind regards,
Adam James.
--- /usr/sbin/spampd.orig 2006-04-15 22:30:37.000000000 +0100
+++ /usr/sbin/spampd 2006-04-15 22:32:14.000000000 +0100
@@ -493,7 +493,7 @@
if ($self->{spampd}->{pfs_uses_format}) {
$self->log(2, "%s", "processing message $msgid for ". $recips);
} else {
- $self->log(2, "processing message $msgid for". $recips);
+ $self->log(2, "processing message $msgid for ". $recips);
}
@@ -590,7 +590,7 @@
# thanks to Kurt Andersen for this idea
if ( $self->{spampd}->{rh} ) {
if ($self->{spampd}->{pfs_uses_format}) {
- $self->log(2, "%s", "rules hit for $msgid: " .
$status->get_names_of_tests_hit); }
+ $self->log(2, "%s", "rules hit for $msgid: " .
$status->get_names_of_tests_hit);
} else {
$self->log(2, "rules hit for $msgid: " .
$status->get_names_of_tests_hit); }
}
@@ -711,7 +711,7 @@
if ( $self->{spampd}->{debug} ) {
if ($self->{spampd}->{pfs_uses_format}) {
- $self->log(2, "%s", "Destination response: '" . $destresp . "'");
}
+ $self->log(2, "%s", "Destination response: '" . $destresp . "'");
} else {
$self->log(2, "%s", "Destination response: '" . $destresp . "'");
}
}
