Your message dated Wed, 12 Dec 2018 13:34:17 +0000
with message-id <e1gx4ex-0005lg...@fasolo.debian.org>
and subject line Bug#916251: fixed in dvd+rw-tools 7.1-14
has caused the Debian Bug report #916251,
regarding dvd+rw-tools: FTBFS with glibc 2.28
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
916251: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916251
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: dvd+rw-tools
Version: 7.1-13
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch
Dear Maintainer,
dvd+rw-tools currently fails to build from source with glibc 2.28
because they changed the way the 'major' and 'minor' macros can be
accessed. [1] Specifically:
* The macros 'major', 'minor', and 'makedev' are now only available from
the header <sys/sysmacros.h>; not from <sys/types.h> or various other
headers that happen to include <sys/types.h>. These macros are rarely
used, not part of POSIX nor XSI, and their names frequently collide with
user code; see https://sourceware.org/bugzilla/show_bug.cgi?id=19239 for
further explanation.
<sys/sysmacros.h> is a GNU extension. Portable programs that require
these macros should first include <sys/types.h>, and then include
<sys/sysmacros.h> if __GNU_LIBRARY__ is defined.
We saw the following errors while building in Ubuntu accordingly:
growisofs.o growisofs_mmc.o -lpthread -o growisofs
/usr/bin/ld: growisofs.o: in function `find_raw_device':
./growisofs.c:658: undefined reference to `major'
/usr/bin/ld: ./growisofs.c:659: undefined reference to `minor'
/usr/bin/ld: growisofs.o: in function `grab_sg':
./growisofs.c:704: undefined reference to `minor'
collect2: error: ld returned 1 exit status
This is reproducible in sid as well.
In Ubuntu, the attached patch was applied to achieve the following:
* debian/patches/glibc-2.28.patch: Fix FTBFS with glibc >= 2.28.
Thanks for considering the patch.
Logan Rosen
[1] https://www.sourceware.org/ml/libc-alpha/2018-08/msg00003.html
-- System Information:
Debian Release: buster/sid
APT prefers cosmic-updates
APT policy: (500, 'cosmic-updates'), (500, 'cosmic-security'), (500,
'cosmic'), (400, 'cosmic-proposed'), (100, 'cosmic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.18.0-12-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru dvd+rw-tools-7.1/debian/patches/glibc-2.28.patch
dvd+rw-tools-7.1/debian/patches/glibc-2.28.patch
--- dvd+rw-tools-7.1/debian/patches/glibc-2.28.patch 1969-12-31
19:00:00.000000000 -0500
+++ dvd+rw-tools-7.1/debian/patches/glibc-2.28.patch 2018-12-11
23:42:00.000000000 -0500
@@ -0,0 +1,26 @@
+--- a/growisofs.c
++++ b/growisofs.c
+@@ -444,6 +444,10 @@
+ #include <assert.h>
+ #include "mp.h"
+
++#if defined(__GNU_LIBRARY__)
++# include <sys/sysmacros.h>
++#endif
++
+ #if defined(__unix) || defined(__unix__)
+ # include <unistd.h>
+ # include <sys/time.h>
+--- a/transport.hxx
++++ b/transport.hxx
+@@ -53,6 +53,10 @@
+ #define ENV_LOCALE ".OCP"
+ #endif
+
++#if defined(__GNU_LIBRARY__)
++# include <sys/sysmacros.h>
++#endif
++
+ #include "asctable.h"
+
+ #define CREAM_ON_ERRNO_NAKED(s) \
diff -Nru dvd+rw-tools-7.1/debian/patches/series
dvd+rw-tools-7.1/debian/patches/series
--- dvd+rw-tools-7.1/debian/patches/series 2018-10-09 10:05:01.000000000
-0400
+++ dvd+rw-tools-7.1/debian/patches/series 2018-12-11 23:38:51.000000000
-0500
@@ -10,3 +10,4 @@
ignore_pseudo_overwrite.patch
10-blue-ray-bug713016.patch
fix_burning_bd-r_discs.patch
+glibc-2.28.patch
--- End Message ---
--- Begin Message ---
Source: dvd+rw-tools
Source-Version: 7.1-14
We believe that the bug you reported is fixed in the latest version of
dvd+rw-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 916...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
TANIGUCHI Takaki <tak...@debian.org> (supplier of updated dvd+rw-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 12 Dec 2018 22:23:45 +0900
Source: dvd+rw-tools
Binary: growisofs dvd+rw-tools
Architecture: source amd64
Version: 7.1-14
Distribution: unstable
Urgency: medium
Maintainer: Optical Media Tools Team
<pkg-opt-media-t...@lists.alioth.debian.org>
Changed-By: TANIGUCHI Takaki <tak...@debian.org>
Description:
dvd+rw-tools - DVD+-RW/R tools
growisofs - DVD+-RW/R recorder
Closes: 916251
Changes:
dvd+rw-tools (7.1-14) unstable; urgency=medium
.
[ Jelmer Vernooij ]
* Transition to automatic debug package (from: dvd+rw-tools-dbg).
.
[ TANIGUCHI Takaki ]
* d/patches/glibc-2.28.patch: Fix FTBFS with glibc 2.28 (Closes: 916251)
Checksums-Sha1:
b11fa9238aefea2c1adb57345fd5924516bcc11b 2118 dvd+rw-tools_7.1-14.dsc
23d00798f64b68141c3abcacce6131c852b70159 23628
dvd+rw-tools_7.1-14.debian.tar.xz
0c596fb3bba85be09e1a9a8a1ff119d8a3b9d768 150760
dvd+rw-tools-dbgsym_7.1-14_amd64.deb
3e57c7397ed1758a6ab511abc033afebb6b32001 7003
dvd+rw-tools_7.1-14_amd64.buildinfo
22204441a4fb28f0cbd70ae1d023d3db11b96db1 87128 dvd+rw-tools_7.1-14_amd64.deb
3e62b67d69d3526ebad9260306ad1a490fbf802d 175116
growisofs-dbgsym_7.1-14_amd64.deb
3201c9fc77f95a5a533e0e2f798df3df6555bffc 71748 growisofs_7.1-14_amd64.deb
Checksums-Sha256:
87feca857c4baba33bc956d82309384d9a87c07f0ce74e0c1ccbc54597379148 2118
dvd+rw-tools_7.1-14.dsc
37af7d602118c8456af119d9d2164cbe10a47cd44cd6dec7c6a486bc4ed4490c 23628
dvd+rw-tools_7.1-14.debian.tar.xz
4de28b588d17ede6987948c4efb02bf091995270fdbc99a4a91d404aed6a1748 150760
dvd+rw-tools-dbgsym_7.1-14_amd64.deb
d431223468bee49538284a2c5240bfb3845c74e839585e0d56b32554435eb1eb 7003
dvd+rw-tools_7.1-14_amd64.buildinfo
a0a56e3f20dde597a8c60929978985b814589f55a7cd3633fa0859bc17d0a664 87128
dvd+rw-tools_7.1-14_amd64.deb
32cba37df2787c543f14d8cc8fa0dbf3b0fa0d61fcde75d622a6ad13180768d0 175116
growisofs-dbgsym_7.1-14_amd64.deb
ce610061975e9a25de3413c3f309a2fb7b01f5231effdad3a2de6e8a1dcf91fb 71748
growisofs_7.1-14_amd64.deb
Files:
6319b8ebcb6b2542d7f0856ce8abffe5 2118 video optional dvd+rw-tools_7.1-14.dsc
b56f57e578460bce3edb71fd858bdea3 23628 video optional
dvd+rw-tools_7.1-14.debian.tar.xz
32c24df7f17a146c8868603afca3f7dc 150760 debug optional
dvd+rw-tools-dbgsym_7.1-14_amd64.deb
6067702fb2166e44ed3b24acfe374521 7003 video optional
dvd+rw-tools_7.1-14_amd64.buildinfo
20b3b52366b1fcf8f77e9a1d6fcec491 87128 video optional
dvd+rw-tools_7.1-14_amd64.deb
8d6053b863967d2f543c6b699f157a91 175116 debug optional
growisofs-dbgsym_7.1-14_amd64.deb
874c308232241d7f8b407c4fc5e82522 71748 video optional
growisofs_7.1-14_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE0kq/0SfNJVahPGx5zBSfbCil4lcFAlwRDBoACgkQzBSfbCil
4lfs5w/+JBSngv8ZAi2l7BTXY5WOEWjlIO+cd8dW/TbtgKUYQj1OfH9WidlqEC6h
caKNVgarNX49a8JIW4qaQmr8S1gZi/zjei5DliQxhW7mkJOJmAmzJUKMsiZ3Gwfl
ppQkvQscP3pKDYhic4pe1VUuGshvw8wWscyFzOWVMjmgjeJGv1pJRxqAbwtDqPL6
Qf0Q25FuEV1tsevNBR19fI18FiMsOkNel3t8bdEjMcKQo2EXGuCpXNbEdysPDavm
2nWGi3UB/m5Big8e3xWw9EOCjWCoAv1zqxo38/LLwRztIUoQ+WfqvhOjLbYeBe1r
vIIN5yO6i+h9GpMglJIHpkAaxC5RCpTKglNO8GWYfkdQOOQ5CTOMZJWvZdaM5lxS
vUG2rz7/jTUNjIrnlNcjieopWQnnzGgwo0r4pPnpS2EzCcIDzlbDohNxP9LxAYDO
DoydTsCGzT+sEkAWNuEtTfyjomB108VKlxNWy1MtpF76qEMOtUXojylS4yuGeTfS
8l93ujCkhGNuzMgyOm9SY8DBD2uMRSdiad8n6fxUp0RreBIKXqwl+MKSpaw+Kjo9
KQFTbYq9EbT/84ROyGu+FsHBEI0YVAEHYsZU5mCAZKvTc3DHh+zFB1GbaJtSxlOj
eTWMOU5HdjurKl/9Pql3HDEMbOJO3lAcG4LT+7IcdDIrgp8kQPY=
=7Gzk
-----END PGP SIGNATURE-----
--- End Message ---
