Hi Kunal, Le 04/01/2019 à 16:12, Kunal Mehta a écrit : > On 1/3/19 6:57 PM, David Prévot wrote: >> Le 04/01/2019 à 12:50, Kunal Mehta a écrit : >>> This patch adds overrides for all symfony/polyfill-* packages to >>> pkg-php-tools itself, so all packages will automatically use it and no >>> longer automatically depend upon php-symfony-polyfill-* (and will cover >>> all current dependencies). >> >> Overrides can be added “locally” (for the build, in >> debian/pkg-php-tools-overrides, see e.g. twig). Anyway, this is not the >> only needed step, see below. > > Right. Are you saying you'd rather have the overrides in the individual > packages instead of in pkg-php-tools?
Since packages need to be rebuilt from source as binNMU are still (even for arch-all only source packages) not allowed for binary-all, we don’t need an archive-wide workaround (and you already pointed that there are only a handful of packages involved). > I'm happy to prepare patches (and > NMUs if necessary) either way Great. Feel free to team-upload stuff under the PHP PEAR (and Composer) umbrella too. > but I think we still need a pkg-php-tools > patch to support dropping the version constraint, which is included in > my current merge request. No opinion about pkg-php-tools, I’ll let Mathieu follow up. >>> And this one drops php-symfony-polyfill-* Just for the record (since I failed to point why those polyfill were packaged in first place), those packages may be useful in backport-style environments where the PHP version or extension constraints are different than the usual Debian environments. Also, I don’t mind if php-symfony-polyfill is gracefully removed from testing (and thus the next Buster release) unless someone feels that it may be useful. […] >> You also (rightfully) changed the autoload files. It’s not “just” a >> matter of removing the (build-)dependencies. > > Ack, I just wrote the commit message before I realized those also needed > to be removed. Fine by me (I just had to look at the actual MR to find out if you took everything into account). Regards David
signature.asc
Description: OpenPGP digital signature
