Your message dated Fri, 04 Jan 2019 11:25:29 +0000
with message-id <[email protected]>
and subject line Bug#898755: fixed in node-miller-rabin 4.0.1-3
has caused the Debian Bug report #898755,
regarding node-miller-rabin: FTBFS and flaky autopkgtests
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
898755: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898755
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: node-miller-rabin
Version: 4.0.1-1
Severity: serious
Tags: patch
User: [email protected]
Usertags: flaky

Hi Maintainer

Since 2017-12-28, node-miller-rabin has FTBFS in unstable [1] with the following error:

  0 passing (2s)
  1 failing

  1) Miller-Rabin
       should test number for primality:
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at done (/usr/lib/nodejs/mocha/lib/runnable.js:298:13)
      at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:372:7)
      at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
      at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
      at /usr/lib/nodejs/mocha/lib/runner.js:560:12
      at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
      at /usr/lib/nodejs/mocha/lib/runner.js:366:7
      at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
      at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)

The same test is run during autopkgtests and often fails, especially on the slower architectures which are tested in Ubuntu, but not in Debian.

I believe this is another example of the unreliable timing in tests being discussed in #853035.

I was able to work around the problem in Ubuntu by increasing the test timeout to 8000ms (4000ms was not sufficient on armhf) as per the patch below:

--- a/test/api-test.js
+++ b/test/api-test.js
@@ -4,6 +4,7 @@

 describe('Miller-Rabin', function() {
   it('should test number for primality', function() {
+    this.timeout(8000);
     assert(!mr.test(new bn(221)));
     assert(mr.test(new bn(257)));

Regards
Graham


[1] https://tests.reproducible-builds.org/debian/history/amd64/node-miller-rabin.html
--- End Message ---
--- Begin Message ---
Source: node-miller-rabin
Source-Version: 4.0.1-3

We believe that the bug you reported is fixed in the latest version of
node-miller-rabin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Xavier Guimard <[email protected]> (supplier of updated node-miller-rabin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 04 Jan 2019 11:01:29 +0100
Source: node-miller-rabin
Binary: node-miller-rabin
Architecture: source
Version: 4.0.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers 
<[email protected]>
Changed-By: Xavier Guimard <[email protected]>
Closes: 898755
Description: 
 node-miller-rabin - Miller Rabin algorithm for primality test
Changes:
 node-miller-rabin (4.0.1-3) unstable; urgency=medium
 .
   * team upload
   * Increase timeout in autopkgtest (Closes: #898755)
Checksums-Sha1: 
 c9dcc79517ea694ed36adac4602bf5911338814f 2208 node-miller-rabin_4.0.1-3.dsc
 9bcf0668efb633af7d584350f46bac47acac2dfb 3208 
node-miller-rabin_4.0.1-3.debian.tar.xz
Checksums-Sha256: 
 1b86d6f243ec2779173815d12d0e2ee44cfa81fb89e3f59101bf047df3205b38 2208 
node-miller-rabin_4.0.1-3.dsc
 4012a4fd4854ff8de3536fee185065480b7d8bb434b6779822128b846ef76932 3208 
node-miller-rabin_4.0.1-3.debian.tar.xz
Files: 
 cd53b90586a62388b89b2766047a288a 2208 javascript optional 
node-miller-rabin_4.0.1-3.dsc
 2c1f85b14faad94655279ccd0e337ce8 3208 javascript optional 
node-miller-rabin_4.0.1-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAlwvL2EQHHlhZGRAZGVi
aWFuLm9yZwAKCRD210ynyZnu6SGyD/9ZcY6xnA/pNFokQUC8Gz31Nsj4MUK5fgBa
ckqCVD0BWB53JZ4I/QUXWA2RlPvLBYauMIbVDafcFbBsvtleJw0An5AFAiwZDbCM
l/1pBzurZzM2lZ0ofRHESFox+ZInKHpM5RyWKNT2ZzFhvCzwJuW/87W6lM3zMkZg
NlEOGd5lQiAPsTrzNth3EZKPkFN1EvigWUmahsACaEBctu6lEUaIFt6V5UO8zTVo
b1o0vRu2gTlSwgiPPh8nfYhmXkh5Ey5UvClWLF40UjVpTk9W6LmaNpwtzV3W7sbi
NvhNPLQfH/SL03EkDJg2ZK8L8iIrFQO8kPHKUqpRftoaT3tGfK+FtN9HvgaBnwgk
9E/TKFhGyL25d4pbLRefwOCaDpi8GDL76SadsIbWAGkux83xC7qLSJCX5xhHNUTj
w/sqU4IlxgV3mygoeJHiE+ZaEE4GIGxA1IIlI7/GSfZTpRahLtvax7IsCn+aTJac
tskWNAKEiIOZv9Mpg/L+uZGuxtiw6OBVXQh37KlymtLg69PatRa3L7Bf2uK5Rdbg
ifDEg4tjF6tNS9nCC+yAC+UAzPPiaN4dmULelh8rQZd9QGTG3SoB2+EIhDxwoSC5
T3vo6MQK7Cu50ySybuzhj6T9ZAD7xZ+i2xSi40JLiC9Da6k/R4VjgH6g88JWodud
3rWrV9CDXg==
=eUl1
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to