Your message dated Sun, 06 Jan 2019 10:48:17 +0100
with message-id <[email protected]>
and subject line Fixed by nodejs 10.15 in sid
has caused the Debian Bug report #913508,
regarding nodejs FTBFS with ICU 63.1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
913508: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913508
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: nodejs
Source-Version: 8.11.2~dfsg-1
Severity: important
Tags: patch
Usertags: icu63
Dear Maintainer,
ICU 63.1 recently released, packaged and uploaded to experimental.
Its transition is going to start soon. However your package fails to
build with this version. I attach a patch which fixes the problem.
Please check if it works with the version in Sid and upload the
package when it's feasible for you.
Thanks,
Laszlo/GCS
Description: fix FTBFS with ICU 63.1
Add icu namespace.
Author: Laszlo Boszormenyi (GCS) <[email protected]>
Last-Update: 2018-11-04
---
--- nodejs-8.11.2~dfsg.orig/src/inspector_io.cc
+++ nodejs-8.11.2~dfsg/src/inspector_io.cc
@@ -74,11 +74,11 @@ std::string StringViewToUtf8(const Strin
size_t result_length = view.length() * sizeof(*source);
std::string result(result_length, '\0');
- UnicodeString utf16(unicodeSource, view.length());
+ icu::UnicodeString utf16(unicodeSource, view.length());
// ICU components for std::string compatibility are not enabled in build...
bool done = false;
while (!done) {
- CheckedArrayByteSink sink(&result[0], result_length);
+ icu::CheckedArrayByteSink sink(&result[0], result_length);
utf16.toUTF8(sink);
result_length = sink.NumberOfBytesAppended();
result.resize(result_length);
@@ -111,8 +111,8 @@ void ReleasePairOnAsyncClose(uv_handle_t
} // namespace
std::unique_ptr<StringBuffer> Utf8ToStringView(const std::string& message) {
- UnicodeString utf16 =
- UnicodeString::fromUTF8(StringPiece(message.data(), message.length()));
+ icu::UnicodeString utf16 =
+ icu::UnicodeString::fromUTF8(icu::StringPiece(message.data(), message.length()));
StringView view(reinterpret_cast<const uint16_t*>(utf16.getBuffer()),
utf16.length());
return StringBuffer::create(view);
--- nodejs-8.11.2~dfsg.orig/src/node_i18n.cc
+++ nodejs-8.11.2~dfsg/src/node_i18n.cc
@@ -523,7 +523,7 @@ const char* GetVersion(const char* type,
} else if (!strcmp(type, TYPE_UNICODE)) {
return U_UNICODE_VERSION;
} else if (!strcmp(type, TYPE_TZ)) {
- return TimeZone::getTZDataVersion(*status);
+ return icu::TimeZone::getTZDataVersion(*status);
} else if (!strcmp(type, TYPE_CLDR)) {
UVersionInfo versionArray;
ulocdata_getCLDRVersion(versionArray, status);
--- End Message ---
--- Begin Message ---
Closing because it's fixed in sid.
--- End Message ---
