Em qui, 7 de fev de 2019 às 04:32, Frank Heckenbach
<f.heckenb...@fh-soft.de> escreveu:
>
> > > My suggestion of 2018-11-25 still stands. But if you want me to do
> > > my part of it, please do your review quickly and tell me soon
> > > (or, if it's indeed necessary for the soft freeze, immediately) to
> > > avoid running out of time.
> >
> > Your plan sounds OK. Changing packages after the release, with time,
> > should be OK. I can submit automatic bug reports for the affected
> > packages.
>
> OK.
>
> > Maybe it would even be possible to have the applications set a global
> > variable, e.g.:
> >
> > enum class Render { Default = 1, Basic };
> > FTGL->setRender(Render renderType);
> >
> > and then the Render() function(s) would dispatch to either
> > RenderDefault() or RenderBasic() versions as appropriate?
>
> I generally don't much like global flags, but in this particular
> case, it might be the least painful approach.
>
> It wouldn't be foolproof. If two pieces of code, e.g. libraries,
> that are used in the same program, use Render() with different
> settings of this flag, one of them would do the wrong thing. (And
> manually changing this flag every time code from the other library
> may be used would be a maintenance nightmare.)
>
> So maybe the following is even easier to implement, while also not
> foolproof:
>
> - No RenderDefault() and RenderBasic(), just Render() as is.
>
> - A flag similar to your proposal (though I wouldn't actually call
> it "Render..."; if we aren't renaming the Render functions, we can
> use a more specific name), such as LegacyOpenGLState, and it can
> be a bool actually.
OK, sounds good. Your name is better, mine it was only an example.
The idea of using both RenderDefault() and RenderBasic() as well as
the flag, would equally work if you have just Render() and the
behaviour of one render or the other nested in an "if/else" based on
the flag. Whatever makes more sense to you. I suggested it because
in that way it is easier to change or patch the packages.
OK to the rest of the message.
Let me know when it's ready, I'll try to upload the new version within
the same day that you have the new release ready.
Cheers.
--
Manuel A. Fernandez Montecelo <manuel.montez...@gmail.com>
