Your message dated Wed, 06 Mar 2019 23:49:45 +0000
with message-id <[email protected]>
and subject line Bug#923707: fixed in pandas 0.23.3+dfsg-3
has caused the Debian Bug report #923707,
regarding statsmodels FTBFS: array |= frame now returns frame
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
923707: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923707
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: pandas
Version: 0.23+dfsg-2
Severity: serious
Control: affects -1 src:statsmodels
Control: tags -1 patch

The fix for #918206 (setting __array_priority__ to make np.array @ DataFrame work) is technically API breaking: in-place operators

arr = np.array(...)
df = pd.DataFrame(...)
arr += df

used to leave arr as an np.array (though this does not appear to have been documented), but now turn it into a DataFrame.

The only known [0] place where this fails a test is in statsmodels: as [1] now returns a DataFrame rather than a Series, it is now an exception for data passed to statsmodels.formula.api.OLS to contain both missing (NaN) values and duplicate index labels. As statsmodels.regression.tests.test_regression.test_missing_formula_predict contains such data, statsmodels 0.8.0-9 hence failed to build on the architectures where pandas was built first [2].

pandas upstream don't appear to have noticed this: they don't mention it in the discussion or release notes of the fix [3]. statsmodels upstream's response was to make this test stop using duplicate index names (without explicit comment) [4].

An alternative fix for #918206 that doesn't do this is

pandas/core/generic.py
     def __array_wrap__(self, result, context=None):
         d = self._construct_axes_dict(self._AXIS_ORDERS, copy=False)
+        if context is not None and context[0]==np.matmul
+            and not hasattr(context[1][0],'index'):
+            del d['index']
         return self._constructor(result, **d).__finalize__(self)

     # ideally we would define this to avoid the getattr checks, but

but this has not yet been tested in a full build.

[0] autopkgtest results - https://release.debian.org/britney/excuses.yaml
[1] https://sources.debian.org/src/patsy/0.5.0+git13-g54dcf7b-1/patsy/missing.py/#L136 [2] https://buildd.debian.org/status/fetch.php?pkg=statsmodels&arch=amd64&ver=0.8.0-9&stamp=1551564937&raw=0 [3] https://github.com/pandas-dev/pandas/pull/23114 https://github.com/pandas-dev/pandas/commit/ad2a14f4bec8a004b2972c12f12ed3e4ce37ff52 [4] (please *do not upload* this without discussion, or we may lose my other statsmodels work to the freeze) https://github.com/statsmodels/statsmodels/commit/30c9ddbff8a072cbc1bebc7550b667e760cb386a#diff-2708847815406a7890933a960465d8e8
--- End Message ---
--- Begin Message ---
Source: pandas
Source-Version: 0.23.3+dfsg-3

We believe that the bug you reported is fixed in the latest version of
pandas, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rebecca N. Palmer <[email protected]> (supplier of updated pandas package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 06 Mar 2019 22:19:34 +0000
Source: pandas
Binary: python-pandas python3-pandas python-pandas-doc python-pandas-lib 
python3-pandas-lib
Architecture: source
Version: 0.23.3+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Team 
<[email protected]>
Changed-By: Rebecca N. Palmer <[email protected]>
Description:
 python-pandas - data structures for "relational" or "labeled" data
 python-pandas-doc - documentation and examples for pandas
 python-pandas-lib - low-level implementations and bindings for pandas
 python3-pandas - data structures for "relational" or "labeled" data - Python 3
 python3-pandas-lib - low-level implementations and bindings for pandas - 
Python 3
Closes: 923707 923708
Changes:
 pandas (0.23.3+dfsg-3) unstable; urgency=medium
 .
   * Team upload.
   * Make np.array @ Series act the right way round.  (Closes: #923708)
   * Replace #918206 fix with a fix that doesn't change the return type
     and inplace-ness of np.array += DataFrame.  (Closes: #923707)
   * Fix missing page in documentation.
Checksums-Sha1:
 055413cb15494649aee982f540b3ce5b7fa7896e 4070 pandas_0.23.3+dfsg-3.dsc
 f732f4110e522903b97196a2a385f9596bcaaa11 3685260 
pandas_0.23.3+dfsg-3.debian.tar.xz
 ae7a29139d8243462547a3d00dbe5d007e75c431 6877 
pandas_0.23.3+dfsg-3_source.buildinfo
Checksums-Sha256:
 1055616281c2ec3e57cff8ba5ca8463b2f36569eb759f98ac2f868496267e228 4070 
pandas_0.23.3+dfsg-3.dsc
 32fcdf02c15bafc0543c6bf76c396817b17e83d2f96761a79a1a82e4660e0d95 3685260 
pandas_0.23.3+dfsg-3.debian.tar.xz
 207f7ccc01e664bc5f6c2a61745a21c91b2a2445ababe57fa21c6af7b2fad070 6877 
pandas_0.23.3+dfsg-3_source.buildinfo
Files:
 efb7adf08236a21b1b0c7eb009889f26 4070 python optional pandas_0.23.3+dfsg-3.dsc
 dea6cc8e3dd94d12b8aca94d00976b7b 3685260 python optional 
pandas_0.23.3+dfsg-3.debian.tar.xz
 5408cce086a7929771a11959afffe696 6877 python optional 
pandas_0.23.3+dfsg-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJMBAEBCAA2FiEEZ8sxEAXE7b4yF1MI3uUNDVZ+omYFAlyAUDAYHHJlYmVjY2Ff
cGFsbWVyQHpvaG8uY29tAAoJEN7lDQ1WfqJmm5IP/j9PKOpElWo5rOt2d+RPOoWh
aBN5Nom6Cz7yeOKZnMDWX6Y4gTlwz7zP+MbUUus6Wj8591HfoDCHcWWlNaRXAdWH
J0GiIy2XzLtY/Mh1Qmt2TLIJpLkYjtvlz+JngYZv1DIIylzm+BCQ18RQsXrB19qX
yiT5iPMoXyzoqQrbIzAoF2qxPBTXhWNmx1f44IAZgWibK7bRc6Q77sMS7C5Oig6W
vVisRiJSO8qmZwwfv2h528rvwirWOpeDNvngjFry0YycGhNQWI+YJKWQu0CjXOE0
/iviJwAPrj7ElXGVHcE2e9fmo5Mo3oXza4vhbcIUoybmFbIEqrGZTmBfC4ykQdbd
KRQfELn/AR0u4g2AYDZTXlQnE+SDfB/FLF4Hcwritc2HvWkEsGvR9zuzobXdBWgk
jvDD3pQa8G5ualERpJbggfhRYGcxobcw5hIJExv3gLQSjFsM+AvFRCku3xbner3h
BMsQA1r+OyMyckyA3PRa9x216G3aGg5OmIMC7RmYQb/7f1I6JlMP97LH446nxEuO
bSdeQStAcuDXdJSJc+dFpAp6rKGEZSR0rjP/KJ9WnFLAi0scioGwHoaxMmF8pDVW
mtR4+OoZB7RK4bss7NCO6s/2ieCIMWTK4+8CGCe/rpI68x0Ghk79F3awo4Jg4A32
5Hynkm5yvOY5qtanuqSM
=6m8Q
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to