Package: brightd
Version: 0.4.1-2
Severity: grave
Justification: renders package unusable

Dear Maintainer,

brightd does not fade because it wrongly thinks laptop is always on AC.

The problem is in the patch 
0002-Don-t-use-deprecated-proc-acpi-for-AC-detection.patch
|   FILE *ac = fopen("/sys/class/power_supply/AC/online", "r");
| ...
|   ac_state = fgetc(ac);
|   fclose(ac);
|   return ac_state;

In the kernel from debian buster the file opened contains '0' or '1',
the patch does not parse the character '0' but simple returns the
character casted to an int.
Which means the function isOnAC always returns true, which means brightd
currently does nothing, it never fades.

Output of brightd when on battery (or on AC, doesn't matter)
|brightd -w 5 -v
|Maximum brightness is 4437
|Opened X11 Display from ENV{DISPLAY}
|Opened a connection
|Would fade, but on AC
|Would fade, but on AC
|Would fade, but on AC
| ...

best regards,
gebi

-- System Information:
Debian Release: 10.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages brightd depends on:
ii  libc6     2.28-10
ii  libx11-6  2:1.6.7-1
ii  libxss1   1:1.2.3-1

brightd recommends no packages.

brightd suggests no packages.

-- no debconf information

Reply via email to