Your message dated Tue, 22 Oct 2019 15:04:29 +0000
with message-id <[email protected]>
and subject line Bug#942757: fixed in odb-api 0.18.1-9
has caused the Debian Bug report #942757,
regarding odb-api: fails to build with multiple supported python3 versions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
942757: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942757
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: odb-api
Version: 0.18.1-7
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

odb-api fails to build when multpile python3 versions are supported, as
is the case in Ubuntu Focal currently, like this:

for f in `py3versions --supported | sed -e 's%python3.7%%'  ` ; do \
        /usr/bin/make -C /<<PKGBUILDDIR>>/debian/build/$f 
DESTDIR=/<<PKGBUILDDIR>>/debian/tmp ; \
        done
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: *** /<<PKGBUILDDIR>>/debian/build/python3.8: No such file or 
directory.  Stop.
make[2]: Leaving directory '/<<PKGBUILDDIR>>'

(full log here:
https://launchpadlibrarian.net/447773633/buildlog_ubuntu-focal-amd64.odb-api_0.18.1-7build1_BUILDING.txt.gz)

It seems to me that the code that runs to configure the package for
other python versions is just wrong: it uses $$d in the argument to
--builddirectory which is not defined anywhere, it passed
--builddirectory to dh_auto_configure after "--" (so it is passed to the
upstream configure script, not dh) and it sets the build directory to be
a subdirectory of the "default" build directory. I don't know if this
last point is an actual problem (although it does smell funny to me),
but this patch fixes this anyway, as well as the other two problems.

Cheers,
mwh
-- System Information:
Debian Release: buster/sid
  APT prefers eoan
  APT policy: (500, 'eoan'), (400, 'eoan-proposed')
Architecture: amd64 (x86_64)

Kernel: Linux 5.3.0-18-generic (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru odb-api-0.18.1/debian/rules odb-api-0.18.1/debian/rules
--- odb-api-0.18.1/debian/rules 2019-09-02 04:48:13.000000000 +1200
+++ odb-api-0.18.1/debian/rules 2019-10-21 14:17:49.000000000 +1300
@@ -55,14 +55,14 @@
        done
        dh_auto_configure --  ${CMAKE_CFLAGS} 
-DPYTHON_EXECUTABLE=/usr/bin/${PY3DEFAULT}
        for f in ${PY3OTHERS} ; do \
-               dh_auto_configure --  ${CMAKE_CFLAGS} 
-DPYTHON_EXECUTABLE=/usr/bin/$$f \
-                        --builddirectory=$(BUILDDIR)/$$d ; \
+               dh_auto_configure --builddirectory=$(BUILDDIR)-$$f \
+                         -- ${CMAKE_CFLAGS} -DPYTHON_EXECUTABLE=/usr/bin/$$f; \
                done
 
 override_dh_auto_build:
        $(MAKE) -C $(BUILDDIR) DESTDIR=$(DESTDIR)
        for f in ${PY3OTHERS} ; do \
-               $(MAKE) -C $(BUILDDIR)/$$f DESTDIR=$(DESTDIR) ; \
+               $(MAKE) -C $(BUILDDIR)-$$f DESTDIR=$(DESTDIR) ; \
                done
 
 override_dh_auto_test:

--- End Message ---
--- Begin Message ---
Source: odb-api
Source-Version: 0.18.1-9

We believe that the bug you reported is fixed in the latest version of
odb-api, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alastair McKinstry <[email protected]> (supplier of updated odb-api package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 22 Oct 2019 13:40:54 +0100
Source: odb-api
Architecture: source
Version: 0.18.1-9
Distribution: unstable
Urgency: medium
Maintainer: Alastair McKinstry <[email protected]>
Changed-By: Alastair McKinstry <[email protected]>
Closes: 924571 942757
Changes:
 odb-api (0.18.1-9) unstable; urgency=medium
 .
   * Build python3.8 properly. Closes: #942757
   * Better fix for MIPS64 FTBFS, thanks to YunQuiang Su. Closes: #924571
Checksums-Sha1:
 ab82315c8c49db23e6e06d032dc29c1263d76ad0 2536 odb-api_0.18.1-9.dsc
 986fffe63e7bf8e6f2734e874fdb6da7b71db4b5 27028 odb-api_0.18.1-9.debian.tar.xz
Checksums-Sha256:
 78d11c5cda85311ea3b4c9f7de20176564182461823e7f5e2959a4cf117bd309 2536 
odb-api_0.18.1-9.dsc
 4ab427ffef6a707a408108aa1410a874bda08231b77ed7872276bcd1f059b825 27028 
odb-api_0.18.1-9.debian.tar.xz
Files:
 2031c79382da86ddbc60dcedd4ea8754 2536 utils optional odb-api_0.18.1-9.dsc
 ed00368b35ee1a4ed166347a4c8b75f5 27028 utils optional 
odb-api_0.18.1-9.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEgjg86RZbNHx4cIGiy+a7Tl2a06UFAl2vFSkACgkQy+a7Tl2a
06X1cg//dAGVVdGroZkcdDd3WIpHwcxzWHJOIV4/av4DIH89uJyUpAgzp7j4uv2T
mXNEUX2CEjuL2RLzqK2fNauK2unYZ8yJl2sXfaQ3v9ejKWQbbn0XVnpL0Wz+pQ5W
+9t+EW4iJhXb7XILnHWR9UFX4ZVLuON77MNV6MCRyrceIV+iSQ/djmHefnF1DsKq
55reXlN/Lqm1/zq3pTzIF2mzpcYRZeGoh9zpnzIMQpR4PyCCayXA8kqR6PplGLH4
AmHXylj/e7yhcXf+sjXiqqUmWN64FVG0tQGhsWZouSy0+2ZcMGJjdMEm4PLOr3xk
zqL2Es5WAmcVYL+A7xM0g+0ly92LFRfUdb2L1feFiPTBaCsCKyb3hL2wr7BYqXly
yBS6nulUn6Apt2UBUyu0dzpsKJ8jy0vGYJfDbooGORDeTr0G7ONxg8B1xVnDDgYd
1aKGB6JBIF23JzqQUF74uBYOTHP6kRDFX3OU2GKIOlqDG2LgYXePQ6Vf+7tnU81j
qNJoOxRnZyrfQ2y9CE5wX2C8bhUVB/tbUYlIMUORFn4yr0+5XNuB1mAjfrMJAtWI
gIzwtpDLwgmUjwgM9Kwo5RaJQaoleP3TfOlejcLgnwSKJZSm+Je4e5V5GrEU4aPE
NNPYebzb1Ilfuas7lYBq4RB0Ag6zHm9l913NfEivgvFlcCsdbf0=
=aVy4
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to