Your message dated Thu, 07 May 2020 13:18:30 +0000
with message-id <e1jwgq2-000hw1...@fasolo.debian.org>
and subject line Bug#959729: fixed in acpi-call 1.1.0-6
has caused the Debian Bug report #959729,
regarding acpi-call-dkms: fails to build on kernel 5.6
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
959729: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959729
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: acpi-call-dkms
Version: 1.1.0-5
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source
Dear Maintainer,
Building modules for kernel 5.6.0-1-amd64 fails with
error: passing argument 4 of ‘proc_create’ from incompatible pointer type
[...]
expected ‘const struct proc_ops *’ but argument is of type ‘struct
file_operations *’
This seems to be due to a kernel change from earlier this year:
https://github.com/torvalds/linux/commit/97a32539b9568bb653683349e5a76d02ff3c3e2c
It can be naively be fixed by applying the changes suggested in that commit,
in acpi_call.c:321 changing :
static struct file_operations proc_acpi_operations = {
.owner = THIS_MODULE,
.read = acpi_proc_read,
.write = acpi_proc_write,
};
to
static struct proc_ops proc_acpi_operations={
.proc_read = acpi_proc_read,
.proc_write = acpi_proc_write,
};
Which seems to fix the build for 5.6. It probably breaks it for kernels older
than 5.6,
so it would need some conditionals.
-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (900, 'testing'), (500, 'stable-updates'), (500,
'oldstable-updates'), (500, 'stable'), (500, 'oldstable'), (50,
'experimental'), (50, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.6.0-1-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8),
LANGUAGE=en_IE:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages acpi-call-dkms depends on:
ii dkms 2.8.1-5
acpi-call-dkms recommends no packages.
acpi-call-dkms suggests no packages.
-- no debconf information
-- debsums errors found:
debsums: changed file /usr/src/acpi-call-1.1.0/acpi_call.c (from acpi-call-dkms
package)
--- End Message ---
--- Begin Message ---
Source: acpi-call
Source-Version: 1.1.0-6
Done: =?utf-8?q?Rapha=C3=ABl_Halimi?= <raphael.hal...@gmail.com>
We believe that the bug you reported is fixed in the latest version of
acpi-call, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 959...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Raphaël Halimi <raphael.hal...@gmail.com> (supplier of updated acpi-call
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 07 May 2020 14:58:58 +0200
Source: acpi-call
Architecture: source
Version: 1.1.0-6
Distribution: unstable
Urgency: medium
Maintainer: Raphaël Halimi <raphael.hal...@gmail.com>
Changed-By: Raphaël Halimi <raphael.hal...@gmail.com>
Closes: 959364 959729
Changes:
acpi-call (1.1.0-6) unstable; urgency=medium
.
* [ce9dd75] Fix patches order (#3 was applied first)
* [01a2d16] Add patch to fix build on Linux 5.6.
Thanks to Nikita Knutov for the patch, Thomas Koch and Gard Spreemann for
pointing me to the patch (Closes: #959364, #959729)
* [6ca6f81] Bump Standards-Version to 4.5.0
* [f14a922] Bump debhelper compat to 12
* [93b030a] Silence lintian about spelling error (false positive)
Checksums-Sha1:
735929db994e1d1a0bb17376ec98c3665be16bf6 2007 acpi-call_1.1.0-6.dsc
dd0e307a6e51e180840f06e94e5abf34618ba657 4384 acpi-call_1.1.0-6.debian.tar.xz
7ed13adedd7f5eb45f91d6e5dde744498e7ccd4a 6157 acpi-call_1.1.0-6_amd64.buildinfo
Checksums-Sha256:
53c2acba82b70095667297d8ee53f85b6064faf20a60c6dd76f6cacbe44d22e8 2007
acpi-call_1.1.0-6.dsc
087cc98902f2e7412876b08a6447f129a6836a3751794cb25acb54fd8ca2489e 4384
acpi-call_1.1.0-6.debian.tar.xz
6ed9542dfb8b1fc8a8507155c7d82a1467b5d1c6c70f518b18d7b6345dbf8e20 6157
acpi-call_1.1.0-6_amd64.buildinfo
Files:
69d1aee29507e5635d9869bfe8a87421 2007 kernel optional acpi-call_1.1.0-6.dsc
e2813dacbc87d4ae73b136d4ef9728e4 4384 kernel optional
acpi-call_1.1.0-6.debian.tar.xz
5fbc99ee9625d6ac650f6643a1fb2aad 6157 kernel optional
acpi-call_1.1.0-6_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEb6lOxdKMjWi+eSrvTZn2ZgpZgnsFAl60B+pfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDZG
QTk0RUM1RDI4QzhENjhCRTc5MkFFRjREOTlGNjY2MEE1OTgyN0IACgkQTZn2ZgpZ
gnvQWQ//c3Gl6vDi1P6d+82LvBupgLer1y8Qyo/tmCrE7E9sJxHleQQLtRehWcYL
MPlqkOqtGohWkxFPbv2FEzpQAQ3er/B9GOMX0bU8q/EDwHuObpyOzzZ0k7GDfAJX
sUff7dUZDoTfiLGL8F2qW+UabKMnGGkxTgdbftzqyBCswmjrMO2PmS/ti6d6wUZG
/6mtg5ckhgGkjVpWzUPCX0NjCPa71R+STKaLisEFelqPpddaMOFu3ZX5oSH+61O5
2AH6t0SpQ8AWq4msKF1xq+hT17gJ9BxvPnYQUmtooGpEBObchUAYVdDMLkcYitE7
g7BKTPVCW7lz4XLb9tg6szkF+Qk2oR7NdeeUY7X6OE2SfIqgeV1ULLatI/23MCr/
R4Sb9zzS+PenK0ZVoiMmR7IuE45yKQUih3/S8iQITNLUa8aP/ap6eDRI9GiqaSBo
ldprqlhcfp5Tsh+SDs5Ws/d71zWrpIg7hQqWKOds4+Sz9Q17l334T09ml32EYdZ7
e5tJ0sd2kEMmQhOj3nRUmFaoKTD03Dht6jl6TFeKYuMqx6dNe8MG9yBMXO5PXqKM
m2Flf1AkHnWKuWtkgNZaVQtbY8nd9YtP19fwQmiY4UJbPnhsGYr1tSB+l0d0LGwy
TaQ4pHFSQZ1P+5c13RMM8yHDoepRqite68heNMb0E1cTKw4FyXk=
=JxNH
-----END PGP SIGNATURE-----
--- End Message ---
