Quoting Jonas Smedegaard (2020-05-14 17:03:31) > Quoting Jonas Smedegaard (2020-05-14 16:48:37) > > Quoting Pirate Praveen (2020-05-14 14:18:20) > > > On Thu, May 14, 2020 at 1:12 pm, Jonas Smedegaard <jo...@jones.dk> > > > wrote: > > > > Quoting Pirate Praveen (2020-05-05 15:11:31) > > > >> I'm planning to upload node-grunt-babel 8.0 in unstable (it is in > > > >> experimental currently). I have fixed all the reverse build > > > >> dependencies and this is the only remaining blocker. I have fixed > > > >> this package in babel7 branch of salsa. > > > > > > > > I doubt the patch was actually tested - I was unable to reproduce a > > > > succesful build. > > > > > > > > > > It built fine for me, attaching sbuild log. > > > > Thanks, that was (not enough, but) very helpful: autopkgtest still fails > > for me, and I would appreciate if you could test if you agree that it > > fails for you as well. > > > > Turns out there are two issues here: > > > > With Babel 6, "babeljs --out-dir dist src/foo.js src/deeper/bar.js" > > creates dist/deeper/bar.js, where with Babel 7 that command instead > > creates dist/bar.js - your latest patch changes to an alternative form > > "babeljs --out-dir dist src" which works. Thanks for that! > > > > Another issue (also experienced with your earlier gulp patch) is that > > the _content_ produced by Babel 6 works with the (arguably crude and > > unsupported) autopkgtest, but with Babel 7 it fails like this: > > > > Error: Cannot find module ./utils > > at modRequire (/usr/share/javascript/webrtc-adapter/adapter.js:10:22) > > at Object.1 (/usr/share/javascript/webrtc-adapter/adapter.js:40:37) > > at req (/usr/share/javascript/webrtc-adapter/adapter.js:6:22) > > at modRequire (/usr/share/javascript/webrtc-adapter/adapter.js:11:14) > > at Object.0../adapter_factory.js > > (/usr/share/javascript/webrtc-adapter/adapter.js:26:24) > > at req (/usr/share/javascript/webrtc-adapter/adapter.js:6:22) > > at 0../adapter_factory.js > > (/usr/share/javascript/webrtc-adapter/adapter.js:2:20) > > at Object.<anonymous> > > (/usr/share/javascript/webrtc-adapter/adapter.js:14:3) > > at Module._compile (internal/modules/cjs/loader.js:778:30) > > at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10) > > > > > > The generated code is also suspicously much much smaller. > > > > This pattern works with Babel 6: > > > > babeljs --cwd src/deeper --out-dir dist src/foo.js src/deeper/bar.js > > > > ...but there is no "cwd" command-line option with Babel 7, it seems. > > Weird: --cwd doesn't work with Babel 6 either, not sure what worked > before. > > Seems "--source-root src/js/index.js" is the equivalent of gulp "cwd" > option. Works with Babel 6 - trying now with Babel 7...
No, fails.
The package now checks unit tests during build, and switching to Babel 7
causes one of those to fail:
not ok 69 Log suppression "before each" hook for "does not call console.log by
default"
Cannot find module ./utils
Error: Cannot find module ./utils
at modRequire (out/adapter.js:10:22)
at Object.1 (out/adapter.js:40:37)
at req (out/adapter.js:6:22)
at modRequire (out/adapter.js:11:14)
at Object.0../adapter_factory.js (out/adapter.js:26:24)
at req (out/adapter.js:6:22)
at 0../adapter_factory.js (out/adapter.js:2:20)
at Object.<anonymous> (out/adapter.js:14:3)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Module.require (internal/modules/cjs/loader.js:692:17)
at require (internal/modules/cjs/helpers.js:25:18)
at Context.beforeEach (test/unit/logSuppression.js:27:5)
at callFn (/usr/share/nodejs/mocha/lib/runnable.js:395:21)
at Hook.Runnable.run (/usr/share/nodejs/mocha/lib/runnable.js:382:7)
at next (/usr/share/nodejs/mocha/lib/runner.js:384:10)
at Immediate._onImmediate (/usr/share/nodejs/mocha/lib/runner.js:428:5)
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
