> Given that you say this was a build incompatibility, could you
> explain why you thought it was necessary to add a runtime Breaks:?

The setup.py for mitmproxy 4 sets an explicit upper limit on tornado
compatibility ("tornado>=4.3,<5.2"). The upstream commit [1] which relaxes
this constraint replaces usage of tornado.wsgi.WSGIAdapter which is
removed in tornado 6 (but imported unconditionally in mitmproxy 4),
but there might be other changes too.

Is this not a case where it is proper to declare that updating tornado
breaks this version of mitmproxy?

[1]:
https://github.com/mitmproxy/mitmproxy/commit/902ef59d01f45613ce33520159e157697bcc6f9f

Reply via email to