forwarded 369726 [EMAIL PROTECTED] thanks hi Steve,
On Wed, May 31, 2006 at 09:47:11PM -0700, Steve Langasek wrote: > (gdb) up > #1 0x000000000048726b in Enter (w=0x6bc210, event=0x7fffffa82be0) > at MenuBtn.c:1479 > 1479 mbutton->menubutton.hintProc(mbutton->menubutton.hint); > (gdb) print mbutton->menubutton.hintProc > $9 = (XwStrProc) 0x47b5db <Wprintf> > (gdb) print mbutton->menubutton.hint > $10 = 0x6bbaa0 "set fill properties" > (gdb) > > And the prototype of Wprintf() is: > > void Wprintf(char *format, ...); > > The bug here is that xcircuit is incorrectly assuming that it's ok to call a > function that uses varargs using the regular calling convention, which is > obviously false for amd64. > > The attached patch fixes this, and gives me a minimally-usable package on > amd64. there is a discussion about a few other outstanding issues on the xcircuit-dev [1] list, lets see what comes up. Im going to prepare a QA Upload as things settle down. Thanks for your patch, im forwarding it to upstreams. [1] http://opencircuitdesign.com/pipermail/xcircuit-dev/2006/000202.html > diff -u xcircuit-3.6.24/debian/changelog xcircuit-3.6.24/debian/changelog > --- xcircuit-3.6.24/debian/changelog > +++ xcircuit-3.6.24/debian/changelog > @@ -1,3 +1,11 @@ > +xcircuit (3.6.24-1.1) unstable; urgency=low > + > + * Non-maintainer upload. > + * Fix gross prototype mismatch bug, so the program is usable again on > + amd64. Closes: 369276. > + > + -- Steve Langasek <[EMAIL PROTECTED]> Wed, 31 May 2006 21:29:13 -0700 > + > xcircuit (3.6.24-1) unstable; urgency=low > > * QA Upload > only in patch2: > unchanged: > --- xcircuit-3.6.24.orig/Xw/XwP.h > +++ xcircuit-3.6.24/Xw/XwP.h > @@ -322,7 +322,7 @@ > > typedef void (*XwStrProc)( > #if NeedFunctionPrototypes > - String /* hint */ > + char *format, ... /* hint */ > #endif > ); > bye, - michael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
