Bug#966692: stunnel4: FTBFS because of test hang

[Peter Pentchev]

On Sun, Aug 02, 2020 at 02:02:22AM +0200, Michał Mirosław wrote:
> Source: stunnel4
> Severity: serious
> Tags: ftbfs
> Justification: fails to build from source (but built successfully in the past)
> X-Debbugs-Cc: Michał Mirosław <mirq-debo...@rere.qmqm.pl>
> 
> The bug #955710 turns out to be only partially fixed. Now without a binary
> to exec the test runtime doesn't hang. When the binary is correct, though,
> it still can't stop asking the pipe for more data after EOF.
> 
> $ dpkg-buildpackage -b
> [...]
> env TEST_STUNNEL=.../stunnel4-5.56+dfsg/src/stunnel debian/tests/runtime
> Found the certificate at debian/tests/certs/certificate.pem and the private 
> key at debian/tests/certs/key.pem
> Using the /tmp/AgCSdk8YKw temporary directory                
> About to get the stunnel version information                 
> Got stunnel version 5.56                                     
> ^Cmake[1]: *** [debian/rules:32: execute_before_dh_auto_test] Interrupt
> make: *** [debian/rules:106: binary] Error 1
> 
> From the manual run under strace:
> 
> $ TEST_STUNNEL=src/stunnel strace -f -o /tmp/log debian/tests/runtime
> 
> I can see (excerpt):
[snip useful excerpt]

Hi,

Thanks a lot for reporting this and for the strace output!

Can you check whether the attached trivial patch will work for you?
There is a slightly more verbose way to do pretty much the same, but
let's see if this works first. If it does... sorry, I really should have
done this from the start!

G'luck,
Peter

-- 
Peter Pentchev  r...@ringlet.net r...@debian.org p...@storpool.com
PGP key:        http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115  C354 651E EFB0 2527 DF13

commit fb2a11a3654e3070084515da89f415361671f922
Author: Peter Pentchev <r...@debian.org>
Date:   Sun Aug 2 17:31:26 2020 +0300

    Destroy the stunnel version watcher on EOF.

diff --git a/debian/tests/runtime b/debian/tests/runtime
index ecffe7b..109c965 100755
--- a/debian/tests/runtime
+++ b/debian/tests/runtime
@@ -432,6 +432,7 @@ MAIN:
 
                                if (!defined $line) {
                                        $eof->send($got_version);
+                                       undef $f_out;
                                } elsif (!$got_version) {
                                        if ($line =~ m{^
                                                stunnel \s+

signature.asc
Description: PGP signature