Your message dated Wed, 05 Aug 2020 06:20:21 +0000
with message-id <e1k3cmj-0001k0...@fasolo.debian.org>
and subject line Bug#964915: fixed in raspi-firmware 1.20200601-1
has caused the Debian Bug report #964915,
regarding raspi-firmware: upgrading kernel or firmware causes system to become 
unbootable on pi 4 (ROOTPART hardcoded to /dev/mmcblk0p2 instead of 
/dev/mmcblk1p2)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
964915: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964915
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: raspi-firmware
Version: 1.20200212-1
Severity: important

On a Raspberry Pi 4B using one of the brand new Pi 4 daily images, I
discovered that installing the firmware-misc-nonfree package would cause
the machine to not boot.

Further investigation found that during the package installation,
/boot/firmware/cmdline.txt was modified in the following manner:

-console=tty0 console=ttyS1,115200 root=LABEL=RASPIROOT rw elevator=deadline 
fsck.repair=yes net.ifnames=0 rootwait
+console=tty0 console=ttyS1,115200 root=/dev/mmcblk0p2 rw elevator=deadline 
fsck.repair=yes net.ifnames=0 rootwait

After I changed this back to LABEL=RASPIROOT, the machine was able to boot
again. On the machine in question, there is no such block device:

dilinger@rpi4-20200710:~$ ls -l /dev/mmcblk0p2
ls: cannot access '/dev/mmcblk0p2': No such file or directory
dilinger@rpi4-20200710:~$ ls -lh /dev/mmcblk1p2 
brw-rw---- 1 root disk 179, 2 Feb 14  2019 /dev/mmcblk1p2

The culprit here is the following in /etc/kernel/postinst.d/z50-raspi-firmware:

cat >/boot/firmware/cmdline.txt <<EOF
${pre_cmdline} root=$ROOTPART rw elevator=deadline fsck.repair=yes 
net.ifnames=0 rootwait
EOF

ROOTPART is hardcoded to /dev/mmcblk0p2, which seems.. suboptimal.

I don't know if it would break any of the other pi boards that rely on this
package, but I would suggest any of the following fixes:

1) setting ROOTPART=`findmnt -n --output=source /boot/firmware/`,
2) or using the label and doing ROOTPART=`findmnt -n --output=source 
/boot/firmware/`; ROOTLABEL="`lsblk -no label $ROOTPART`",
and when overwriting cmdline.txt using "root=LABEL=$ROOTLABEL",
3) or my personal favorite - not touching cmdline.txt at all. I don't really
see the point of modifying it during postinst of a kernel package, unless
the pre_cmdline stuff needs to modify console boot settings for some reason.


[BTW, I debated whether to make this an RC bug, but I figured since the pi4
images are still very much a work-in-progress that it wasn't worth filing
this as critical.]

--- End Message ---
--- Begin Message ---
Source: raspi-firmware
Source-Version: 1.20200601-1
Done: Gunnar Wolf <gw...@debian.org>

We believe that the bug you reported is fixed in the latest version of
raspi-firmware, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 964...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gunnar Wolf <gw...@debian.org> (supplier of updated raspi-firmware package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 05 Aug 2020 00:57:15 -0500
Source: raspi-firmware
Architecture: source
Version: 1.20200601-1
Distribution: unstable
Urgency: medium
Maintainer: pkg-raspi <pkg-raspi-maintain...@lists.alioth.debian.org>
Changed-By: Gunnar Wolf <gw...@debian.org>
Closes: 964915
Changes:
 raspi-firmware (1.20200601-1) unstable; urgency=medium
 .
   [ Romain Perier ]
   * New upstream version 1.20200601
 .
   [ Gunnar Wolf ]
   * Fix z50-raspi-firmware causing an unbootable system due to the
     hardcoding of partition numbers (Closes: #964915)
Checksums-Sha1:
 b616db017a743cec488fc163860c4a0df1be6165 1640 raspi-firmware_1.20200601-1.dsc
 87c6a745a7ca016687d13523ac2e0c61e6ff3ca5 4862668 
raspi-firmware_1.20200601.orig.tar.xz
 bdd8847fd312fcdbb114b34e82e17f0ab48426a7 25024 
raspi-firmware_1.20200601-1.debian.tar.xz
 0723f4a27687d4c3f0b6362add3746b16ef11b57 5159 
raspi-firmware_1.20200601-1_source.buildinfo
Checksums-Sha256:
 03b88ad1e3a9499196666153dfdd9bdeb30aa7e796e78b01c952941dc992c67e 1640 
raspi-firmware_1.20200601-1.dsc
 5f34f54122be640a4d0217c4fb5af757f898a17c1ccd9f53f915213dc847e309 4862668 
raspi-firmware_1.20200601.orig.tar.xz
 86476c61904193cb4a683a352e264943f8739c8ccb4ea1c45411ae6ee18f8fd8 25024 
raspi-firmware_1.20200601-1.debian.tar.xz
 f9566630d3123f85fd030cc40276a6d8b44ac086412f732c0c643c99c26bee46 5159 
raspi-firmware_1.20200601-1_source.buildinfo
Files:
 2b7536f42460f44347381e3df3b8e134 1640 non-free/misc optional 
raspi-firmware_1.20200601-1.dsc
 ba79bc985e08203803e392e17ddc42d8 4862668 non-free/misc optional 
raspi-firmware_1.20200601.orig.tar.xz
 759f2ab761aaa0c7e0bb94d048eb16a7 25024 non-free/misc optional 
raspi-firmware_1.20200601-1.debian.tar.xz
 e1542382e6f39e777bd131f1a17fac9f 5159 non-free/misc optional 
raspi-firmware_1.20200601-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iIcEARYIAC8WIQRgswk9lhCOXLlxQu/i9jtDU/RZiQUCXypKgBEcZ3dvbGZAZGVi
aWFuLm9yZwAKCRDi9jtDU/RZiY0XAQC/FNsGxH8Gd/Z41a0G5O9z9UYbyB8wkRiQ
QYCA+I4o/QD8C1izj8jGF3NcATJKkoypcasXX/obthxrwKA+RjJSrwY=
=RW/V
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to