Your message dated Tue, 06 Jun 2006 07:50:09 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Removed
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: bidwatcher
Version: 1.3.17-1
Severity: grave
Tags: security

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

In helpers.cpp, we find this code, which parses data returned from ebay:

   /*
    * Parse the description out of the buffer first. This is
    * most easily done at the buffer-level and not as we try
    * to read the buffer in a line-oriented manner. There is
    * probably a need to re-write this parser all together,
    * but that's not what I'm going to do right now.
    * Thanks to Bob Beaty!
    */
   scratch = strstr(Buff, ") -");
   if (scratch != NULL) {
     // move past the ") -"
     scratch += 3;
     // move past any whitespace
     while (isspace(*scratch)) scratch++;
     // copy over the description to a newline
     idx = 0;
     while (*scratch != '\n') {
       Description[idx++] = *scratch++;
     }
     // NULL terminate the description I just parsed off
     Description[idx] = '\0';
   } else {
     return FALSE;
   }

Notice how it copies an abitrary amount of data, as much as ebay returns
before \n, into Description. 

In bidwatcher.h, Description is defined as a char array:

struct auctioninfo {
        unsigned long long ItemNumber; /* Item Number (User Entered)   */
        char Description[129];        /* Description Of Item For sale */
        char Comments[COMMENT_LENGTH];/* User-defined comments        */
        // ... 
}


The rest of this struct looks disturbing, too.

- -- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable'), (130, 'unstable'), (120, 
'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.10-bohr
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages bidwatcher depends on:
ii  libc6                  2.3.2.ds1-22      GNU C Library: Shared libraries an
ii  libcurl3               7.14.0-2          Multi-protocol file transfer libra
ii  libgcc1                1:4.0.0-9         GCC support library
ii  libglib1.2             1.2.10-10         The GLib library of C routines
ii  libgtk1.2              1.2.10-17         The GIMP Toolkit set of widgets fo
ii  libidn11               0.5.13-1.0        GNU libidn library, implementation
ii  libssl0.9.7            0.9.7e-3          SSL shared libraries
ii  libstdc++5             1:3.3.5-13        The GNU Standard C++ Library v3
ii  libx11-6               4.3.0.dfsg.1-14   X Window System protocol client li
ii  libxext6               4.3.0.dfsg.1-14   X Window System miscellaneous exte
ii  libxi6                 4.3.0.dfsg.1-14   X Window System Input extension li
ii  xlibs                  4.3.0.dfsg.1-14   X Keyboard Extension (XKB) configu
ii  zlib1g                 1:1.2.2-4.sarge.1 compression library - runtime

bidwatcher recommends no packages.

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFC4QJ6+z+IwlXqWf4RAmWmAJkBIdsx9WRAK5b+hwJv+6m2zKFoVACeMi2o
BQ8aodXcS4CfbH8/FRjNK2M=
=AhfB
-----END PGP SIGNATURE-----


--- End Message ---
--- Begin Message ---
bidwatcher was removed from Debian in October due to security
vulnerabilities and other breakage.  For details, please see
<http://bugs.debian.org/331684>.

--- End Message ---

Reply via email to