Control: forwarded -1 https://github.com/shirou/gopsutil/issues/881
I'm having a hard time seeing bugs like this as RC-critical. Looking at the testsuite more specifically, I strongly believe this is upstream bug https://github.com/shirou/gopsutil/issues/881 Lucas, can you please post /proc/cpuinfo from the amd64 machine you tested on so that we confirm that it doesn't report a modelname? I'd concur with Andreas to disable running tests on !amd64, maybe with something like this patch: modified debian/rules @@ -10,3 +10,9 @@ export CIRCLECI := true %: dh $@ --buildsystem=golang --with=golang + + +override_dh_auto_test: +ifneq (,$(filter $(DEB_HOST_ARCH), amd64)) + dh_auto_test --buildsystem=golang +endif Alternativly, we could also disable the "problematic part" of the test until the upstream bug is fixed properly: diff --git a/cpu/cpu_test.go b/cpu/cpu_test.go index e8e0e8d..dbcaaae 100644 --- a/cpu/cpu_test.go +++ b/cpu/cpu_test.go @@ -85,11 +85,6 @@ func TestCpuInfo(t *testing.T) { if len(v) == 0 { t.Errorf("could not get CPU Info") } - for _, vv := range v { - if vv.ModelName == "" { - t.Errorf("could not get CPU Info: %v", vv) - } - } } In any case, I'm unconvinced that this bug is severe enough to claim it as 'release critical' would warrant removing the package from unstable.
