Hi Markus.

I replaced my init scripts with the versions from your merge. And tried with various combinations of spaces and quotes. Works very well. Great regex/escape-fu.

Best Regads,
Norbert.

On 27.12.2020 14:32, Markus Wanner wrote:
Control: -1 severity grave
Control: -1 tags +pending

Hi,

On 11/21/20 3:46 PM, Norbert Harrer wrote:
> But in /etc/init.d/courier-mta-ssl it is parsed with sed:
>
> DO_START=$(sed -ne 's/^ESMTPDSSLSTART=\([^[:space:]]*\)/\1/p'
> /etc/courier/esmtpd-ssl | tr "A-Z" "a-z")

thanks a lot for this fine analysis.  I propose to tweak the regular expressions to be more resilient to quotes (single and double) as well as spaces (which deviates from how the shell would interpret it, though).

Please review the following merge request:
https://salsa.debian.org/debian/courier/-/merge_requests/8

Note 2: Another thing is curious: Not all courier services use the init.d
scripts, some have their own systemd config in /lib/systemd/system/
which bypass the init.d script

Yeah, this is unfortunate and should be addressed as well.  Thanks for pointing it out.

Best Regards

Markus

--
Dipl.Ing. Norbert Harrer | Software Engineer | (+43) 0699 10926825 
|nhar...@equilaris.at

Reply via email to