control: tags -1 pending

Uploaded the following thanks!

diff -Nru xpra-3.0.9+dfsg1/debian/changelog xpra-3.0.9+dfsg1/debian/changelog
--- xpra-3.0.9+dfsg1/debian/changelog   2021-02-03 07:22:38.000000000 +0100
+++ xpra-3.0.9+dfsg1/debian/changelog   2021-02-05 20:23:02.000000000 +0100
@@ -1,3 +1,12 @@
+xpra (3.0.9+dfsg1-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  [ Antonio Russo ]
+  * Add xvfb runtime dependency on armhf (Closes: #921700, #956822)
+    - This should fix autopkgtests
+
+ -- Gianfranco Costamagna <[email protected]>  Fri, 05 Feb 2021 
20:23:02 +0100
+
 xpra (3.0.9+dfsg1-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru xpra-3.0.9+dfsg1/debian/control xpra-3.0.9+dfsg1/debian/control
--- xpra-3.0.9+dfsg1/debian/control     2021-02-03 00:47:00.000000000 +0100
+++ xpra-3.0.9+dfsg1/debian/control     2021-02-05 20:23:00.000000000 +0100
@@ -42,6 +42,7 @@
     ,python3-gi-cairo
     ,x11-xserver-utils
     ,xserver-xorg-video-dummy
+    ,xvfb [armhf]
 # Packet Encoding (http://xpra.org/trac/wiki/PacketEncoding):
     ,python3-rencode
 Recommends: ${misc:Recommends}


On Fri, 5 Feb 2021 07:46:16 -0700 Antonio Russo <[email protected]> wrote:
> control: tag -1 patch
> 
> On 2/5/21 3:22 AM, Gianfranco Costamagna wrote:
> > control: reopen -1
> > control: notfixed -1 3.0.9+dfsg1-1.1
> > 
> > Hello, I reuse this bug, to point out that now the package has an 
> > autopkgtest failure on armhf, probably due to an incomplete patch or a 
> > missing xvfb dependency on debian/tests/control
> 
> 
> Thanks---digging into this more, I think I understand what's going on:
> 
> xpra/scripts/config.py:detect_xvfb_command specifically wants Xvfb
> In particular:
> 
>     if platform.uname()[4].startswith("arm"):
>         #arm struggles to launch Xdummy, so use Xvfb:
> 
> (But, why this _is_ working on arm64, I do _not_ understand---presumably,
> some other case-handling causes xpra to change its mind elsewhere.)
> 
> It would, then, seem that all we need is to depend on Xvfb on the failure
> architecture:
> 
> diff --git a/debian/control b/debian/control
> index 6befbb9..77ef63c 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -42,6 +42,7 @@ Depends: ${misc:Depends}, ${python3:Depends}, 
> ${shlibs:Depends}
>      ,python3-gi-cairo
>      ,x11-xserver-utils
>      ,xserver-xorg-video-dummy
> +    ,xvfb [armhf]
>  # Packet Encoding (http://xpra.org/trac/wiki/PacketEncoding):
>      ,python3-rencode
>  Recommends: ${misc:Recommends}

Attachment: xpra_3.0.9+dfsg1-1.2.debian.tar.xz
Description: application/xz

Reply via email to