Source: xandikos
Version: 0.2.6-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
Relevant part (hopefully):
> dpkg-buildpackage
> -----------------
>
> Command: dpkg-buildpackage -us -uc -sa -rfakeroot
> dpkg-buildpackage: info: source package xandikos
> dpkg-buildpackage: info: source version 0.2.6-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jelmer Vernooij <jel...@debian.org>
> dpkg-source --before-build .
> dpkg-buildpackage: info: host architecture amd64
> dpkg-source: info: using options from xandikos-0.2.6/debian/source/options:
> --extend-diff-ignore=^\.travis\.yml$
> --extend-diff-ignore=^xandikos\.egg-info/SOURCES\.txt$
> debian/rules clean
> dh clean --with python3 --buildsystem=pybuild
> dh_auto_clean -O--buildsystem=pybuild
> I: pybuild base:232: python3.9 setup.py clean
> running clean
> removing '/<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build' (and everything under
> it)
> 'build/bdist.linux-x86_64' does not exist -- can't clean it
> 'build/scripts-3.9' does not exist -- can't clean it
> dh_autoreconf_clean -O--buildsystem=pybuild
> dh_clean -O--buildsystem=pybuild
> dpkg-source -b .
> dpkg-source: warning: upstream signing key but no upstream tarball signature
> dpkg-source: info: using options from xandikos-0.2.6/debian/source/options:
> --extend-diff-ignore=^\.travis\.yml$
> --extend-diff-ignore=^xandikos\.egg-info/SOURCES\.txt$
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building xandikos using existing
> ./xandikos_0.2.6.orig.tar.gz
> dpkg-source: info: building xandikos in xandikos_0.2.6-1.debian.tar.xz
> dpkg-source: info: building xandikos in xandikos_0.2.6-1.dsc
> debian/rules binary
> dh binary --with python3 --buildsystem=pybuild
> dh_update_autotools_config -O--buildsystem=pybuild
> dh_autoreconf -O--buildsystem=pybuild
> dh_auto_configure -O--buildsystem=pybuild
> I: pybuild base:232: python3.9 setup.py config
> running config
> dh_auto_build -O--buildsystem=pybuild
> I: pybuild base:232: /usr/bin/python3 setup.py build
> running build
> running build_py
> creating /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/scheduling.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/apache.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/wsgi_helpers.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/quota.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/__init__.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/__main__.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/sync.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/vcard.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/icalendar.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/wsgi.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/webdav.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/carddav.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/server_info.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/timezones.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/metrics.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/collation.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/davcommon.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/caldav.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/web.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/access.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> copying xandikos/infit.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos
> creating /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/test_caldav.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/test_wsgi.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/test_webdav.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/__init__.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/test_api.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/test_icalendar.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/test_config.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/test_store.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> copying xandikos/tests/test_web.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/tests
> creating /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/store
> copying xandikos/store/__init__.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/store
> copying xandikos/store/index.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/store
> copying xandikos/store/config.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/store
> copying xandikos/store/git.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/store
> copying xandikos/store/vdir.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/store
> creating /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/templates
> copying xandikos/templates/collection.html ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/templates
> copying xandikos/templates/principal.html ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/templates
> copying xandikos/templates/root.html ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9/build/xandikos/templates
> running build_scripts
> creating build
> creating build/scripts-3.9
> copying and adjusting bin/xandikos -> build/scripts-3.9
> changing mode of build/scripts-3.9/xandikos from 644 to 755
> dh_auto_test -O--buildsystem=pybuild
> I: pybuild base:232: python3.9 setup.py test
> running test
> WARNING: Testing via this command is deprecated and will be removed in a
> future version. Users looking for a generic test entry point independent of
> test runner are encouraged to use tox.
> running egg_info
> writing xandikos.egg-info/PKG-INFO
> writing dependency_links to xandikos.egg-info/dependency_links.txt
> writing requirements to xandikos.egg-info/requires.txt
> writing top-level names to xandikos.egg-info/top_level.txt
> reading manifest file 'xandikos.egg-info/SOURCES.txt'
> reading manifest template 'MANIFEST.in'
> warning: no files found matching 'xandikos.1'
> adding license file 'COPYING'
> adding license file 'AUTHORS'
> writing manifest file 'xandikos.egg-info/SOURCES.txt'
> running build_ext
> test_backend (xandikos.tests.test_api.WebTests) ... ok
> test_allcomp (xandikos.tests.test_caldav.ExtractfromCalendarTests) ... ok
> test_allprop (xandikos.tests.test_caldav.ExtractfromCalendarTests) ... ok
> test_comp (xandikos.tests.test_caldav.ExtractfromCalendarTests) ... ok
> test_comp_nested (xandikos.tests.test_caldav.ExtractfromCalendarTests) ... ok
> test_expand (xandikos.tests.test_caldav.ExtractfromCalendarTests) ... ok
> test_prop (xandikos.tests.test_caldav.ExtractfromCalendarTests) ... ok
> test_mkcalendar_ok (xandikos.tests.test_caldav.WebTests) ... ok
> test_get_color (xandikos.tests.test_config.FileBasedCollectionMetadataTests)
> ... ok
> test_get_color_missing
> (xandikos.tests.test_config.FileBasedCollectionMetadataTests) ... ok
> test_get_comment
> (xandikos.tests.test_config.FileBasedCollectionMetadataTests) ... ok
> test_get_comment_missing
> (xandikos.tests.test_config.FileBasedCollectionMetadataTests) ... ok
> test_get_description
> (xandikos.tests.test_config.FileBasedCollectionMetadataTests) ... ok
> test_get_description_missing
> (xandikos.tests.test_config.FileBasedCollectionMetadataTests) ... ok
> test_get_displayname
> (xandikos.tests.test_config.FileBasedCollectionMetadataTests) ... ok
> test_get_displayname_missing
> (xandikos.tests.test_config.FileBasedCollectionMetadataTests) ... ok
> test_color (xandikos.tests.test_config.FileMetadataTests) ... ok
> test_comment (xandikos.tests.test_config.FileMetadataTests) ... ok
> test_description (xandikos.tests.test_config.FileMetadataTests) ... ok
> test_displayname (xandikos.tests.test_config.FileMetadataTests) ... ok
> test_order (xandikos.tests.test_config.FileMetadataTests) ... ok
> test_color (xandikos.tests.test_config.RepoMetadataTests) ... ok
> test_comment (xandikos.tests.test_config.RepoMetadataTests) ... ok
> test_description (xandikos.tests.test_config.RepoMetadataTests) ... ok
> test_displayname (xandikos.tests.test_config.RepoMetadataTests) ... ok
> test_order (xandikos.tests.test_config.RepoMetadataTests) ... ok
> test_missing_dtstart
> (xandikos.tests.test_icalendar.ApplyTimeRangeVeventTests) ... ok
> test_comp_apply_time_range
> (xandikos.tests.test_icalendar.CalendarFilterTests) ... ok
> test_param_text_match (xandikos.tests.test_icalendar.CalendarFilterTests) ...
> ok
> test_prop_apply_time_range
> (xandikos.tests.test_icalendar.CalendarFilterTests) ... ok
> test_prop_explicitly_missing_filter
> (xandikos.tests.test_icalendar.CalendarFilterTests) ... ok
> test_prop_presence_filter (xandikos.tests.test_icalendar.CalendarFilterTests)
> ... ok
> test_prop_text_match (xandikos.tests.test_icalendar.CalendarFilterTests) ...
> ok
> test_simple_comp_filter (xandikos.tests.test_icalendar.CalendarFilterTests)
> ... ok
> test_simple_comp_missing_filter
> (xandikos.tests.test_icalendar.CalendarFilterTests) ... ok
> test_extract_no_uid (xandikos.tests.test_icalendar.ExtractCalendarUIDTests)
> ... ok
> test_extract_str (xandikos.tests.test_icalendar.ExtractCalendarUIDTests) ...
> ok
> test_invalid_character
> (xandikos.tests.test_icalendar.ExtractCalendarUIDTests) ... ok
> test_casecmp_collation (xandikos.tests.test_icalendar.TextMatchTest) ... ok
> test_cmp_collation (xandikos.tests.test_icalendar.TextMatchTest) ... ok
> test_default_collation (xandikos.tests.test_icalendar.TextMatchTest) ... ok
> test_unknown_collation (xandikos.tests.test_icalendar.TextMatchTest) ... ok
> test_create (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_create_memory (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_default_no_subdirectories (xandikos.tests.test_store.BareGitStoreTest)
> ... ok
> test_delete_one (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_delete_one_invalid_etag (xandikos.tests.test_store.BareGitStoreTest) ...
> ok
> test_delete_one_nonexistant (xandikos.tests.test_store.BareGitStoreTest) ...
> ok
> test_delete_one_with_etag (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_displayname (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_get_by_index (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_get_color (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_get_ctag (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_get_description_from_git_config
> (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_get_file (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_get_raw (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_get_source_url (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_import_one (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_import_one_duplicate_name (xandikos.tests.test_store.BareGitStoreTest)
> ... ok
> test_import_one_duplicate_uid (xandikos.tests.test_store.BareGitStoreTest)
> ... ok
> test_import_only_once (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_iter_with_etag (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_iter_with_etag_missing_uid (xandikos.tests.test_store.BareGitStoreTest)
> ... ok
> test_with_filter (xandikos.tests.test_store.BareGitStoreTest) ... ok
> test_extract_no_uid (xandikos.tests.test_store.ExtractRegularUIDTests) ... ok
> test_open_from_path_bare (xandikos.tests.test_store.GitStoreTest) ... ok
> test_open_from_path_tree (xandikos.tests.test_store.GitStoreTest) ... ok
> test_create (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_default_no_subdirectories (xandikos.tests.test_store.TreeGitStoreTest)
> ... ok
> test_delete_one (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_delete_one_invalid_etag (xandikos.tests.test_store.TreeGitStoreTest) ...
> ok
> test_delete_one_nonexistant (xandikos.tests.test_store.TreeGitStoreTest) ...
> ok
> test_delete_one_with_etag (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_displayname (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_get_by_index (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_get_color (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_get_description_from_git_config
> (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_get_file (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_get_raw (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_get_source_url (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_import_one (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_import_one_duplicate_name (xandikos.tests.test_store.TreeGitStoreTest)
> ... ok
> test_import_one_duplicate_uid (xandikos.tests.test_store.TreeGitStoreTest)
> ... ok
> test_import_only_once (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_iter_with_etag (xandikos.tests.test_store.TreeGitStoreTest) ... ERROR
> test_iter_with_etag_missing_uid (xandikos.tests.test_store.TreeGitStoreTest)
> ... ERROR
> test_with_filter (xandikos.tests.test_store.TreeGitStoreTest) ... ok
> test_delete_one (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_delete_one_invalid_etag (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_delete_one_nonexistant (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_delete_one_with_etag (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_get_by_index (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_get_file (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_get_raw (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_import_one (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_import_one_duplicate_name (xandikos.tests.test_store.VdirStoreTest) ...
> ok
> test_import_one_duplicate_uid (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_with_filter (xandikos.tests.test_store.VdirStoreTest) ... ok
> test_matches (xandikos.tests.test_webdav.ETagMatchesTests) ... ok
> test_parse (xandikos.tests.test_webdav.ParseAcceptHeaderTests) ... ok
> test_ascii (xandikos.tests.test_webdav.PathFromEnvironTests) ... ok
> test_recode (xandikos.tests.test_webdav.PathFromEnvironTests) ... ok
> test_highest_q (xandikos.tests.test_webdav.PickContentTypesTests) ... ok
> test_no_q (xandikos.tests.test_webdav.PickContentTypesTests) ... ok
> test_not_acceptable (xandikos.tests.test_webdav.PickContentTypesTests) ... ok
> test_wildcard (xandikos.tests.test_webdav.PickContentTypesTests) ... ok
> test_none (xandikos.tests.test_webdav.PropstatAsXmlTests) ... ok
> test_one (xandikos.tests.test_webdav.PropstatAsXmlTests) ... ok
> test_multiple (xandikos.tests.test_webdav.PropstatByStatusTests) ... ok
> test_none (xandikos.tests.test_webdav.PropstatByStatusTests) ... ok
> test_one (xandikos.tests.test_webdav.PropstatByStatusTests) ... ok
> test_delete (xandikos.tests.test_webdav.WebTests) ... ok
> test_delete_not_found (xandikos.tests.test_webdav.WebTests) ... ok
> test_get_body (xandikos.tests.test_webdav.WebTests) ... ok
> test_lock_not_allowed (xandikos.tests.test_webdav.WebTests) ... ok
> test_mkcol_exists (xandikos.tests.test_webdav.WebTests) ... ok
> test_mkcol_ok (xandikos.tests.test_webdav.WebTests) ... ok
> test_not_found (xandikos.tests.test_webdav.WebTests) ... ok
> test_propfind_found (xandikos.tests.test_webdav.WebTests) ... ok
> test_propfind_found_multi (xandikos.tests.test_webdav.WebTests) ... ok
> test_propfind_found_multi_status (xandikos.tests.test_webdav.WebTests) ... ok
> test_propfind_prop_does_not_exist (xandikos.tests.test_webdav.WebTests) ... ok
> test_propfind_prop_not_present (xandikos.tests.test_webdav.WebTests) ... ok
> test_set_body (xandikos.tests.test_webdav.WebTests) ... ok
> test_calendar_query_vtodo_by_uid
> (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_calendar_query_vtodos (xandikos.tests.test_web.CalendarCollectionTests)
> ... ok
> test_color (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_delete_member (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_description (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_get_max_date_time (xandikos.tests.test_web.CalendarCollectionTests) ...
> ok
> test_get_member (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_get_min_date_time (xandikos.tests.test_web.CalendarCollectionTests) ...
> ok
> test_get_schedule_calendar_transparency
> (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_get_supported_calendar_components
> (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_get_supported_calendar_data_types
> (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_members (xandikos.tests.test_web.CalendarCollectionTests) ... ok
> test_wellknownredirector (xandikos.tests.test_wsgi.WebTests) ... ok
>
> ======================================================================
> ERROR: test_iter_with_etag (xandikos.tests.test_store.TreeGitStoreTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/<<PKGBUILDDIR>>/xandikos/tests/test_store.py", line 354, in
> test_iter_with_etag
> bid = self.add_blob(gc, "foo.ics", EXAMPLE_VCALENDAR1)
> File "/<<PKGBUILDDIR>>/xandikos/tests/test_store.py", line 473, in add_blob
> gc.repo.stage(name.encode("utf-8"))
> File "/usr/lib/python3/dist-packages/dulwich/repo.py", line 1279, in stage
> fs_path = os.fsencode(fs_path)
> File "/usr/lib/python3.9/os.py", line 810, in fsencode
> filename = fspath(filename) # Does type-checking of `filename`.
> TypeError: expected str, bytes or os.PathLike object, not int
>
> ======================================================================
> ERROR: test_iter_with_etag_missing_uid
> (xandikos.tests.test_store.TreeGitStoreTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/<<PKGBUILDDIR>>/xandikos/tests/test_store.py", line 347, in
> test_iter_with_etag_missing_uid
> bid = self.add_blob(gc, "foo.ics", EXAMPLE_VCALENDAR_NO_UID)
> File "/<<PKGBUILDDIR>>/xandikos/tests/test_store.py", line 473, in add_blob
> gc.repo.stage(name.encode("utf-8"))
> File "/usr/lib/python3/dist-packages/dulwich/repo.py", line 1279, in stage
> fs_path = os.fsencode(fs_path)
> File "/usr/lib/python3.9/os.py", line 810, in fsencode
> filename = fspath(filename) # Does type-checking of `filename`.
> TypeError: expected str, bytes or os.PathLike object, not int
>
> ----------------------------------------------------------------------
> Ran 137 tests in 0.637s
>
> FAILED (errors=2)
> Test failed: <unittest.runner.TextTestResult run=137 errors=2 failures=0>
> error: Test failed: <unittest.runner.TextTestResult run=137 errors=2
> failures=0>
> E: pybuild pybuild:354: test: plugin distutils failed with: exit code=1:
> python3.9 setup.py test
> dh_auto_test: error: pybuild --test -i python{version} -p 3.9 returned exit
> code 13
The full build log is available from:
http://qa-logs.debian.net/2021/10/23/xandikos_0.2.6-1_unstable.log
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
