Your message dated Sat, 20 Nov 2021 09:18:57 +0000
with message-id <e1momwp-00075t...@fasolo.debian.org>
and subject line Bug#998395: fixed in google-auth-httplib2 0.1.0-2
has caused the Debian Bug report #998395,
regarding FTBFS: very wrong python dependency
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
998395: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=998395
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: assimp
Version: 5.0.1~ds0-3
Tags: patch
Control: clone -1 -2
Control: retitle -2 rules-require-build-prerequisite gives bogus advice
Control: reassign -2 lintian
Control: severity -2 important
Control: tags -2 - patch
Control: affects -2 src:assimp
User: debian-cr...@lists.debian.org
Usertags: ftcbfs
X-Debbugs-Cc: debhel...@packages.debian.org
X-Debbugs-Cc: debian-cr...@lists.debian.org
assimp fails to cross build from source. It attempts to build a python
module, but it ultimately fails doing so. While inspecting this, I
discovered that assimp "Build-Depends: python3:any | python3-all:any |
python3-dev:any | python3-all-dev:any | dh-sequence-python3". This is
wrong on so many levels.
For starters, sbuild ignores any alternative in unstable, so in
practice, this happens to become "python3:any". Any other alternative is
simply ignored and shouldn't be there.
Then, issuing a dependency on python3-dev:any without libpython3-dev is
practically never correct. That could be a separate lintian tag, but
that's not too bad here as python3-dev isn't needed. Either you go
python3-dev or you go python3-dev:any, libpython3-dev or you have a very
special and unusual use case that I have never encountered anywhere.
Also listing dh-sequence-python3 there is bogus. You already added
"--with python3" in debian/rules. This is duplicate at best. Either
should be dropped, but enabling a dh-addon in an alternative is clearly
not right, and debhelper should likely fail hard when encountering that.
Niels, do you agree?
I wondered how one would come up with such a strange dependency and
asked #debian-mentors for help. Kindly, a user named "itd" pointed me at
the lintian tag rules-require-build-prerequisite, which very likely is
the cause for this. Please disable the tag right now as it does more
harm than good. While the tag isn't bad per-se, the advice it gives
misleads users and produces broken packages. I request hiding or
disabling it now and then figuring out what it really should say.
Back to assimp. I looked into this to make it cross buildable, right?
And it was failing in Python-ish stuff. So why do we actually build the
Python module? Did I say module? It's not an extension? No, it isn't.
And we really don't have to build it in an arch-only build. So the key
to making assimp cross buildable is to make an arch-only build fully
skip the Python stuff. And once you do that, you don't care about :any
annotations anymore as those are practically irrelevant in
Build-Depends-Indep.
So I've attached a patch for assimp to fix the cross build and the
strange build dependency. Please consider applying it.
Helmut
diff --minimal -Nru assimp-5.0.1~ds0/debian/changelog
assimp-5.0.1~ds0/debian/changelog
--- assimp-5.0.1~ds0/debian/changelog 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/changelog 2021-10-08 20:49:28.000000000 +0200
@@ -1,3 +1,15 @@
+assimp (5.0.1~ds0-3.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix python build dependency. (Closes: #-1)
+ + Alternatives in Build-Depends are ignored.
+ + Enable the python3 dh addon once only.
+ + Build python module in indep build only.
+ + Move python Build-Depends to B-D-I.
+ + Drop the :any nonsense.
+
+ -- Helmut Grohne <hel...@subdivi.de> Fri, 08 Oct 2021 20:49:28 +0200
+
assimp (5.0.1~ds0-3) unstable; urgency=medium
[ Debian Janitor ]
diff --minimal -Nru assimp-5.0.1~ds0/debian/control
assimp-5.0.1~ds0/debian/control
--- assimp-5.0.1~ds0/debian/control 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/control 2021-10-08 20:49:28.000000000 +0200
@@ -15,8 +15,10 @@
libstb-dev,
libutfcpp-dev,
zlib1g-dev | libz-dev,
- python3:any | python3-all:any | python3-dev:any | python3-all-dev:any |
dh-sequence-python3,
doxygen,
+Build-Depends-Indep:
+ dh-sequence-python3,
+ python3,
Rules-Requires-Root: no
Vcs-Git: https://salsa.debian.org/debian/assimp.git
Vcs-Browser: https://salsa.debian.org/debian/assimp
diff --minimal -Nru assimp-5.0.1~ds0/debian/rules assimp-5.0.1~ds0/debian/rules
--- assimp-5.0.1~ds0/debian/rules 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/rules 2021-10-08 20:49:28.000000000 +0200
@@ -33,7 +33,7 @@
export PYBUILD_NAME=pyassimp
%:
- dh $@ --with python3 --buildsystem=cmake
+ dh $@ --buildsystem=cmake
override_dh_auto_configure:
dh_auto_configure -- \
@@ -50,8 +50,10 @@
override_dh_auto_build:
dh_auto_build
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
dh_auto_build --buildsystem=pybuild -- \
-d port/PyAssimp/
+endif
cd obj-$(DEB_HOST_GNU_TYPE)/doc && doxygen Doxyfile
cd doc && doxygen Doxyfile_Cmd
@@ -61,8 +63,10 @@
override_dh_auto_install:
dh_auto_install
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
dh_auto_install --buildsystem=pybuild -- \
-d port/PyAssimp/
+endif
# IrrXML is not packaged for Debian, so drop the wrapper
find debian/*/usr -name irrXMLWrapper.h -delete
--- End Message ---
--- Begin Message ---
Source: google-auth-httplib2
Source-Version: 0.1.0-2
Done: Valentin Vidic <vvi...@debian.org>
We believe that the bug you reported is fixed in the latest version of
google-auth-httplib2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 998...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Valentin Vidic <vvi...@debian.org> (supplier of updated google-auth-httplib2
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 20 Nov 2021 09:48:59 +0100
Source: google-auth-httplib2
Architecture: source
Version: 0.1.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team <team+pyt...@tracker.debian.org>
Changed-By: Valentin Vidic <vvi...@debian.org>
Closes: 998395
Changes:
google-auth-httplib2 (0.1.0-2) unstable; urgency=medium
.
* d/control: update python build dependencies (Closes: #998395)
* d/copyright: update year for debian/*
Checksums-Sha1:
5f4f63b85e85585ab9b8e65484334523428f4e43 2335 google-auth-httplib2_0.1.0-2.dsc
e9c496fc4ff0de5a7c0f79f3eaed9450a826b3cc 2416
google-auth-httplib2_0.1.0-2.debian.tar.xz
c867860b35e44e46485017a7afdada046bcdecb1 6951
google-auth-httplib2_0.1.0-2_source.buildinfo
Checksums-Sha256:
1ed7fe22b1ad5fc4aadf911cec393f30c2cfae6567bd5d172a81bbc85acdd74e 2335
google-auth-httplib2_0.1.0-2.dsc
c188630b203acdef6d8938414191d43db2ac0261f490aa695e45ca0fb4ebfd3b 2416
google-auth-httplib2_0.1.0-2.debian.tar.xz
6f61faf236d88af890ee50936d5c536006c8acd0978e61037af3aecb1cc68852 6951
google-auth-httplib2_0.1.0-2_source.buildinfo
Files:
bcdc263e99313c60f102aef3e973a47d 2335 python optional
google-auth-httplib2_0.1.0-2.dsc
ef04331dabe9b6e660ddef19e1bda948 2416 python optional
google-auth-httplib2_0.1.0-2.debian.tar.xz
d91352afc883746243a281bc52383622 6951 python optional
google-auth-httplib2_0.1.0-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEExaW53cM9k/u2PWfIMofYmpfNqHsFAmGYuWASHHZ2aWRpY0Bk
ZWJpYW4ub3JnAAoJEDKH2JqXzah7s2IQAJit5oI6RX0Z2WbuFLgF8EETqfne/ixi
pnJ14OCTck7WWj6WjU1wXJzMtPRt8KPylZ4jsXLODGI2MGnxqW3PoG9LkTRVhgXZ
Wc2vUetqrA65AoojtX5L9uWPZ7yQQQwRB/eN811IhgTnP57ZAChyqTk/N7nVB1S6
3xsMeyB+6gsb0wvCOvqTxtUjSd2UBuyK58xhR0hy4NeLlM6p2PtXqcVir+CuwDO7
rHLoKuW5DNrnAXzF+kOluZjSMSHf2jdc/EHvPN+uGH9/ijiuuCdPYnM6yXudjfBq
pPFCKRkGAgRZG0hkvA3dIngiE3PT907jyAzvcwL09PDB9+bNCJEsLN6mnPmENZxX
5opOc2dYYdpXswdt4o4styIbguif+wuOT2kTeDDXYitAA7H2xPe1ypyLq+f4lT/h
RB3/5MVLcunhLfObYNSWGmvCwYzZBkASyXOzjdJyasgHco1CE2IyyTn6b2x2QG8L
sPb+tBUrkM0J5+ZomQrAZ0gXYFSM8BbblBOcgki+rZb1h6T1zfvSGvlChsaZcGz1
N5Xo8vEeAWAr7vrzu/UQj4JqoP4141ZsClCFAzENiFgjaVR2G0SVM6NtXxoDAowx
Qf5ObENJKixiz1MActwpvC1uJi4RmtdeVVq5Cgve0rdJ16sbA42ISJKk5KLvzYBM
9cDaY4K5Jqxx
=AGdi
-----END PGP SIGNATURE-----
--- End Message ---
