Your message dated Sun, 21 Nov 2021 19:22:16 +0000
with message-id <[email protected]>
and subject line Bug#998398: fixed in python-imgviz 1.4.1+ds-1
has caused the Debian Bug report #998398,
regarding FTBFS: very wrong python dependency
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
998398: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=998398
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: assimp
Version: 5.0.1~ds0-3
Tags: patch
Control: clone -1 -2
Control: retitle -2 rules-require-build-prerequisite gives bogus advice
Control: reassign -2 lintian
Control: severity -2 important
Control: tags -2 - patch
Control: affects -2 src:assimp
User: [email protected]
Usertags: ftcbfs
X-Debbugs-Cc: [email protected]
X-Debbugs-Cc: [email protected]
assimp fails to cross build from source. It attempts to build a python
module, but it ultimately fails doing so. While inspecting this, I
discovered that assimp "Build-Depends: python3:any | python3-all:any |
python3-dev:any | python3-all-dev:any | dh-sequence-python3". This is
wrong on so many levels.
For starters, sbuild ignores any alternative in unstable, so in
practice, this happens to become "python3:any". Any other alternative is
simply ignored and shouldn't be there.
Then, issuing a dependency on python3-dev:any without libpython3-dev is
practically never correct. That could be a separate lintian tag, but
that's not too bad here as python3-dev isn't needed. Either you go
python3-dev or you go python3-dev:any, libpython3-dev or you have a very
special and unusual use case that I have never encountered anywhere.
Also listing dh-sequence-python3 there is bogus. You already added
"--with python3" in debian/rules. This is duplicate at best. Either
should be dropped, but enabling a dh-addon in an alternative is clearly
not right, and debhelper should likely fail hard when encountering that.
Niels, do you agree?
I wondered how one would come up with such a strange dependency and
asked #debian-mentors for help. Kindly, a user named "itd" pointed me at
the lintian tag rules-require-build-prerequisite, which very likely is
the cause for this. Please disable the tag right now as it does more
harm than good. While the tag isn't bad per-se, the advice it gives
misleads users and produces broken packages. I request hiding or
disabling it now and then figuring out what it really should say.
Back to assimp. I looked into this to make it cross buildable, right?
And it was failing in Python-ish stuff. So why do we actually build the
Python module? Did I say module? It's not an extension? No, it isn't.
And we really don't have to build it in an arch-only build. So the key
to making assimp cross buildable is to make an arch-only build fully
skip the Python stuff. And once you do that, you don't care about :any
annotations anymore as those are practically irrelevant in
Build-Depends-Indep.
So I've attached a patch for assimp to fix the cross build and the
strange build dependency. Please consider applying it.
Helmut
diff --minimal -Nru assimp-5.0.1~ds0/debian/changelog
assimp-5.0.1~ds0/debian/changelog
--- assimp-5.0.1~ds0/debian/changelog 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/changelog 2021-10-08 20:49:28.000000000 +0200
@@ -1,3 +1,15 @@
+assimp (5.0.1~ds0-3.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix python build dependency. (Closes: #-1)
+ + Alternatives in Build-Depends are ignored.
+ + Enable the python3 dh addon once only.
+ + Build python module in indep build only.
+ + Move python Build-Depends to B-D-I.
+ + Drop the :any nonsense.
+
+ -- Helmut Grohne <[email protected]> Fri, 08 Oct 2021 20:49:28 +0200
+
assimp (5.0.1~ds0-3) unstable; urgency=medium
[ Debian Janitor ]
diff --minimal -Nru assimp-5.0.1~ds0/debian/control
assimp-5.0.1~ds0/debian/control
--- assimp-5.0.1~ds0/debian/control 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/control 2021-10-08 20:49:28.000000000 +0200
@@ -15,8 +15,10 @@
libstb-dev,
libutfcpp-dev,
zlib1g-dev | libz-dev,
- python3:any | python3-all:any | python3-dev:any | python3-all-dev:any |
dh-sequence-python3,
doxygen,
+Build-Depends-Indep:
+ dh-sequence-python3,
+ python3,
Rules-Requires-Root: no
Vcs-Git: https://salsa.debian.org/debian/assimp.git
Vcs-Browser: https://salsa.debian.org/debian/assimp
diff --minimal -Nru assimp-5.0.1~ds0/debian/rules assimp-5.0.1~ds0/debian/rules
--- assimp-5.0.1~ds0/debian/rules 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/rules 2021-10-08 20:49:28.000000000 +0200
@@ -33,7 +33,7 @@
export PYBUILD_NAME=pyassimp
%:
- dh $@ --with python3 --buildsystem=cmake
+ dh $@ --buildsystem=cmake
override_dh_auto_configure:
dh_auto_configure -- \
@@ -50,8 +50,10 @@
override_dh_auto_build:
dh_auto_build
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
dh_auto_build --buildsystem=pybuild -- \
-d port/PyAssimp/
+endif
cd obj-$(DEB_HOST_GNU_TYPE)/doc && doxygen Doxyfile
cd doc && doxygen Doxyfile_Cmd
@@ -61,8 +63,10 @@
override_dh_auto_install:
dh_auto_install
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
dh_auto_install --buildsystem=pybuild -- \
-d port/PyAssimp/
+endif
# IrrXML is not packaged for Debian, so drop the wrapper
find debian/*/usr -name irrXMLWrapper.h -delete
--- End Message ---
--- Begin Message ---
Source: python-imgviz
Source-Version: 1.4.1+ds-1
Done: Gürkan Myczko <[email protected]>
We believe that the bug you reported is fixed in the latest version of
python-imgviz, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gürkan Myczko <[email protected]> (supplier of updated python-imgviz package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 25 Oct 2021 08:19:40 +0200
Source: python-imgviz
Architecture: source
Version: 1.4.1+ds-1
Distribution: unstable
Urgency: medium
Maintainer: Gürkan Myczko <[email protected]>
Changed-By: Gürkan Myczko <[email protected]>
Closes: 998398
Changes:
python-imgviz (1.4.1+ds-1) unstable; urgency=medium
.
* New upstream version.
* d/control:
- update Vcs fields.
- update maintainer address.
* Bump standards version to 4.6.0.
* Fix python build dependency. (Closes: #998398)
+ Alternatives in Build-Depends are ignored.
+ Build python module in indep build only.
+ Move python Build-Depends to B-D-I.
+ Drop the :any nonsense.
Thanks Helmut Grohne for the patch.
Checksums-Sha1:
dfc2cf712c93ec5e64dcc9ddc35392380e84f811 2025 python-imgviz_1.4.1+ds-1.dsc
d1f16b93115d575a13b87889f35014af919cdd1b 7495216
python-imgviz_1.4.1+ds.orig.tar.xz
7ac629433ce89097117859d048d4ba374ed618f0 3440
python-imgviz_1.4.1+ds-1.debian.tar.xz
dfc3de2dbec30c1839352ca40854bf5e7d9b91d7 8886
python-imgviz_1.4.1+ds-1_source.buildinfo
Checksums-Sha256:
36b3ffc9782742889091b16c1164b4698c85b4dce9220d295fad36653b83c9bb 2025
python-imgviz_1.4.1+ds-1.dsc
fb1568e2dad55528c8fefae43ca89f3719a569dca8b3cbac919a15de9bfcb69d 7495216
python-imgviz_1.4.1+ds.orig.tar.xz
6186faf4df19bfabafd5ce27591223b8a7ce9e6321e3861ceefd91c5d5e7a26d 3440
python-imgviz_1.4.1+ds-1.debian.tar.xz
fcdd069886740023d8fd292c3fc4fa74c7ef14acf6d5d0c2625e0fd67c3113e9 8886
python-imgviz_1.4.1+ds-1_source.buildinfo
Files:
0c902de9b0c7b00842e445bb773f4f4b 2025 python optional
python-imgviz_1.4.1+ds-1.dsc
c40668322ccce007811ab42bcd854f24 7495216 python optional
python-imgviz_1.4.1+ds.orig.tar.xz
c5221ca0db5033e01f286d06b6bb670a 3440 python optional
python-imgviz_1.4.1+ds-1.debian.tar.xz
ec8c8e95a4b9cd34c1467ed14afcf76b 8886 python optional
python-imgviz_1.4.1+ds-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEtgob82PcExn/Co6JEWhSvN91FcAFAmGaloUACgkQEWhSvN91
FcDnGw//e6gO7HZNea6rv5epQIpd4FSehCb9Sbp4OBzyKF6/K6XArg7Otfjz5blf
/DkEUBynNmFVL9+xmI6DaxQPAwpff8WQILwhOTypCAss+tT/U8j9UAloHFoHfWia
otoGS5F4Oy8/sLt7BKpe2nWSanl1Xz1TagVdfJV99SfRShDaPHknx+eNrOP1YR5u
5OHeJN93fqRifAKYl3kAignP6ALDO0DPI1R24GPPhvdb7GyX1AGJWdm3NaDtWjq7
rU2kLaiD33GoGql2z9FwBbOh9MC3UuUVMp0QiwRxzVAfoLyQTqt1nxpLoPfO9goH
YShV2o/vTZgran6IpdSN2TCrozzP6zX5MP7qcCdYGvZNxi8YsPmFItEv3wfP2bRx
SyHgDi+yCK44kcKMuONYCcmjt3QpKApLlkfZ+3yZ2Wzb1pDdAFRq3geZREYZLXGG
B9hYFg8AtVO8O3YyhFBB0gyl0xlVA9Af45dee1ZlaT2OWApJfbxYlKqhzDuCyCRO
zHgOg0BDoZyCsNq2kKUevyvvJvXZaOgGQpeOLLCw/6FE6tTK6Gg5IouL2xBZM50U
OUciSu1uF8AcVg9uCQLx/X742QS7f/SkBqEuERo3z449w/WXXpYvyslQ3Bd12Xzu
l7a3kMk3yljVcW1g8aqoPOlIwDIlnjyRKV6bN9bXeeoRVYRu3Go=
=wqtx
-----END PGP SIGNATURE-----
--- End Message ---
