Bringing the discussion to the right track... On Fri, Dec 10, 2021 at 4:13 PM Nilesh Patra <nil...@riseup.net> wrote: > > On 12/11/21 2:30 AM, Tong Sun wrote: > > Oh, thanks a lot Nilesh! > > > > Everything is updated on salsa. pls double check, e.g.: > > > > https://salsa.debian.org/debian/dbab/-/commit/4cd8db27cec918244a9fba3d698a7b0123c9f3f9 > > Just one query: you reason for moving to contrib is not entirely clear to me. > You wrote here[2] that it installs external data after install, but I do not see > anything peculiar in the postinst script that does something of that sort although I do not > know much about this package. > > So could you elaborate on this thing? Just for my understanding.
dbab moving to contrib is because of this Bug#1001009. I personally have no idea, but as requested by Andrey. I guess it is about this line that is called from the postinst script https://salsa.debian.org/debian/dbab/-/blob/master/bin/dbab-get-list#L21 Here is the recap of what he had said in this thread before: If the package cannot function without this or similar unpackaged file, it > should be moved to contrib. If it can, the downloading should be done by > the > user/administrator. I've asked some follow-up questions and his answer is enclosed *below*. > Also, I would suggest to add the reasoning in d/README.Debian instead of the copyright > for making it easier to review for ftp masters. > > Additionally, have you checked with piuparts that the upgrade from buster indeed goes smooth? Hmm, no. This is the first time I heard of piuparts I did some search, but I got two 404 for the two most important thing that I need to read: 1. piuparts itself has a README <https://piuparts.debian.org/doc/README.html> *from* https://wiki.debian.org/piuparts?action=fullsearch&context=180&value=dbab&titlesearch=Titles 2. A package I'm interested in is in an untestable state. How can I find out if it would pass the piuparts test? A) Run piuparts manually <https://piuparts.debian.org/doc/README.html#_how_to_use_piuparts_in_5_minutes>, as described in that README. *from* https://wiki.debian.org/piuparts/FAQ Is it a done-online thing or I need to download something and try to learn how to use it? > > Do you need me to upload to mentor first, you can totally take care of > > it from salsa? > > I will manage from salsa. Thanks, I'll add the reasoning into d/README.Debian once things are settled. Thanks again. > > [1]: https://salsa.debian.org/debian/dbab/-/commit/4cd8db27cec918244a9fba3d698a7b0123c9f3f9 > [2]: https://salsa.debian.org/debian/dbab/-/commit/72ff079bc607b564966b24dc2ae598be4e8f5750 On Tue, Dec 7, 2021 at 10:57 AM Andrey Rahmatullin <w...@debian.org> wrote: > > On Sun, Dec 05, 2021 at 09:56:02AM -0500, Tong Sun wrote: > > Thanks Andrey, > > > > Two questions, > > > > By "moved to contrib", did you meant to change > > > > Section: net > > > > to > > > > Section: contrib > > > > in d/control? > Please read > https://www.debian.org/doc/debian-policy/ch-archive.html#archive-areas and > https://www.debian.org/doc/debian-policy/ch-archive.html#s-subsections > > > Now, let's define what "package cannot function" actually means. If > > functions normally without this or similar unpackaged file, but the > > program is completely data driven, i.e., no ads sites from the list > > are blocked unless the list is there. > > > > So, strictly speaking, the package indeed cannot function without this > > or similar unpackaged file, right? And the solution is just above, > > right? > I don't know the current project consensus on this, if it exists. > If the software can only work with certain non-free files it should go > into contrib, if OTOH it can work with some user-provided files, or with > free files if those exist, it can stay in main. But downloading external > files in postinst is certainly not fit for main. > > -- > WBR, wRAR
