I noticed in the debian/rules that rebuilding the timezone JS data from the tzdata package is *optional*, and only occurs if the moment-timezone package has a +NNNNx suffix, e.g. +2021e. If not, the timezone JS data from the upstream moment-timezone source will be used.
I just tried building v0.5.34 *without* the tzdata suffix, and all tests passed. I suspect that in order to build against tzdata 2021e, despite it allegedly already being included in the upstream v0.5.34 source, it would require some manipulation of the tests. I suppose the question is how far down the rabbit hole we want to go. I'm sure that this issue will arise again as soon as tzdata 2022a is released, and we will need another patch in moment-timezone, such as was contributed by Martina Ferrari in the past. Perhaps we could instead just move forward with moment-timezone v0.5.34, sans tzdata 2021e, in the interests of closing this bug and unblocking a bunch of testing package transitions.
