Source: prayer
Version: 1.3.5-dfsg1-8
Severity: grave
X-Debbugs-CC: holmg...@debian.org
User: tidy-ht...@packages.debian.org
Usertags: tidy5.8

Dear Debian prayer package maintainer,

When preparing the upload of package tidy-html5 v5.8 onto Debian Unstable, I
noticed that your package FTBFS with the new tidy library:

================================================================
/usr/bin/ld: ../session/session.a(html_secure_tidy.o): in function
`tidy_tree':
./session/html_secure_tidy.c:311: undefined reference to
`prvTidyDiscardElement'
/usr/bin/ld: ./session/html_secure_tidy.c:322: undefined reference to
`prvTidyRemoveAttribute'
/usr/bin/ld: ./session/html_secure_tidy.c:329: undefined reference to
`prvTidyAddAttribute'
collect2: error: ld returned 1 exit status
================================================================

This is because that your package uses some of Tidy's unexported internal
functions that are explicitly hidden in Tidy 5.8:

================================================================
/* Foul layering volation: Tidy doesn't export these functions */

extern void prvTidyDiscardElement( TidyDoc doc, TidyNode node);
extern void prvTidyRemoveAttribute( TidyDoc doc, TidyNode node, TidyAttr
attr);
extern void prvTidyAddAttribute( TidyDoc doc, TidyNode node,
                                 const char *attr, const char *value);
================================================================


I believe this change is intentional by upstream, and will not be changed in
the forseeable future. Please consider fixing the build by removing the use of
internal Tidy functions. Thanks!

Best,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to