Your message dated Thu, 05 May 2022 05:49:17 +0000 with message-id <e1nmumx-000di2...@fasolo.debian.org> and subject line Bug#1010554: fixed in orthanc 1.10.1+dfsg-2 has caused the Debian Bug report #1010554, regarding orthanc: FTBFS with dcmtk >= 3.6.7 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1010554: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010554 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: orthanc Version: 1.10.1+dfsg-1 Severity: serious Tags: ftbfs Justification: fails to build from source (but built successfully in the past) X-Debbugs-Cc: jo...@debian.org, ma...@debian.org Hi, orthanc FTBFS with dcmtk 3.6.7 from unstable: /<<PKGBUILDDIR>>/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:110:118: error: ‘TCS_ok’ was not declared in this scope 110 | if (tls->addTrustedCertificateFile(trustedCertificatesPath.c_str(), DCF_Filetype_PEM /*opt_keyFi leFormat*/) != TCS_ok) | ^~~~~~ /<<PKGBUILDDIR>>/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:116:104: error: ‘TCS_ok’ was not declared in this scope 116 | if (tls->setPrivateKeyFile(ownPrivateKeyPath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/) != TCS_ok) | ^~~~~~ /<<PKGBUILDDIR>>/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:122:106: error: ‘TCS_ok’ was not declared in this scope 122 | if (tls->setCertificateFile(ownCertificatePath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/) != TCS_ok) | ^~~~~~ /<<PKGBUILDDIR>>/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:135:72: error: ‘TCS_ok’ was n ot declared in this scope 135 | if (tls->setTLSProfile(TSP_Profile_BCP195 /*opt_tlsProfile*/) != TCS_ok) | ^~~~~~ /<<PKGBUILDDIR>>/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:140:36: error: could not convert ‘DcmTLSTransportLayer::activateCipherSuites()()’ from ‘OFCondition’ to ‘bool’ 140 | if (tls->activateCipherSuites()) | ~~~~~~~~~~~~~~~~~~~~~~~~~^~ | | | OFCondition make[4]: *** [CMakeFiles/OrthancFramework.dir/build.make:1941: CMakeFiles/OrthancFramework.dir/<<PKGBUILDDIR>>/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp.o] Error 1 The attached debdiff fixes above problem but the testsuite still fails with: [100%] Linking CXX executable UnitTests /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/11/../../../x86_64-linux-gnu/libdcmdata.so: undefined reference to symbol 'inflateEnd' /usr/bin/ld: /lib/x86_64-linux-gnu/libz.so.1: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status Maybe this has to be fixed in dcmtk but I'm not sure. Because my patch is not complete I'm not tagging this bug with patch. Thanks! cheers, joschdiff -Nru orthanc-1.10.1+dfsg/debian/changelog orthanc-1.10.1+dfsg/debian/changelog --- orthanc-1.10.1+dfsg/debian/changelog 2022-03-23 21:05:58.000000000 +0100 +++ orthanc-1.10.1+dfsg/debian/changelog 2022-05-04 10:13:08.000000000 +0200 @@ -1,3 +1,10 @@ +orthanc (1.10.1+dfsg-1.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * add patch to build with dcmtk >= 3.6.7 (closes: #XXXXXXX) + + -- Johannes Schauer Marin Rodrigues <jo...@debian.org> Wed, 04 May 2022 10:13:08 +0200 + orthanc (1.10.1+dfsg-1) unstable; urgency=medium * New upstream version diff -Nru orthanc-1.10.1+dfsg/debian/patches/dcmtk-3.6.7 orthanc-1.10.1+dfsg/debian/patches/dcmtk-3.6.7 --- orthanc-1.10.1+dfsg/debian/patches/dcmtk-3.6.7 1970-01-01 01:00:00.000000000 +0100 +++ orthanc-1.10.1+dfsg/debian/patches/dcmtk-3.6.7 2022-05-04 10:13:08.000000000 +0200 @@ -0,0 +1,40 @@ +--- a/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp ++++ b/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp +@@ -107,19 +107,19 @@ namespace Orthanc + new DcmTLSTransportLayer(tmpRole /*opt_networkRole*/, NULL /*opt_readSeedFile*/, + OFFalse /*initializeOpenSSL, done by Orthanc::Toolbox::InitializeOpenSsl()*/)); + +- if (tls->addTrustedCertificateFile(trustedCertificatesPath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/) != TCS_ok) ++ if (tls->addTrustedCertificateFile(trustedCertificatesPath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/).bad()) + { + throw OrthancException(ErrorCode_BadFileFormat, "Cannot parse PEM file with trusted certificates for DICOM TLS: " + + trustedCertificatesPath); + } + +- if (tls->setPrivateKeyFile(ownPrivateKeyPath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/) != TCS_ok) ++ if (tls->setPrivateKeyFile(ownPrivateKeyPath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/).bad()) + { + throw OrthancException(ErrorCode_BadFileFormat, "Cannot parse PEM file with private key for DICOM TLS: " + + ownPrivateKeyPath); + } + +- if (tls->setCertificateFile(ownCertificatePath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/) != TCS_ok) ++ if (tls->setCertificateFile(ownCertificatePath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/).bad()) + { + throw OrthancException(ErrorCode_BadFileFormat, "Cannot parse PEM file with own certificate for DICOM TLS: " + + ownCertificatePath); +@@ -132,12 +132,12 @@ namespace Orthanc + } + + #if DCMTK_VERSION_NUMBER >= 364 +- if (tls->setTLSProfile(TSP_Profile_BCP195 /*opt_tlsProfile*/) != TCS_ok) ++ if (tls->setTLSProfile(TSP_Profile_BCP195 /*opt_tlsProfile*/).bad()) + { + throw OrthancException(ErrorCode_InternalError, "Cannot set the DICOM TLS profile"); + } + +- if (tls->activateCipherSuites()) ++ if (tls->activateCipherSuites().good()) + { + throw OrthancException(ErrorCode_InternalError, "Cannot activate the cipher suites for DICOM TLS"); + } diff -Nru orthanc-1.10.1+dfsg/debian/patches/series orthanc-1.10.1+dfsg/debian/patches/series --- orthanc-1.10.1+dfsg/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ orthanc-1.10.1+dfsg/debian/patches/series 2022-05-04 10:11:02.000000000 +0200 @@ -0,0 +1 @@ +dcmtk-3.6.7
--- End Message ---
--- Begin Message ---Source: orthanc Source-Version: 1.10.1+dfsg-2 Done: Sebastien Jodogne <s.jodo...@gmail.com> We believe that the bug you reported is fixed in the latest version of orthanc, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1010...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sebastien Jodogne <s.jodo...@gmail.com> (supplier of updated orthanc package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 05 May 2022 07:35:04 +0200 Source: orthanc Architecture: source Version: 1.10.1+dfsg-2 Distribution: unstable Urgency: medium Maintainer: Debian Med Packaging Team <debian-med-packag...@lists.alioth.debian.org> Changed-By: Sebastien Jodogne <s.jodo...@gmail.com> Closes: 1010554 Changes: orthanc (1.10.1+dfsg-2) unstable; urgency=medium . * Fix build against DCMTK 3.6.7. Closes: #1010554 Checksums-Sha1: cc8c8dcc0cd0b8b3987eba1e1b3b2ffe4ffaae2b 2591 orthanc_1.10.1+dfsg-2.dsc a352d08c3792376432d01b0dbeb1dff01662cd46 230508 orthanc_1.10.1+dfsg-2.debian.tar.xz bc588c0735eef0c491189409e2972c65532539ee 15274 orthanc_1.10.1+dfsg-2_source.buildinfo Checksums-Sha256: 4c0f4ec96880e442964febf2d521376549d6e12a13198b5c6d5fe7f86f93ec7d 2591 orthanc_1.10.1+dfsg-2.dsc 6380fde2d7ea07f21b41c4036027787fc7240e34c0a8a67f305b46ffcc6494f7 230508 orthanc_1.10.1+dfsg-2.debian.tar.xz e479db73417a350407dd2c8985d5b2b08c41c1adc9e8171436ae1f2ace960bd7 15274 orthanc_1.10.1+dfsg-2_source.buildinfo Files: 7b6c483d8412849997607fff30acc2f8 2591 science optional orthanc_1.10.1+dfsg-2.dsc 065c573f3cc0ceca1dcaf47a37016dfa 230508 science optional orthanc_1.10.1+dfsg-2.debian.tar.xz 946c899eb13ba7c5909a7115289caa0e 15274 science optional orthanc_1.10.1+dfsg-2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEk76fGX7V0MMOWT2Lp3ZYKzEqw10FAmJzYjUUHHMuam9kb2du ZUBnbWFpbC5jb20ACgkQp3ZYKzEqw10pqg/8DLM055eMBl4coaOR4zr7IndWFhkB eGQSYLxsbnPqJ9q0hx4/9H8I4aXzRuSMapcRG2Gn8ODmyOACV3LetR2zu5hM3Fml 65EJib01gecgVuR/g4ttt12bPsHLuvwC+CKs5LiE8eGim4ufT6hUJjCkjpVSAyx2 pvgunBUTqz1MfVPVAHC7gLCPf9HP6FLHS/OMBBRtRHZsfZOD+NfSPw5EfCrIYgGh Fs++hV+/SLbuZuroidV3L49zaJtVj+yqlBkmeDXTLOqeClBc6LUmUqVbczDBUGcj UF3vM9ysvxOONkEE2gJZa7gnKmhmjNBugg1EyVOAmExor0iKC+WDXNzGYkOfWCpO elUzfhe2pjbXa55FuKiWiabwzYiKuTMH6VUDmWPGmZsk0b9Z1+WiQC3/FP31xduI 9CUeHtBjPo612P1EuoPmqXsdrl1G9EO2tZc51VcGsDBIF+yU5MZDSIFLxGKbnU/f kPLbgobOmWsvfaHOe9zPldnS4NfV3kawfISAUi+7UKjETugHVyF2nR8ZkZt3MtNE 9n5rPNqcvh9bWgbqcUXc343Su2Ww/1xbVezYvhnNCOzfXHLjr+ETcx4FpwCjxrU+ NiJN4lFNCXN8AaCIQspsni2fdxgdRpLhsR3qvf0NxivIftXmDcGF7HZLGEvT5PNf e6fwoDHTWN3MBJI= =iI5U -----END PGP SIGNATURE-----
--- End Message ---
