Your message dated Sun, 17 Jul 2022 19:48:59 +0000
with message-id <e1odagb-000fut...@fasolo.debian.org>
and subject line Bug#992645: fixed in ncftp 2:3.2.6-1
has caused the Debian Bug report #992645,
regarding ncftp: stores wrong path to tar if built on merged-/usr system
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
992645: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992645
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: ncftp
Version: 2:3.2.5-2.2
Severity: important
Tags: patch bookworm sid
User: reproducible-bui...@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

If ncftp is built on a merged-/usr system (as created by new installations
of Debian >= 10, debootstrap --merged-usr, or installing the usrmerge
package into an existing installation), the path to tar is recorded in the
binary as /usr/bin/tar.

This can be seen on the reproducible-builds.org infra:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/ncftp.html
(search for "/bin/tar" to see the difference I'm concerned about).

If you have sbuild available, an easy way to reproduce this is to build
ncftp twice, once with --add-depends-arch=usrmerge and once without.

The problematic situation is if pkgconf is *built* on a merged-/usr
system, but *used* on a non-merged-/usr system. In this situation,
/usr/bin/tar exists on the build system but not on the system where
ncftp will be used, resulting in the feature that uses tar not being
available.

Technical Committee resolution #978636 mandates heading towards a
transition to merged-/usr, and this will become a non-issue at the end of
that transition; but variation between merged-/usr and non-merged-/usr
builds is a problem while that transition is taking place, because it
can lead to partial upgrades behaving incorrectly. It is likely that
this class of bugs will become release-critical later in the bookworm
development cycle.

Some Debian developers advocate that instead of merged-/usr, we should
use a different strategy where /bin becomes a "symlink farm" with
individual symlinks such as /bin/tar -> /usr/bin/tar. If that route is
taken instead of merged-/usr, then resolving bugs like this one will be
equally important as part of that transition, because it shares the
property that both /bin/tar and /usr/bin/tar exist after the transition,
but only /bin/tar exists on untransitioned systems.

The attached patch resolves this: with it applied, the package builds
identically with and without --add-depends-arch=usrmerge.

A side benefit of fixing this is that this change might be sufficient
to make the package reproducible (as recommended by Policy §4.15).

    smcv
>From 252c7fdcee3fa2548bc8246849aa3dc280169992 Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Sat, 21 Aug 2021 16:50:49 +0100
Subject: [PATCH] d/rules: Specify canonical path to tar

If ncftp is built on a merged-/usr system, then tar is available at
both /usr/bin/tar and /bin/tar, but if it is subsequently used on a
non-merged-/usr system, only /bin/tar will work. Force the canonical
path /bin/tar so that the layout of the build system does not matter.

Signed-off-by: Simon McVittie <s...@debian.org>
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index 5b12238..a0410b4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -21,6 +21,7 @@ config.status:
 	dh_testdir
 	cp /usr/share/misc/config.guess /usr/share/misc/config.sub .
 	# Add here commands to configure the package.
+	TAR=/bin/tar \
 	CFLAGS="$(CFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)" ./configure \
 		--prefix=/usr \
 		--mandir=\$${prefix}/share/man \
-- 
2.33.0


--- End Message ---
--- Begin Message ---
Source: ncftp
Source-Version: 2:3.2.6-1
Done: Noël Köthe <n...@debian.org>

We believe that the bug you reported is fixed in the latest version of
ncftp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 992...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Noël Köthe <n...@debian.org> (supplier of updated ncftp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 17 Jul 2022 20:24:42 +0200
Source: ncftp
Binary: ncftp ncftp-dbgsym
Architecture: source amd64
Version: 2:3.2.6-1
Distribution: unstable
Urgency: medium
Maintainer: Noël Köthe <n...@debian.org>
Changed-By: Noël Köthe <n...@debian.org>
Description:
 ncftp      - User-friendly and well-featured FTP client
Closes: 902803 992645 1006421 1006423
Changes:
 ncftp (2:3.2.6-1) unstable; urgency=medium
 .
   * new upstream release from 2016-11-27 ;)
     closes: Bug#1006421
   * updated Homepage and watch file closes: Bug#1006423
   * fix tar path in debian/rules. Thanks Simon! closes: Bug#992645
   * include architecture.mk in debian/rules to fix cross building.
     Thanks Helmut! closes: Bug#902803
   * raised to debhelper 13
   * updated to Standards-Version 4.6.1
Checksums-Sha1:
 0b10b3404cfd8ee5efd925a9df342672ebb4a22a 1738 ncftp_3.2.6-1.dsc
 e2351802b40db18d6cbab2537a9644cd858b934d 636425 ncftp_3.2.6.orig.tar.gz
 65ec501e5a9514dbdc837d69c67a9311a0b9fe0f 10384 ncftp_3.2.6-1.debian.tar.xz
 0a2cdfc3b667550161259d69a597528b56e87d72 1842272 ncftp-dbgsym_3.2.6-1_amd64.deb
 1f69f589c44caa5f4a428f1c7af7aae4534442c9 6332 ncftp_3.2.6-1_amd64.buildinfo
 f424dde15f4079b67181f77202a798855343f652 304752 ncftp_3.2.6-1_amd64.deb
Checksums-Sha256:
 e6496502df0952d395b85da07e4c0150cb075407d466a0a9ee14b5fd5cc578a1 1738 
ncftp_3.2.6-1.dsc
 129e5954850290da98af012559e6743de193de0012e972ff939df9b604f81c23 636425 
ncftp_3.2.6.orig.tar.gz
 c1cce0901ddf0aa17ed5bb7131c7cd30a5cd504c2173876e7fd3a2c01e6ae879 10384 
ncftp_3.2.6-1.debian.tar.xz
 63aa578f8f396a9c00e751324c1ad9aa9a402d86f6209eb6636a2845f9542f4d 1842272 
ncftp-dbgsym_3.2.6-1_amd64.deb
 df598ad00b137a19675b2cf07f00c71e7c23e17a2b685795120d7f0c71fcb5cb 6332 
ncftp_3.2.6-1_amd64.buildinfo
 2ec2886276f0e620c4f67434f5f65002fe2f049b91123503fbaffeef16a1bc2d 304752 
ncftp_3.2.6-1_amd64.deb
Files:
 5a16e5185fa9d26c1c349c6a010c79b8 1738 net optional ncftp_3.2.6-1.dsc
 e7cce57ef6274d4c7433ffe28ffe0a71 636425 net optional ncftp_3.2.6.orig.tar.gz
 5b4a6a43d8a3575d98265d5117e1d07d 10384 net optional ncftp_3.2.6-1.debian.tar.xz
 5ea075bdf58e75a6cfa5827780d8eb8c 1842272 debug optional 
ncftp-dbgsym_3.2.6-1_amd64.deb
 a9973da9b679a87a7d1ce68c684d942c 6332 net optional 
ncftp_3.2.6-1_amd64.buildinfo
 b05d8f0b0fb84f45f2b57736cdc2d306 304752 net optional ncftp_3.2.6-1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEpF5AXAxsgPE/8VIXaMB4voj4DNoFAmLUYYUACgkQaMB4voj4
DNri5A//RWq8UILmXioy3FOqt0lTIvdtaUrv5noYA6QINNqqPWZUIyFQ6R7M/vU3
Mv8xff4MTuMUaJ4/WP/ztLzuXQ4uw6KkT1DZEnsB8S5suunqSSM4LMZ4E72cBt0P
K0sXNrWpRRX4hqiKtwdAPgyjAzYp3YlnMXjZMlqrws7vm83Eg2ANegwnsAsJsDsZ
QBiGivA2RjK8zCSaZNyqZ6ItUXuX+dQtMKsCROP7iEEQnxti3piqINL9cdpXi4YR
nY/KSrdwsFA022MHmqSob6BJ5K2ZzE5c88xGqER6LRa1yDdH1zRRnb1MAnU4+hmr
61au0L/TmmkfAnBc4GifGHSwPL1h0SHFU4RnxHEhuPcPN7wGz/hGm9RmuybVTxOz
GP8r4mXxqcxi3iRhDBk6aAQ6O2ec10Oi6xBQ5ypGZzjns5TXmO9rDtQ13Cy9LxnL
SLN/LkcRe8EwQrl8fu631qEUKduWPUAHIU1IGny2YChWztBr7sE9VVWjMvjD2m2R
wkFUBjvo4rynerQ/oZnn5NrB0PcnDb6tJrzETD6bwEDILbcy8lN/Q2q3+d710Ppc
LSn+kwz1zTF3v/KEG7RGRRKaWVC8g4PTDhW4ppvlbXhEX/ZDTeKtG3zJ4ftC1IjT
pGQ75Fq2kDNHhmUdNzx1Si+7Sjck26X4ydcaWARHgQHo7tnMxjk=
=NaAJ
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to