Your message dated Sat, 13 Aug 2022 14:36:31 +0000
with message-id <[email protected]>
and subject line Bug#1016560: fixed in scalpel 1.60-9+nmu1
has caused the Debian Bug report #1016560,
regarding glibc 2.34 breaks scalpel autopkgtest on amd64: bash: line 1: 1961
Segmentation fault
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1016560: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016560
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: scalpel
Version: 1.60-9
Severity: important
Tags: upstream patch
User: [email protected]
Usertags: glibc2.34
Dear maintainer,
The autopkgtest of scalpel fails in sid on amd64 when that autopkgtest is
run with the binary packages of glibc from experimental. It passes when
run with only packages from sid. In tabular form:
pass fail
glibc from sid 2.34-0experimental5
scalpel from sid 1.60-9
all others from sid from sid
Here is the relevant part of the test log:
autopkgtest [10:36:40]: test command1: scalpel -c debian/tests/scalpel.conf
debian/tests/lua.img
autopkgtest [10:36:40]: test command1: [-----------------------
Opening target
"/tmp/autopkgtest-lxc.93yq46zi/downtmp/build.fXk/src/debian/tests/lua.img"
bash: line 1: 1961 Segmentation fault bash -ec 'scalpel -c
debian/tests/scalpel.conf debian/tests/lua.img' 2> >(tee -a
/tmp/autopkgtest-lxc.93yq46zi/downtmp/command1-stderr >&2) > >(tee -a
/tmp/autopkgtest-lxc.93yq46zi/downtmp/command1-stdout)
The full test log is available there:
https://ci.debian.net/data/autopkgtest/unstable/amd64/s/scalpel/24235565/log.gz
After some debugging, I have found the issue to be a duplicate use of a
va_list without using va_copy. Please find attached a patch to fix that.
Regards
Aurelien
--- scalpel-1.60.orig/helpers.c
+++ scalpel-1.60/helpers.c
@@ -70,12 +70,14 @@ void setProgramName(char *s) {
// write entry to both the screen and the audit file
void scalpelLog(struct scalpelState *state, char *format, ...) {
- va_list argp;
+ va_list argp, argp2;
va_start(argp,format);
+ va_copy(argp2, argp);
vfprintf (stderr,format,argp);
- vfprintf (state->auditFile,format,argp);
va_end(argp);
+ vfprintf (state->auditFile,format,argp2);
+ va_end(argp2);
}
// determine if two characters match, with optional case
--- End Message ---
--- Begin Message ---
Source: scalpel
Source-Version: 1.60-9+nmu1
Done: Aurelien Jarno <[email protected]>
We believe that the bug you reported is fixed in the latest version of
scalpel, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Aurelien Jarno <[email protected]> (supplier of updated scalpel package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 11 Aug 2022 15:45:53 +0200
Source: scalpel
Architecture: source
Version: 1.60-9+nmu1
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools <[email protected]>
Changed-By: Aurelien Jarno <[email protected]>
Closes: 1016560
Changes:
scalpel (1.60-9+nmu1) unstable; urgency=medium
.
* Non-maintainer upload.
* debian/patches/60_va_copy.patch: fix the va_list usage in
setProgramName(). (Closes: #1016560).
Checksums-Sha1:
9b180b2965699ec068e841d7b69a319737578129 1913 scalpel_1.60-9+nmu1.dsc
2f296fff9832a0bd198a89cd40b13294045ff2b1 19720
scalpel_1.60-9+nmu1.debian.tar.xz
66f6f0aaac332762393e3ed20748382fe485ec1e 5713
scalpel_1.60-9+nmu1_source.buildinfo
Checksums-Sha256:
9915b1228edd14b060f7cc422f39928f1d263bfc38091495478bd66f13dd542a 1913
scalpel_1.60-9+nmu1.dsc
9ada69180ee753acc684da46ddf7b166c310f5a0140192508b9e6fb5d38bc090 19720
scalpel_1.60-9+nmu1.debian.tar.xz
27312fe0b6629617770a1a4411330f12405c457e236426de1080764b1c72e50b 5713
scalpel_1.60-9+nmu1_source.buildinfo
Files:
f3d62760669d4e29ae7c0d7c9e820f63 1913 utils optional scalpel_1.60-9+nmu1.dsc
fc20e15dfd34b5353ea003262136cddd 19720 utils optional
scalpel_1.60-9+nmu1.debian.tar.xz
885b57b9e169f5736cdb2c819fb19e1b 5713 utils optional
scalpel_1.60-9+nmu1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEUryGlb40+QrX1Ay4E4jA+JnoM2sFAmL1CGsACgkQE4jA+Jno
M2vgYg//SVMKYX8qucTefaI0vPHJJ2cCHRpKviezzyRwCXKgpuY326Jiiu6zNTaS
d5tPG79SVwd6fgkN+NuxTeqAWZQKAQ2BIx1c2fu2MjdpTI6hlTZ3h94Dwi6wBFCl
AFNXO3KTj5e/cVhb9SlOVX0wY2PKNRg3LxTp7NpxCeEO93c79mszaKcJNmFg+Sn2
3T4kpL7vzUVg5o8T8oGkmTBCNODT1zTm0IMYm4F4hZoIzTjzLOoAP9r49cq8cBS8
8RPZogxiUEk05KP13Fh0TIKwSmGTeWMS0erejPTDVCBzsm0+mGa5cu5U8D2Ldj6c
ra7l2pWPuFdt6Bssfekd9R+hu2Tl+w9dHIq4F0pD+zbF8/krd/TJhZ8uTw5h7CCY
2o0gshOsXPIb3RGsUt54jtFMm6vHFb+1cxGlc7ACd7W8ATeG17JPrfeBOggErIKy
Hq3lQeS4Ggf4ZKYxqytddUxCgGSFvEu9vkPRek8clnkExLHV2GEA5lZpGh6/sOpk
1njuIcaHPX+15U3/A/EMw/KgJJ5E5ov7LlPSAAQmh0WwBGBUivS5gXj2itO0Fd4w
6usWsYQ0F25R40M1RRM5yqojnTYjfmRYeGiuJE7ZPp/VwZkZ17Upb1hYxD6CvkC7
ID5+HcBfnCdkCx89kh7lDl3wsyPKCgAmqJkaiVlWS10iEb7uW8w=
=N1TJ
-----END PGP SIGNATURE-----
--- End Message ---
