Your message dated Tue, 23 Aug 2022 19:50:15 +0000
with message-id <[email protected]>
and subject line Bug#1017964: fixed in rust-pleaser 0.5.3-1
has caused the Debian Bug report #1017964,
regarding rust-pleaser FTBFS/autopkgtest failure with nix 0.25
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1017964: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017964
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rust-pleaser
Version: 0.5.1-4
Severity: serious


rust-pleaser fails to build with the new version of rust-nix.

error[E0061]: this function takes 0 arguments but 1 argument was supplied
    --> src/lib.rs:416:19
     |
416  |     ro.hostname = gethostname(&mut buf)
     |                   ^^^^^^^^^^^ -------- supplied 1 argument
     |                   |
     |                   expected 0 arguments
     |
note: function defined here
    --> /tmp/tmp.ADzPxvKlSH/registry/nix-0.25.0/src/unistd.rs:1020:8
     |
1020 | pub fn gethostname() -> Result<OsString> {
     |        ^^^^^^^^^^^

The API of gethostname has changed. Now instead of taking a buffer
from the caller it retuns a Result<OsString>

Adjusting the code was easy enough, but I notice that the buffer size
used by the new version of gethostname is about 4 times larger than
the one used previously in pleaser. I have not investigated whether
this increase in potential string length has any security implications
for pleaser.

Patch at

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/pleaser/debian/patches/nix-0.25.patch

Review by someone who knows the codebase would be appreciated.

--- End Message ---
--- Begin Message ---
Source: rust-pleaser
Source-Version: 0.5.3-1
Done: Peter Michael Green <[email protected]>

We believe that the bug you reported is fixed in the latest version of
rust-pleaser, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Peter Michael Green <[email protected]> (supplier of updated rust-pleaser 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 23 Aug 2022 19:29:25 +0000
Source: rust-pleaser
Architecture: source
Version: 0.5.3-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Rust Maintainers 
<[email protected]>
Changed-By: Peter Michael Green <[email protected]>
Closes: 1017964
Changes:
 rust-pleaser (0.5.3-1) unstable; urgency=medium
 .
   * Team upload.
   * Package pleaser 0.5.3 from crates.io using debcargo 2.5.0
   * Drop old patches, no longer needed/relavent.
   * Add patch to fix build with nix 0.25. (Closes: #1017964)
Checksums-Sha1:
 c9dbfa5b13fc30feefb7e0d5bd1e3cbbd340a9b4 2569 rust-pleaser_0.5.3-1.dsc
 f729aca10afa70dccac42f6b1ef251544ed3ad46 55191 rust-pleaser_0.5.3.orig.tar.gz
 78cfc43d2ca05a20dbd0120f04892fda6a37f4a5 3812 
rust-pleaser_0.5.3-1.debian.tar.xz
 104b06d36b7a3b4d6e01f11cc3df852c68d24854 10231 
rust-pleaser_0.5.3-1_source.buildinfo
Checksums-Sha256:
 08d4f8f5198e3f3c451b2dd3046f344a9b3e7279459ebba2a017d838d54688ad 2569 
rust-pleaser_0.5.3-1.dsc
 ac54c26a0db3a5b75702cb6bcfd10d07c40d0b067bc77d8e2669bfc0bae160d0 55191 
rust-pleaser_0.5.3.orig.tar.gz
 b570fab4dab1ff7928960a657ad55466c55407a5b01478befc2d220a11da6ced 3812 
rust-pleaser_0.5.3-1.debian.tar.xz
 db1ec60b7af5c9ee7e55ba9416be5cc8a0a87e13f73ae12d4223f21c0ec30a77 10231 
rust-pleaser_0.5.3-1_source.buildinfo
Files:
 4424a849787b62d389960605073be2a6 2569 utils optional rust-pleaser_0.5.3-1.dsc
 660047910f8495d87ac2dcc4b9560f1d 55191 utils optional 
rust-pleaser_0.5.3.orig.tar.gz
 4414aba24f439a774d77141ef076ac33 3812 utils optional 
rust-pleaser_0.5.3-1.debian.tar.xz
 47d445e3bcd5b4937af65e8ec43896fb 10231 utils optional 
rust-pleaser_0.5.3-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCAAyFiEEU0DQATYMplbjSX63DEjqKnqP/XsFAmMFKrMUHHBsdWd3YXNo
QGRlYmlhbi5vcmcACgkQDEjqKnqP/XugBhAAmPCKtVP6s0tlfmFQaO0pGLmAlRfA
GSNRaH+KRxd2Vl1XgxyarDboc2ULru0jhjZOVuJ5IrdTocNR5hIgeEvtj+PwSEE/
q1CxTefJsgHpijc9pfmG4vbr6Lw2P9rHg0Op5xch8GmLoZesrm3zr0IBzBqmWNZt
bhMTBCXAX4YgG7nzS2+X9IcfyYVhAM2zRYKYzTHh9XqNBVfJ8V/JcThiqc1xAdbc
6O+OD0I9CMhDaCqdn3Ta9TPAmSIU07w8V2QQ4KO9NHJ7HP3t/wQrnUgwcIIRroKK
xOWBHXeTSvrS9/u6YqEUhVNTnNO63PPuXlQJu1ZAm5P4BkRdXnTktSiufIYOJUyA
eLTn1SDfU7NIuJew/2tzf8NMZWNHuXlIeusEHHIsVhz2Gj+HUZNerPWevHSbUDen
g3NZ8xaIGDRU2yADPu+/qNMwXyW6jKmtcq8Dc9bIvUkqRTf+WTOqge1YeUK1/OBL
7i/DKXF6TqNs3Aq6ro/UvMgcadopAP8icVBHetKNxhZUqDQzsPLt69BYKB0IuGFa
NL7vIR9nvxxInhGwjUwICt8ZeTBtcX+eZHqAtOuo5Nl+EpMrZWgEKWemunp1ZJ6w
GRasPKcdZxcaaz5pd1wQWLCWnDQn2uW04919oE37JwLpyzIzpDweGHeFYz15y6Dv
XVDm1JCf7c4CcW0=
=S1Am
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to