El 26/01/23 a las 19:29, Cyril Brulebois escribió: > Hi Oleg, > > Oleg A. Arkhangelsky <syso...@yandex.ru> (2023-01-26): > > After some digging I think that there is more elegant way to stop > > ifup@*.service when stopping (or restarting) networking.serivce, we just > > need to add PartOf to /lib/systemd/system/ifup@.service: > > > > [Unit] > > ... > > PartOf=networking.service > > > > And this ExecStart to /lib/systemd/system/networking.service, to make > > networking.service restart workable for "allow-hotplug" interfaces (as > > per your suggestion): > > > > [Service] > > ... > > ExecStart=/usr/bin/udevadm trigger --action=add --subsystem-match=net > > ... > > > > This changes should be on top of *.service files, before any Bug#1029352 > > modifications, of course. > > > > Seems like more clearer way, than to use /bin/sh invocation and flag file > > for the non-first run condition check. > > > > Any pitfalls for this approach? > > Just to clarify: I was mostly interested in getting the initial regression > fixed, as it was in the way of finally fixing wireless support (via /e/n/i > rather than NM) in the installer. I tried to keep the proposed enhancement > while making sure the regression wouldn't come back, hence the “convoluted” > approach. > > I'm happy if you folks keep digging into this to find a better solution by > tweaking systemd units. I'll just mention that the freeze is underway, that > a simple enhancement (making restart work) totally broke a much more > important use case (keeping start working), and someone probably needs to > weigh pros (getting things better, in a clean way) versus cons (not a lot of > time to discover and track down possible side effects, be them positive or > negative). > > If things break for the installer again: > > (in a deep voice) I'll be back! > > ;) >
:-) Just to add: I am also happy for more clean, elegant, robust, etc. better approaches. But life is keeping me more busy than expected these days. Please, feel free to propose MRs that enhance also debian/tests/hotplug, or create any other autopkgtest that could help to identify and prevent regressions. (No guarantee that those MR could be included in bookworm.) Cheers! -- Santiago
signature.asc
Description: PGP signature
