Your message dated Tue, 07 Feb 2023 11:21:01 +0000
with message-id <[email protected]>
and subject line Bug#1013190: fixed in openems
0.0.35+git20190103.6a75e98+dfsg.1-3.2
has caused the Debian Bug report #1013190,
regarding openems: Migration from vtk7 to vtk9
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1013190: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1013190
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: openems
Severity: wishlist
Tags: patch
X-Debbugs-Cc: [email protected]
Dear Maintainer,
OpenEMS package depends on vtk7 which is quite old and not maintained upstream.
I've succeeded to build OpenEMS with vtk9 by changing Build-Depends from
libvtk7-dev to libvtk9-dev and fixing CMake and build errors.
The patch is attached to this message.
Could you please update to vtk9?
Thanks,
François
--- a/openEMS/CMakeLists.txt
+++ b/openEMS/CMakeLists.txt
@@ -122,7 +122,7 @@
)
# vtk
-find_package(VTK COMPONENTS vtkIOXML vtkIOGeometry vtkIOLegacy vtkIOPLY
NO_MODULE REQUIRED)
+find_package(VTK COMPONENTS IOXML IOGeometry IOLegacy IOPLY NO_MODULE REQUIRED)
message(STATUS "Found package VTK. Using version " ${VTK_VERSION})
if("${VTK_MAJOR_VERSION}" GREATER 5)
@@ -174,7 +174,7 @@
${HDF5_LIBRARIES}
${HDF5_HL_LIBRARIES}
${Boost_LIBRARIES}
- ${vtk_LIBS}
+ ${VTK_LIBRARIES}
${MPI_LIBRARIES}
hdf5_serial_hl
)
--- a/CSXCAD/src/CSPrimPolyhedronReader.cpp
+++ b/CSXCAD/src/CSPrimPolyhedronReader.cpp
@@ -163,7 +163,7 @@
AddVertex(polydata->GetPoint(n));
vtkIdType numP;
- vtkIdType *vertices = new vtkIdType[10];
+ vtkIdType const *vertices = new vtkIdType[10];
while (verts->GetNextCell(numP, vertices))
{
face f;
--- a/QCSXCAD/CMakeLists.txt
+++ b/QCSXCAD/CMakeLists.txt
@@ -6,7 +6,7 @@
SET( CMAKE_BUILD_TYPE Release CACHE STRING "Set to either \"Release\" or
\"Debug\"" )
ENDIF()
-PROJECT( QCSXCAD CXX)
+PROJECT( QCSXCAD C CXX)
cmake_minimum_required(VERSION 2.8)
@@ -100,6 +100,8 @@
message(STATUS "Found package VTK. Using version " ${VTK_VERSION})
include(${VTK_USE_FILE})
INCLUDE_DIRECTORIES (${VTK_INCLUDE_DIRS})
+message("VTK_MAJOR_VERSION: ${VTK_MAJOR_VERSION}")
+add_compile_definitions(VTK_MAJOR_VERSION=${VTK_MAJOR_VERSION})
# Qt
SET(RESOURCES resources.qrc)
--- a/QCSXCAD/QCSXCAD.cpp
+++ b/QCSXCAD/QCSXCAD.cpp
@@ -58,7 +58,7 @@
#include "CSPrimWire.h"
#include "CSPrimUserDefined.h"
-#include <QVTKWidget.h>
+#include <QVTKOpenGLNativeWidget.h>
#include <vtkRendererCollection.h>
#include <vtkRenderWindow.h>
#include <vtkRenderer.h>
--- a/QCSXCAD/QVTKStructure.h
+++ b/QCSXCAD/QVTKStructure.h
@@ -21,7 +21,9 @@
#include <QtGui>
#include "vtkCommand.h"
-#if VTK_MAJOR_VERSION>=8
+#if VTK_MAJOR_VERSION>=9
+ class QVTKOpenGLNativeWidget;
+#elif VTK_MAJOR_VERSION>=8
class QVTKOpenGLWidget;
#else
class QVTKWidget;
@@ -100,7 +102,9 @@
unsigned int uID;
} VTKLayerStruct;
-#if VTK_MAJOR_VERSION>=8
+#if VTK_MAJOR_VERSION>=9
+ QVTKOpenGLNativeWidget *VTKWidget;
+#elif VTK_MAJOR_VERSION>=8
QVTKOpenGLWidget *VTKWidget;
#else
QVTKWidget *VTKWidget;
--- a/QCSXCAD/QVTKStructure.cpp
+++ b/QCSXCAD/QVTKStructure.cpp
@@ -20,7 +20,10 @@
#include "QVTKStructure.h"
#include "vtkCommand.h"
-#if VTK_MAJOR_VERSION>=8
+#if VTK_MAJOR_VERSION>=9
+ #include "QVTKOpenGLNativeWidget.h"
+ #include "vtkGenericOpenGLRenderWindow.h"
+#elif VTK_MAJOR_VERSION>=8
#include "QVTKOpenGLWidget.h"
#include "vtkGenericOpenGLRenderWindow.h"
#else
@@ -99,7 +102,10 @@
iResolution=32;
AllowUpdate=true;
-#if VTK_MAJOR_VERSION>=8
+#if VTK_MAJOR_VERSION>=9
+ VTKWidget = new QVTKOpenGLNativeWidget();
+ VTKWidget->SetRenderWindow(vtkGenericOpenGLRenderWindow::New());
+#elif VTK_MAJOR_VERSION>=8
VTKWidget = new QVTKOpenGLWidget();
VTKWidget->SetRenderWindow(vtkGenericOpenGLRenderWindow::New());
#else
--- a/QCSXCAD/export_x3d.cpp
+++ b/QCSXCAD/export_x3d.cpp
@@ -17,7 +17,7 @@
#include <QMessageBox>
-#include <QVTKWidget.h>
+#include <QVTKOpenGLNativeWidget.h>
#include <vtkRendererCollection.h>
#include <vtkRenderWindow.h>
#include <vtkRenderer.h>
@@ -70,7 +70,7 @@
export_properties( Scene, properties, Material );
// create camera
- vtkRendererCollection* collection =
((QVTKWidget*)(m_CSX->StructureVTK->GetVTKWidget()))->GetRenderWindow()->GetRenderers();
+ vtkRendererCollection* collection =
((QVTKOpenGLNativeWidget*)(m_CSX->StructureVTK->GetVTKWidget()))->GetRenderWindow()->GetRenderers();
vtkRenderer *r = collection->GetFirstRenderer();
if (!r)
return;
--- a/QCSXCAD/export_pov.cpp
+++ b/QCSXCAD/export_pov.cpp
@@ -18,7 +18,7 @@
#include <QMessageBox>
#include <QtXml>
-#include <QVTKWidget.h>
+#include <QVTKOpenGLNativeWidget.h>
#include <vtkRendererCollection.h>
#include <vtkRenderWindow.h>
#include <vtkRenderer.h>
@@ -201,7 +201,7 @@
QString export_pov::get_camera()
{
- vtkRendererCollection* collection =
((QVTKWidget*)(m_CSX->StructureVTK->GetVTKWidget()))->GetRenderWindow()->GetRenderers();
+ vtkRendererCollection* collection =
((QVTKOpenGLNativeWidget*)(m_CSX->StructureVTK->GetVTKWidget()))->GetRenderWindow()->GetRenderers();
vtkRenderer *r = collection->GetFirstRenderer();
if (!r)
return QString();
@@ -231,7 +231,7 @@
QString export_pov::get_light()
{
- vtkRendererCollection* collection =
((QVTKWidget*)(m_CSX->StructureVTK->GetVTKWidget()))->GetRenderWindow()->GetRenderers();
+ vtkRendererCollection* collection =
((QVTKOpenGLNativeWidget*)(m_CSX->StructureVTK->GetVTKWidget()))->GetRenderWindow()->GetRenderers();
vtkRenderer *r = collection->GetFirstRenderer();
if (!r)
return QString();
--- End Message ---
--- Begin Message ---
Source: openems
Source-Version: 0.0.35+git20190103.6a75e98+dfsg.1-3.2
Done: Adrian Bunk <[email protected]>
We believe that the bug you reported is fixed in the latest version of
openems, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adrian Bunk <[email protected]> (supplier of updated openems package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 06 Feb 2023 18:49:06 +0200
Source: openems
Architecture: source
Version: 0.0.35+git20190103.6a75e98+dfsg.1-3.2
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<[email protected]>
Changed-By: Adrian Bunk <[email protected]>
Closes: 1009706 1013190
Changes:
openems (0.0.35+git20190103.6a75e98+dfsg.1-3.2) unstable; urgency=medium
.
* Non-maintainer upload.
* Add patch from Francois Mazen to build with VTK 9.
(Closes: #1013190)
* Don't build in debug mode, thanks to Thomas Lepoix.
(Closes: #1009706)
Checksums-Sha1:
7fca7a6364d852627f3cbb6f5dee9ad38ceff1ea 2742
openems_0.0.35+git20190103.6a75e98+dfsg.1-3.2.dsc
65b225105914f53733c1c60bb5cf54847a5acc42 16212
openems_0.0.35+git20190103.6a75e98+dfsg.1-3.2.debian.tar.xz
Checksums-Sha256:
7ff79c2ee5fb391d12bd9430e4c509e0e512b56b2bb9e934bad965f079bc7f9d 2742
openems_0.0.35+git20190103.6a75e98+dfsg.1-3.2.dsc
b164b1b7da9e3c9955f9f6d6478e13f2b528f6f62ce53fd2f086ace54ce7972c 16212
openems_0.0.35+git20190103.6a75e98+dfsg.1-3.2.debian.tar.xz
Files:
34f3944793bf599a1780a0f20fdb51d2 2742 electronics optional
openems_0.0.35+git20190103.6a75e98+dfsg.1-3.2.dsc
7e27994d8a3edad895569bc8652ba5b6 16212 electronics optional
openems_0.0.35+git20190103.6a75e98+dfsg.1-3.2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEOvp1f6xuoR0v9F3wiNJCh6LYmLEFAmPhNoMACgkQiNJCh6LY
mLG0RxAAqhrZFukSyibTgyoNry6SWcTD27DLjGB/KX35rAmyEUwmPUKEPGP7KDek
4CBsGWfdefLtogJbK+piH0EtMgtHW4MoKceloUXbnQ41jmPywZ3FNhjo3+xa4uzu
K1EI+ENrU6kOeWotqvnWZoOJu+NB9poMoti2dCdKb7WYuoQWIBEzXFRpuh8+5CF+
4Se5maYaeD2AZuDhIKcfURGq9FqHRXwKvaDkgQwh5633AQVim0MQhT6FomwyFUL3
AYGqsw1j9UxMDR7kCb9f/b+xs50X7U3l1DRW4enjplxB1PbU+5SVZuquAoS6wT6B
D+BNVPbWrCopK+y3AFjVH6obo932huOlWM+N4blKUg5ODNl1P0+hk3VosTx8Qolc
yaGAlQXUUNmZotI76FTbLUMyX+PrtG0JS60u4IDpgSICW+E7/XQoHcRyvAClLCja
RNpNokLlB7LK9rEH+eeqqKvMpvIbUAFI6Tf7nQHrYWF4TNwtKHl/gnvdGiMXhSWA
SYjSN3HsWvOkV1y4iQ6vfD8l2Jdb68fElaVpQWSsdAyYgEMh2n8AA7Guliq8i0yp
xvMQuWpJnpPwS98dHN9+dQh48wo9nQ/9+aKR9+4SlWpUSAcnSYLYzONpjv07IMtX
GR6ECXzq4l7MBPJRjTpND4Eg5XJ59zK0Blp6g5c9NKNOmdb1/m0=
=KS6t
-----END PGP SIGNATURE-----
--- End Message ---