Your message dated Sat, 01 Apr 2023 09:04:00 +0000
with message-id <[email protected]>
and subject line Bug#1033784: fixed in libmath-bigint-gmp-perl 1.6011-3
has caused the Debian Bug report #1033784,
regarding FTBFS: mbimbf.t fails with libmath-bigint-perl 1.999838
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1033784: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033784
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libmath-bigint-gmp-perl
Version: 1.6011-2
Severity: serious
Tags: ftbfs, patch

Dear Maintainer,

yesterday I uploaded libmath-bigint-perl 1.999838-1, which fixes RC
bugs.
Bug with this version of libmath-bigint-perl now
libmath-bigint-gmp-perl fails to build, since two test cases in
t/mbimbf.t fail:

ok 729 - $x has A of 42
ok 730 - $x has A from global
not ok 731 - $x has still A of 42
ok 732 - $x has A of 42
ok 733 - $x has A from global
not ok 734 - $x has still A of 42

t/mbimbf.t in libmath-bigint-perl and libmath-bigint-gmp-perl where
identical except
-use Math::BigInt only => 'Calc';
+use Math::BigInt only => 'GMP';
before the update of libmath-bigint-perl, but Upstream
extended/changed mbimbf.t in 1.999838, so IMHO it should be changed in
libmath-bigint-gmp-perl accordingly.

The attached patch merges mbimbf.t changes from libmath-bigint-perl
1.999838.
With this patch libmath-bigint-gmp-perl builds with a working test
suite.

Greetings
Roland
From: Roland Rosenfeld <[email protected]>
Subject: Adapt mbimbf.t to the one from Math::BigInt 1.999838
Date: Sat, 01 Apr 2023 09:57:20 +0200

--- a/t/mbimbf.t
+++ b/t/mbimbf.t
@@ -7,7 +7,7 @@ use strict;
 use warnings;
 
 use Test::More tests => 712             # tests in require'd file
-                        + 26;           # tests in this file
+                        + 52;           # tests in this file
 
 use Math::BigInt only => 'GMP';
 use Math::BigFloat;
@@ -58,24 +58,71 @@ foreach my $class (qw/Math::BigInt Math:
 }
 
 foreach my $class (qw/Math::BigInt Math::BigFloat/)  {
-    $class->accuracy(42);
+    my $x;
 
-    # $x gets A of 42, too!
-    my $x = $class->new(123);
+    # Accuracy
 
-    # really?
-    is($x->accuracy(), 42, '$x has A of 42');
+    # set and check the class accuracy
+    $class->accuracy(1);
+    is($class->accuracy(), 1, "$class has A of 1");
 
-    # $x has no A, but the global is still in effect for $x so the return value
-    # of that operation should be 42, not undef
-    is($x->accuracy(undef), 42, '$x has A from global');
+    # a new instance gets the class accuracy
+    $x = $class->new(123);
+    is($x->accuracy(), 1, '$x has A of 1');
 
-    # so $x should still have A = 42
-    is($x->accuracy(), 42, '$x has still A of 42');
+    # set and check the instance accuracy
+    $x->accuracy(2);
+    is($x->accuracy(), 2, '$x has A of 2');
 
-    # reset for further tests
+    # change the class accuracy
+    $class->accuracy(3);
+    is($class->accuracy(), 3, "$class has A of 3");
+
+    # verify that the instance accuracy hasn't changed
+    is($x->accuracy(), 2, '$x still has A of 2');
+
+    # change the instance accuracy
+    $x->accuracy(undef);
+    is($x->accuracy(), undef, '$x now has A of undef');
+
+    # check the class accuracy
+    is($class->accuracy(), 3, "$class still has A of 3");
+
+    # change the class accuracy again
     $class->accuracy(undef);
+    is($class->accuracy(), undef, "$class now has A of undef");
+
+    # Precision
+
+    # set and check the class precision
+    $class->precision(1);
+    is($class->precision(), 1, "$class has A of 1");
+
+    # a new instance gets the class precision
+    $x = $class->new(123);
+    is($x->precision(), 1, '$x has A of 1');
+
+    # set and check the instance precision
+    $x->precision(2);
+    is($x->precision(), 2, '$x has A of 2');
+
+    # change the class precision
+    $class->precision(3);
+    is($class->precision(), 3, "$class has A of 3");
+
+    # verify that the instance precision hasn't changed
+    is($x->precision(), 2, '$x still has A of 2');
+
+    # change the instance precision
+    $x->precision(undef);
+    is($x->precision(), undef, '$x now has A of undef');
+
+    # check the class precision
+    is($class->precision(), 3, "$class still has A of 3");
+
+    # change the class precision again
     $class->precision(undef);
+    is($class->precision(), undef, "$class now has A of undef");
 }
 
 # bug with blog(Math::BigFloat, Math::BigInt)

--- End Message ---
--- Begin Message ---
Source: libmath-bigint-gmp-perl
Source-Version: 1.6011-3
Done: Roland Rosenfeld <[email protected]>

We believe that the bug you reported is fixed in the latest version of
libmath-bigint-gmp-perl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Roland Rosenfeld <[email protected]> (supplier of updated 
libmath-bigint-gmp-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 01 Apr 2023 10:39:39 +0200
Source: libmath-bigint-gmp-perl
Architecture: source
Version: 1.6011-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <[email protected]>
Changed-By: Roland Rosenfeld <[email protected]>
Closes: 1033784
Changes:
 libmath-bigint-gmp-perl (1.6011-3) unstable; urgency=medium
 .
   * 01_testaccuracy: Adapt the accuracy tests mbimbf.t to the changes from
     Math::BigInt 1.999838 (Closes: #1033784).
   * Add myself to uploaders.
   * Add debian/salsa-ci.yml.
Checksums-Sha1:
 ce439ace8081f6d7ebba20a48e173ec8942b6abe 2364 
libmath-bigint-gmp-perl_1.6011-3.dsc
 431105072d628001a9f6dff61d03cd2e07537d7d 5496 
libmath-bigint-gmp-perl_1.6011-3.debian.tar.xz
 c346179e51c3ba20cd0375bac46272ed54d280c7 6160 
libmath-bigint-gmp-perl_1.6011-3_source.buildinfo
Checksums-Sha256:
 3830c95e65ee1dd8bba2de65ba746d7631f3e7e8aba4e726c45f0dc6e1a8bb97 2364 
libmath-bigint-gmp-perl_1.6011-3.dsc
 c740c12516681ae3603ed3ae05cf0c132cb12d2e8a6d48495f2a9469dec8dffd 5496 
libmath-bigint-gmp-perl_1.6011-3.debian.tar.xz
 0a577bb8403c8552bcff6f9ecac4a4a3adca35dfdb9f55d2ffb2c12f93782dc6 6160 
libmath-bigint-gmp-perl_1.6011-3_source.buildinfo
Files:
 c2af669f91c742b4406cd5ffc8ab2494 2364 perl optional 
libmath-bigint-gmp-perl_1.6011-3.dsc
 a99f961f47d5ac8e6dd4edc1008f118b 5496 perl optional 
libmath-bigint-gmp-perl_1.6011-3.debian.tar.xz
 975a2959d745513e65524e2c70c28a4a 6160 perl optional 
libmath-bigint-gmp-perl_1.6011-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEErC+9sQSUPYpEoCEdAnE7z8pUELIFAmQn7fEACgkQAnE7z8pU
ELLGRBAAt+BzTJ4wahbd6+p/4Gy34zYTMBL/cn5rnIWBXcKKnAmfOgx0v0pN5B2l
d9c0ZLYeIlcG8jPtXwtxVoBgd690Z+byKtp0ht7Z3a/FUkZz0Ky+En4S9RfWp53S
BCMNSun2xaPauXQbOf6lPLH50yGzZ8dzQCdyotpkwH4lFlFxtmhATuEwjxF/yE9e
y3+mLqIc3gBB5QqjaS9eE4BsbfzX+5MFoI4aRJRQ/8f/auBG6ypnoIJ5fertzgyJ
iKPEnwR/S9NeFrFGtXS0PcsHtCjRH4STZ+gm3zwnLOKSlBEaHhY6FNosPXZuk+wg
hXf6douEK7OInbZiYzkXHbDB0B+3TiqTmUhQK2Om5YUDSfTEATOoleALTdsq71Hg
qllJCH+Rhyqfx1CTkB49t4lhmujD62ZCW1X8bSXykeHdw13UvGspp0Q4H5pUcPrj
hzkeBRsHtMLlR9sWEVPTqzRvqvDahzr5zFNi6Y3FdaG7QEhAV4LPPMsiiQ+RSws0
zCYKndgNppwxDbyT3u+Rq5A3jk0J1SJR1nRu3ilxy/gfC4NHFeMJyHv6stPrDH31
goQIhoRp2/uI8C1viq6U1psBdkvLwPP/8IjVp8+JEQgzpXVDVz/YJEN0Fj/Nlk0D
xAaxhi5D4FiCyCalCVQ4fCwJ1yisOQtVhygfmOlg7/uA1XwBCKU=
=GMJr
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to