Control: tag -1 patch

Sam Hartman <hartm...@debian.org> (2023-04-11):
> control: tags -1 wontfix

serious & wontfix make for a strange combination…

> >>>>> "bigon" == bigon  <bi...@debian.org> writes:
> 
>     bigon> It seems that your package libpam-modules-bin is shipping
>     bigon> files (.service, .socket or .timer) in
>     bigon> /usr/lib/systemd/system.
> 
> I think we're talking about pam_namespace.service.
> I don't think dh_installsystemd has anything to do for that file because
> it has no Install section.
> What harm is caused by pam_namespace.service being in /usr/lib/systemd?

To expand on Lauren't answer, you're currently lacking these:

- postinst:

    #!/bin/sh
    set -e
    # Automatically added by dh_installsystemd/13.11.4
    if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = 
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then  
            if [ -d /run/systemd/system ]; then
                    systemctl --system daemon-reload >/dev/null || true
                    if [ -n "$2" ]; then
                            _dh_action=restart
                    else
                            _dh_action=start
                    fi
                    deb-systemd-invoke $_dh_action 'pam_namespace.service' 
>/dev/null || true
            fi
    fi
    # End automatically added section


- postrm:

    #!/bin/sh
    set -e
    # Automatically added by dh_installsystemd/13.11.4
    if [ "$1" = remove ] && [ -d /run/systemd/system ] ; then
            systemctl --system daemon-reload >/dev/null || true
    fi      
    # End automatically added section


- prerm:

    #!/bin/sh
    set -e
    # Automatically added by dh_installsystemd/13.11.4
    if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = remove ] && [ -d /run/systemd/system 
] ; then
            deb-systemd-invoke stop 'pam_namespace.service' >/dev/null || true
    fi      
    # End automatically added section


FWIW it's just a matter of changing the last line of
debian/libpam-modules-bin.install to:

    usr/lib/systemd/system/pam_namespace.service /lib/systemd/system/

Patch attached.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
--- pam-1.5.2/debian/changelog	2023-01-03 20:15:23.000000000 +0000
+++ pam-1.5.2/debian/changelog	2023-04-25 14:51:19.000000000 +0000
@@ -1,3 +1,10 @@
+pam (1.5.2-7) UNRELEASED; urgency=medium
+
+  * Fix install directory for pam_namespace.service so that it gets
+    picked up by dh_installsystemd, Closes: #1034234
+
+ -- Cyril Brulebois <k...@debian.org>  Tue, 25 Apr 2023 16:51:19 +0200
+
 pam (1.5.2-6) unstable; urgency=medium
 
   * Update debian/copyright, Thanks Bastian Germann, Closes: #460232
--- pam-1.5.2/debian/libpam-modules-bin.install	2023-01-03 20:15:23.000000000 +0000
+++ pam-1.5.2/debian/libpam-modules-bin.install	2023-04-25 14:41:36.000000000 +0000
@@ -6,4 +6,4 @@
 sbin/pam_timestamp_check	usr/sbin
 sbin/faillock usr/sbin
 modules/pam_faillock/faillock.8 usr/share/man/man8
-usr/lib/systemd/system/pam_namespace.service
+usr/lib/systemd/system/pam_namespace.service /lib/systemd/system/

Attachment: signature.asc
Description: PGP signature

Reply via email to