Cool stuff. Could you please push your change to the repo ? :) thanks S
Le 23/07/2023 à 23:42, Pierre Gruet a écrit :
Control: tags -1 pending Hi, I intend to upload a fix shortly, after some days reworking the package to get rid of pcre3. I post the contents of the header of the patch I wrote for further reference. This consists in: 1. making changes in the following files: - scilab/modules/spreadsheet/src/c/csvRead.c - scilab/modules/string/src/c/strsubst.c - scilab/modules/string/sci_gateway/cpp/sci_strsubst.cpp - scilab/modules/string/sci_gateway/cpp/sci_grep.cpp - scilab/modules/string/sci_gateway/cpp/sci_strindex.cpp - scilab/modules/string/sci_gateway/cpp/sci_regexp.cpp - scilab/modules/slint/includes/PCREException.hxx - scilab/modules/slint/includes/PCREMatcher.hxx - scilab/modules/slint/src/cpp/PCREException.cpp - scilab/modules/slint/src/cpp/PCREMatcher.cpp in which one needs to use the pcre2 functions. This is somewhat difficult because the upstream codes contains files like scilab/modules/string/src/c/pcre_(internal|private).c which perform the regex matches and are highly dependent on the contents of the pcre library. To avoid rewriting them, I skipped them and put all the pattern compiling and matching stuff in the above .(c|cpp|hxx) files. 2. updating the following files: - scilab/m4/pcre.m4 - scilab/configure.ac - scilab/modules/string/Makefile.am - scilab/modules/slint/Makefile.am so that the flags and libraries of pcre2 are used, not the ones of pcre3. 3. updating all the remaining files in this patch so that delimiters are not provided to the scilab functions working with regular expression patterns and modifiers like "i", "m" or "x" are not provided either, as they are not handled by the modifications I made. This implied also modifying a large part of the unit tests of these functions using the "imx" modifiers and I hope this was done well, as currently the build-time tests are not run during a Debian build. Also I plan to insert a debian/NEWS file to warn about 3. above. Best,
