Your message dated Fri, 06 Oct 2023 07:35:26 +0000 with message-id <[email protected]> and subject line Bug#1051141: fixed in mfem 4.5.2+ds-1.2 has caused the Debian Bug report #1051141, regarding mfem: broken build system? to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 1051141: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051141 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: mfem Version: 4.5.2+ds-1.1 Severity: serious Justification: the directories hardcoded in header file points to unexisting locations. Hello, I found some issues on the packaging of mfem, and I would like to see them fixed because I don't think the package is good for stable in this way, but feel free to close if you think this isn't the case! First issue: this is passed in configure: -DINSTALL_LIB_DIR=lib/x86_64-linux-gnu instead of DEB_HOST_MULTIARCH, causing a lot of pain a little bit after: dh_fixperms chrpath -d debian/libmfem4*/usr/lib/*-*/libmfem.so* # one day this will also work on non x86_64-linux-gnu # debian/libmfem-dev/usr/lib/cmake/mfem/*.cmake are with absolute wrong/build paths sed -i "s,/.*/lib/.*/libmfem.so.4.5.2,/usr/lib/x86_64-linux-gnu/libmfem.so.4.5.2,g" debian/libmfem-dev/usr/lib/cmake/mfem/MFEMTargets-*.cmake # one day someone will fix the -ffile-prefix-map sed -i "s,/.*/lib/.*x86_64-linux-gnu,/usr/lib/x86_64-linux-gnu,g" debian/libmfem-dev/usr/lib/cmake/mfem/MFEMConfig.cmake (for some reasons the DESTDIR contains the full path of the build, not the relative one, so this causes a lot of other issues) Second issue: cat /usr/include/mfem/config/_config.hpp |grep build #define MFEM_SOURCE_DIR "/build/reproducible-path/mfem-4.5.2+ds" MFEM_SOURCE_DIR and MFEM_INSTALL_DIR are used in many places in the code, and this will fail. fem/ceed/interface/util.cpp: const char *install_dir = MFEM_INSTALL_DIR "/include/mfem/fem/ceed"; fem/ceed/interface/util.cpp: MFEM_ABORT("Cannot find libCEED kernels in MFEM_INSTALL_DIR or " general/device.cpp: if (occa::io::exists(MFEM_INSTALL_DIR "/include/mfem/")) general/device.cpp: mfemDir = MFEM_INSTALL_DIR "/include/mfem/"; general/device.cpp: MFEM_ABORT("Cannot find OCCA kernels in MFEM_INSTALL_DIR or MFEM_SOURCE_DIR"); fem/ceed/interface/util.cpp: const char *source_dir = MFEM_SOURCE_DIR "/fem/ceed"; fem/ceed/interface/util.cpp: "MFEM_SOURCE_DIR"); general/device.cpp: else if (occa::io::exists(MFEM_SOURCE_DIR)) general/device.cpp: mfemDir = MFEM_SOURCE_DIR; general/device.cpp: MFEM_ABORT("Cannot find OCCA kernels in MFEM_INSTALL_DIR or MFEM_SOURCE_DIR"); Third issue: the shipped cmake file looks wrong and broken (this is a good candidate for autopkgtest :) ) cat ../CMakeLists.txt cmake_minimum_required(VERSION 3.27) project(foo) find_package(MFEM) cmake .. -- The C compiler identification is GNU 13.2.0 -- The CXX compiler identification is GNU 13.2.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done CMake Error at /usr/lib/cmake/mfem/MFEMConfig.cmake:88 (message): File or directory /usr/usr/lib/x86_64-linux-gnu/openmpi/include/openmpi referenced by variable MFEM_INCLUDE_DIR does not exist ! Call Stack (most recent call first): /usr/lib/cmake/mfem/MFEMConfig.cmake:106 (set_and_check) CMakeLists.txt:3 (find_package) -- Configuring incomplete, errors occurred! I'm stopping here, but I think we need some fixes before considering it good enough for stable, what do you think? Gianfranco
OpenPGP_signature
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---Source: mfem Source-Version: 4.5.2+ds-1.2 Done: Gianfranco Costamagna <[email protected]> We believe that the bug you reported is fixed in the latest version of mfem, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Gianfranco Costamagna <[email protected]> (supplier of updated mfem package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 05 Oct 2023 13:37:10 +0200 Source: mfem Built-For-Profiles: noudeb Architecture: source Version: 4.5.2+ds-1.2 Distribution: unstable Urgency: medium Maintainer: Gürkan Myczko <[email protected]> Changed-By: Gianfranco Costamagna <[email protected]> Closes: 1051141 Changes: mfem (4.5.2+ds-1.2) unstable; urgency=medium . * Non-maintainer upload. * Add simple testsuite to make sure the dev package works and is able to compile a test example * Mark the package as multi-arch * Add some dependencies to dev package to make sure it can build examples * Simplify d/not-installed file * Make sure the package is multiarch now install also cmake files in multiarch directory * Add patch to fix the build and install paths * Simplify rules file for multiarch change * Fix cmake and add autopkgtest (Closes: #1051141) Checksums-Sha1: 75d964fe945978052c36e2e7b69eef49f71bd5a0 2021 mfem_4.5.2+ds-1.2.dsc e04cc8a982c58c309d0353a6af7b1791c1c9c9f2 16136 mfem_4.5.2+ds-1.2.debian.tar.xz d4d3738134f2c9f099e7ed1e6dcbd2d3c17926a7 11455 mfem_4.5.2+ds-1.2_source.buildinfo Checksums-Sha256: 9c40455f2f40ba66cac3420b649a00e48370092a3618afb0f5cb006dd09545b0 2021 mfem_4.5.2+ds-1.2.dsc 204b350cb698538a9eefdad6f61daa8a806e54407802db08402f044c8c1aab5a 16136 mfem_4.5.2+ds-1.2.debian.tar.xz 9617d35cfd5786acfa37c83ecdabac3aa1055cc46c728a42787fabe2eebd9937 11455 mfem_4.5.2+ds-1.2_source.buildinfo Files: 03974016e56c77f18a18e3ef45546d90 2021 libs optional mfem_4.5.2+ds-1.2.dsc bf23df6c392e4f2707686f1f86deedd2 16136 libs optional mfem_4.5.2+ds-1.2.debian.tar.xz b3f831236b2e5a5be8b05b3c2a96b29b 11455 libs optional mfem_4.5.2+ds-1.2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkpeKbhleSSGCX3/w808JdE6fXdkFAmUftIUACgkQ808JdE6f Xdm0ZBAAyPigaGrlj0Mz/TkvqkPBUmC/Q1CqGbGRqiP10OetT8BUsFpnFPL4Rwpj aJ2kQcWdONkYULiGHTyO0CP+ZE5eXWpWbCmO5cW7jj1oBGhQMymdfAoj2gI4tLTb 2muj5iikCV3csbKvIINky3EJI386TEySaRdzPQEWjQ+9RzhsKX6MQs7u9Kl0GW7U jL8Sv7PQ4gG0LkKbI21IpHKlsh5RtCWvWixaAzcMGotHXaQsVAVFOYYLTqrPnQde buPBr9AU/HZe+HQ9yEGv0/E67YHBv+2DEnrqF23Lq5tun4XJVl4417DkFpvymx6p TIViGW04mJCSrrxSqapyaXfN6+F5E5S7aLqyH3TzDzjxLg7/39lLpW8PCN350L+F 9YHY8UPBfM2CHVOYij2MgcqNb4sbtNe1Zwmfc9Te+G138Q/bHlY5wnk1CEqxAf6d vazwEJ5c0wYc5W4dDdyASlSZH5fb7xZ427+cMkioSym6bXmcYSo2zQyOlTI/q6tb wZhhf8IYqLl90gmE5+u5wlhyZ4zEZWqIeCW1qxlo8O1G3ru68U0+ol2RVNjSmMbO e/yrQ32joJ1saci0+QkAMO7ZBVSn0E/29SoH+t8AzY6Y7CcG91cbB7oQBwnIHYOo MlxM7eEVPA6kq1Z0wTk/Uw6ygbGTQUxMdilHvKoIzpmIz3JsHCQ= =bWBn -----END PGP SIGNATURE-----
--- End Message ---
