Source: python-refurb
Version: 1.21.0-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: [email protected]
Usertags: ftbfs-20231027 ftbfs-trixie
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
Relevant part (hopefully):
> debian/rules binary
> dh binary --with python3 --buildsystem=pybuild
> dh_update_autotools_config -O--buildsystem=pybuild
> dh_autoreconf -O--buildsystem=pybuild
> dh_auto_configure -O--buildsystem=pybuild
> dh_auto_build -O--buildsystem=pybuild
> I: pybuild plugin_pyproject:110: Building wheel for python3.11 with "build"
> module
> I: pybuild base:310: python3.11 -m build --skip-dependency-check
> --no-isolation --wheel --outdir /<<PKGBUILDDIR>>/.pybuild/cpython3_3.11
> * Building wheel...
> Successfully built refurb-1.21.0-py3-none-any.whl
> I: pybuild plugin_pyproject:122: Unpacking wheel built for python3.11 with
> "installer" module
> dh_auto_test -O--buildsystem=pybuild
> I: pybuild base:310: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.11/build;
> python3.11 -m pytest -k "not test_checks_are_formatted_properly"
> ============================= test session starts
> ==============================
> platform linux -- Python 3.11.6, pytest-7.4.3, pluggy-1.3.0
> rootdir: /<<PKGBUILDDIR>>/.pybuild/cpython3_3.11/build
> configfile: pyproject.toml
> testpaths: test
> plugins: cov-4.1.0, anyio-3.7.0
> collected 132 items / 1 deselected / 131 selected
>
> test/test_arg_parsing.py ............................................... [
> 35%]
> ...................... [
> 52%]
> test/test_checks.py F..................... [
> 69%]
> test/test_explain.py .... [
> 72%]
> test/test_gen.py ... [
> 74%]
> test/test_github_annotations.py .. [
> 76%]
> test/test_loader.py ....... [
> 81%]
> test/test_main.py .............s........ [
> 98%]
> test/test_visitor.py ..
> [100%]
>
> =================================== FAILURES
> ===================================
> _________________________________ test_checks
> __________________________________
>
> def test_checks() -> None:
> > run_checks_in_folder(TEST_DATA_PATH)
>
> test/test_checks.py:21:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
>
> folder = PosixPath('test/data')
>
> def run_checks_in_folder(
> folder: Path, *, version: tuple[int, int] | None = None
> ) -> None:
> settings = Settings(files=[str(folder)], enable_all=True)
>
> if version:
> settings.python_version = version
>
> errors = run_refurb(settings)
> got = "\n".join([str(error) for error in errors])
>
> files = sorted(folder.glob("*.txt"), key=lambda p: p.name)
> expected = "\n".join(file.read_text()[:-1] for file in files)
>
> > assert got == expected
> E assert 'test/data/bu...th `x.open()`' == 'test/data/bu...th
> `x.open()`'
> E Skipping 27202 identical leading characters in diff, use -v to show
> E - r_143.py:18:5 [FURB143]: Replace `x or ()` with `x`
> E ? ^
> E + r_143.py:19:5 [FURB143]: Replace `x or ()` with `x`
> E ? ^
> E - test/data/err_143.py:19:5 [FURB143]: Replace `x or ()` with `x`
> E test/data/err_143.py:20:5 [FURB143]: Replace `x or ""` with `x`...
> E
> E ...Full output truncated (309 lines hidden), use '-vv' to show
>
> test/test_checks.py:288: AssertionError
>
> ---------- coverage: platform linux, python 3.11.6-final-0 -----------
> Name Stmts Miss Cover Missing
> -------------------------------------
> TOTAL 2594 0 100%
>
> 112 files skipped due to complete coverage.
> Coverage HTML written to dir htmlcov
>
> Required test coverage of 100% reached. Total coverage: 100.00%
> =========================== short test summary info
> ============================
> FAILED test/test_checks.py::test_checks - assert 'test/data/bu...th
> `x.open()...
> ====== 1 failed, 129 passed, 1 skipped, 1 deselected in 78.12s (0:01:18)
> =======
> E: pybuild pybuild:395: test: plugin pyproject failed with: exit code=1: cd
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.11/build; python3.11 -m pytest -k "not
> test_checks_are_formatted_properly"
> dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p 3.11
> returned exit code 13
The full build log is available from:
http://qa-logs.debian.net/2023/10/27/python-refurb_1.21.0-1_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20231027;[email protected]
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20231027&[email protected]&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
