Your message dated Tue, 19 Mar 2024 07:51:51 +0000
with message-id <[email protected]>
and subject line Bug#1065486: fixed in sbd 1.5.2-2
has caused the Debian Bug report #1065486,
regarding sbd: FTBFS due to hardcoded libaio SONAME used in dlopen()
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1065486: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065486
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: sbd
Source-Version: 1.5.2-1
Severity: serious
Tags: patch upstream
Hi!
For the time64 transition I've done a local SONAME bump. This will
make this package FTBFS (once the mass binNMUs are triggered) due to
its test suite hardcoding the libaio SONAME for a dlopen() call.
Because the package is already explicitly linking against -laio (which
I guess also means there's a missing Build-Depends here), we are
guaranteed to have libaio.so available, so we can use that to avoid
hardcoding the SONAME. Of course dlopen()ing a shared library like
this is dangerous as the code might use the wrong ABI and that might
go unnoticed at build time, so perhaps it might also be worth
investigating in the future whether the dlopen is really necessary at
all (the test case is already being linked also against -laio).
The attached patch fixes the build for me with the new libaio.
Thanks,
Guillem
Description: Do not hardcode libaio SONAME
The SONAME might change, and then the dlopen() fails. This just happened now
as part of the time64 transition. The package is already linking explicitly
against -laio, thus libaio.so will be guaranteed to be present, so instead
of hardcoding the current SONAME at this point in time, simply use libaio.so.
Author: Guillem Jover <[email protected]>
Last-Update: 2024-03-05
---
tests/sbd-testbed.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/tests/sbd-testbed.c
+++ b/tests/sbd-testbed.c
@@ -154,9 +154,9 @@ init (void)
orig_fopen = (orig_fopen_f_type)dlsym_fatal(RTLD_NEXT,"fopen");
orig_fclose = (orig_fclose_f_type)dlsym_fatal(RTLD_NEXT,"fclose");
- handle = dlopen("libaio.so.1", RTLD_NOW);
+ handle = dlopen("libaio.so", RTLD_NOW);
if (!handle) {
- fprintf(stderr, "Failed opening libaio.so.1\n");
+ fprintf(stderr, "Failed opening libaio.so\n");
exit(1);
}
orig_io_setup = (orig_io_setup_f_type)dlsym_fatal(handle,"io_setup");
--- End Message ---
--- Begin Message ---
Source: sbd
Source-Version: 1.5.2-2
Done: Ferenc Wágner <[email protected]>
We believe that the bug you reported is fixed in the latest version of
sbd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ferenc Wágner <[email protected]> (supplier of updated sbd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 17 Mar 2024 14:37:53 +0100
Source: sbd
Architecture: source
Version: 1.5.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian HA Maintainers
<[email protected]>
Changed-By: Ferenc Wágner <[email protected]>
Closes: 1065486
Changes:
sbd (1.5.2-2) unstable; urgency=medium
.
[ Valentin Vidic ]
* debian/control: drop lsb-base dependency
.
[ Ferenc Wágner ]
* New patch: Hardwiring the libaio SONAME is fragile and unnecessary
(Closes: #1065486)
Checksums-Sha1:
1c72afb5b40cef7937ac50c477b29c107ac5a6b9 2120 sbd_1.5.2-2.dsc
d0c2273c01cb92136dd43a2f8f6e40a9adc81eeb 6700 sbd_1.5.2-2.debian.tar.xz
bd2ba8e25ba4c5030c2e8f000d4acd01d58ce97f 8952 sbd_1.5.2-2_amd64.buildinfo
Checksums-Sha256:
50a9045d318a5c280bd011a16cfaaf5815d192367a6a7acb7cc97804404098ac 2120
sbd_1.5.2-2.dsc
a565a2742f70591b40a9d670d4363a35f9ff0e3751824c0a1821a8b38c6baddd 6700
sbd_1.5.2-2.debian.tar.xz
d96b407a9f1ea718ec303860efee5881e9b7c81871776ffd41e02cd3ebdc8717 8952
sbd_1.5.2-2_amd64.buildinfo
Files:
df9ae115dd68adfa0fe6c89f33666903 2120 admin optional sbd_1.5.2-2.dsc
2eebc2be2b18d0e084b11670084f0b2b 6700 admin optional sbd_1.5.2-2.debian.tar.xz
2c837ddcc506dad79438a3547e7996a1 8952 admin optional
sbd_1.5.2-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEwddEx0RNIUL7eugtOsj3Fkd+2yMFAmX5PvIACgkQOsj3Fkd+
2yNnkg//ayKQqx80Qln/dfuywhcK1GHxqu8PobEjf51UH2Tzp7Ss6Tc9snk+v0W8
7YIaajHoC0f5saRpFAd4O5CX6s/EJnV5O6NHJ+8zvnwD4siDr2b/lEK/2YTqEGol
65Q5JdIa+6fJy0p6SyfiDqvqOg/5a/TG65wQ6cJSN9bQzad/ekVyOh7qxoC2hnWc
ppC/E+CUzZQdS17niUKENzdHEViEg3DvP2y+s4kjCt33g42lUoxEgAe8x4joy9ua
glZeTOoaQfV/NykhYN6+Y1QiXl/Z3p4ZAYAIf106y5De3myl0kH86fGpQu7C1qFU
i9MUNQxdjTV7GQBsvhyaGBYlOEsBDxCIJ8RTWJx5X76f2oRtFC5oflqZquo7OgfD
M+UsTtFSlkPPpfzGG6dvVxbfECz8mENV2Ju+I1CyWussjrhgZB7rWeNuSb2zkSV3
Etu9xDfpvUsaY2zcIV8xmJmOcCNowgK2Ozy+n1nFs4q7spKlqTNvK/rc6H4MoieA
Y5LNKaNJmSeB588Z5RxzRjbzwM8wGG+CJrCvgjLJrbhAKbPztcwN03OSqfUtD540
Z0OR8wEBhgF7B76vqESo0En88oqx87/Hxi5U9KSl/T0V11yuGmwT8422BrR85j56
pmJb6zzdn50Gn+6nXvqhaHJMai0LkgX3ct+WKz0NWI+wQrVFE2g=
=ukA8
-----END PGP SIGNATURE-----
pgpaQHyZet9eU.pgp
Description: PGP signature
--- End Message ---
