On Tue, Mar 26, 2024 at 02:36:06PM +0100, Cyril Brulebois wrote:
> Control: tag -1 patch pending
> 
> Lucas Nussbaum <lu...@debian.org> (2024-03-13):
> > This is most likely caused by a change in dpkg 1.22.6, that enabled
> > -Werror=implicit-function-declaration. For more information, see
> > https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
> > 
> > Relevant part (hopefully):
> > > ../../common/scheduler/task.c: In function ‘task_perform’:
> > > ../../common/scheduler/task.c:137:25: error: implicit declaration of 
> > > function ‘clamp’ [-Werror=implicit-function-declaration]
> > >   137 |         task->backoff = clamp(task->backoff * 2, 60, 
> > > ODS_SE_MAX_BACKOFF);
> > >       |                         ^~~~~
> > > cc1: some warnings being treated as errors
> > > make[4]: *** [Makefile:601: scheduler/task.o] Error 1
> 
> I thought there would be several things but apparently that's just the
> one. A quick look upstream shows there are more PRs and more fixups
> needed for even newer compilers, but I'm limiting my patch to the bare
> minimum.
> 
> Since that's been open for 10+ days, and since reverse dependencies
> could get kicked out of testing, I'm uploading an NMU right now so that
> I don't forget, but to DELAYED/2 so there's some room to do things
> differently if desired. I'm happy to reschedule/cancel if needed.

Thanks for the NMU.

I had a look at the new warnings and they all seem to be false
positives. I'd rather not introduce unnecessary changes in the
packaged version compared to upstream just to silence them. This
missing header will do.

-- 
Mathieu Mirmont <m...@parad0x.org>

Attachment: signature.asc
Description: Digital signature

Reply via email to