Your message dated Wed, 22 May 2024 19:43:57 +0000
with message-id <[email protected]>
and subject line Bug#1071597: fixed in rust-laurel 0.6.2-2
has caused the Debian Bug report #1071597,
regarding rust-laurel - autopkgtest failure on s390x
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1071597: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071597
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rust-laurel
Version: 0.6.2-1
Severity: serious

rust-laurel's autopkgtest fails on s390x. I belive the patch
skip-parse_syslog-on-big-endian.patch should be reinstated
but I do not want to get into a revert war with the
maintainer.

So I feel I need to lay out, in more detail than
is visible in the changelog and git history, what I have
done regarding this package and why.

My main role in the rust team has been trying to keep the
"greater whole" of rust packages in a consistent state and
moving forward. Since upstream rust dependencies tend to be
pessimistic and Debian frowns upon packaging multiple
versions of the same software, this inevitablly involves
patching a bunch of packages.

I use autopkgtests as a tool to help minimize the chances
that these changes cause undetected breakage. As such when
bumping a dependency in a package that has no functional
autopkgtests, I will usually try to get at least some test
coverage.

Regarding rust-laurel specifically, up to version 0.5.6-1,
the tests were skipped.

In version 0.5.6-2, as part of preparing for the nix 0.27
update, I patched rust-laurel to get tests running. The
tests passed in my local tests on amd64 and so I uploaded
it.

Tests on debci revealed some failures though, there was
a test failure on 32-bit systems due to an integer
overflow in some time calculation code, and a failure
on s390x architectures which I determined to be down
to endian-specific test date in the test.

I prepared a fix for the time calculation code, which I
also posted upstreamed.

I decided that fixing the test data would probablly not
have a positive effort/benefit ratio and therefore added
a patch to skip the test on big-endian architectures. This
was still an improvement over the prior situation
where no tests were being run at all.

I uploaded these changes as 0.5.6-2.

The time overflow issue was fixed upstream in versions
0.6.0 and later. When Hilko uploaded version 0.6.1-1
he dropped my patches. The time overflow issue was fixed
upstream, so this made sense but nothing had been done
upstream to address the big endian issue. So this lead
to the tests once again failing on s390x.

I figured that this was a mistake, that Hilko had
incorrectly assumed that the big endian issue had been
taken care of upstream and after nearly a month of the
package sitting unable to migrate to testing, I
reinstated the patch and tweaked it to apply to the
new upstream version.

I made further uploads of 0.6.1 to address issues
related to the time64 and nix transitions.

When preparing the upload of 0.6.2-1, Hilko once again
dropped the patch with a changelog entry of
"Drop unneeded patches".

So that brings us to where we are now, the package
fails it's autopkgtests on s390x and I do not feel
it's appropriate to reinstate the patch for the second
time without first trying to get some feedback from
the maintainer.

--- End Message ---
--- Begin Message ---
Source: rust-laurel
Source-Version: 0.6.2-2
Done: Hilko Bengen <[email protected]>

We believe that the bug you reported is fixed in the latest version of
rust-laurel, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hilko Bengen <[email protected]> (supplier of updated rust-laurel package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 22 May 2024 20:53:40 +0200
Source: rust-laurel
Architecture: source
Version: 0.6.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Rust Maintainers 
<[email protected]>
Changed-By: Hilko Bengen <[email protected]>
Closes: 1071597
Changes:
 rust-laurel (0.6.2-2) unstable; urgency=medium
 .
   * Team upload.
   * Add upstream patch really fixing sockaddr tests on big-endian. Thanks
     to Peter Green for making me realize that the issue had not been fixed
     upstream. (Closes: #1071597)
Checksums-Sha1:
 d13526838c348e0d182ca48c1ff767d22c997bcf 3242 rust-laurel_0.6.2-2.dsc
 d063a05b4e9a7867a55301d4d78406a6bdff960f 5692 rust-laurel_0.6.2-2.debian.tar.xz
 073e2e586e69b662b799ab4d879bda00c1118bcc 14157 
rust-laurel_0.6.2-2_source.buildinfo
Checksums-Sha256:
 11e42a8d706cdbfeacdc3a28ae2cc36d99f391f18a69abf38f92e78cd946e147 3242 
rust-laurel_0.6.2-2.dsc
 04ddcfc041e5582048669d7b6771234c139b76a004b1fe37c110ee8419c044f1 5692 
rust-laurel_0.6.2-2.debian.tar.xz
 8b7de0da539c4d2de4fcd96a3745d5e80a0aa98275369a1d7df0574a534d4c04 14157 
rust-laurel_0.6.2-2_source.buildinfo
Files:
 4c2b1b8b2dd29d3ae60bbb2a827d20a2 3242 admin optional rust-laurel_0.6.2-2.dsc
 330a3ed9bfadf08b7100dd391a3ce7a9 5692 admin optional 
rust-laurel_0.6.2-2.debian.tar.xz
 3df63139a3500fb9cca096e83b0ac040 14157 admin optional 
rust-laurel_0.6.2-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEErnMQVUQqHZbPTUx4dbcQY1whOn4FAmZOPzoACgkQdbcQY1wh
On4tng//WYt8cqZ/OvKj3/K8daIjzVBc5uh45W8Lr6v7wsCl2v6WacSquEKtxtWL
3M/nQyoz7B0J9MdtIWxUAozN0Oj1An7Y/UNApPhIMUBDtsXfiopnpkgp+7RNr9u9
ZhE7KC4H+EyzhhDuLfcBH0KgkV/5WcOdbkdg3ok984rgYkFYArbiWCLgKijDlA0+
lcJiohlchL5yCxP45AzrlPKukMcuv/oWFRokkO1Bsk6OmTlhJKfCLyqjXX7qLZ/g
ZPbXCML/XuQS5WPamieD/stIUyBbJQhBwnt/8bEJHzvMQWvYhvWnWhkm8pdYT5Bf
VV9LQzXkjnQ48tX513+WjvAiZIEP7YYoCL2ND8GJzw/yMWyG/J3UpI710eChlAzx
YbdG+vQMJ5BFOU303qWoFuzsdz4oNaARrW1XB8O8jL8jlOc2nRCGzC52QL+O+lhq
Xcd+IJmxtNAkLCVwU+IuxF9vaIc6P92NxlE/vHHP6UJ3yzjBV3F8hpuYoqx53Gh2
UynDuGJ8BbgZg26vt5KRp8q4qhyE8TeyNOopOMiK++PW+xQ3XKs26UjBlRwXJx/4
xmyTCEdRW0zcvuKtgiCx6F/lxa4phtjZrG22pqFJ5dKVB+Z6cIIi0fnXvTOTxXrP
ytbF5tVw74QjMkucpRaYlPat8BVumanR+8CbMzL7TjaQaAjvL/8=
=UalU
-----END PGP SIGNATURE-----

Attachment: pgpFTNXy8xNib.pgp
Description: PGP signature


--- End Message ---

Reply via email to