On Tue, Sep 16, 2025 at 06:11:13PM +0000, Victor Seva wrote: > Some improvement, after > https://salsa.debian.org/perl-team/modules/packages/libfile-mmagic-xs-perl/-/commit/99b2c07833b7425e7ef552998503d7c54e1fe39b > I see less errors but sadly I don't know how to fix this one: > > > src/MMagicST.c: In function ‘st_foreach’: >... > > src/MMagicST.c:500:23: error: too many arguments to function ‘func’; > > expected 0, have 4 > > 500 | retval = (*func)(ptr->key, ptr->record, arg, 0); > > | ~^~~~~~ ~~~~~~~~ > > src/MMagicST.c:511:31: error: too many arguments to function ‘func’; > > expected 0, have 4 > > 511 | retval = (*func)(0, 0, arg, 1); > > | ~^~~~~~ ~ > > make[1]: *** [Makefile:354: src/MMagicST.o] Error 1
Remove the function, since it is unused? But to be honest, this is the kind of package where I would not do any fixing at all and just add export DEB_CFLAGS_MAINT_APPEND = -std=gnu17 in debian/rules. This will make it work as good (or bad) as in trixie, while avoiding the risk of introducing regressions. cu Adrian
