On Sun, Oct 01, 2006 at 12:04:48AM +0200, Michael Vogt wrote:
> --- apt-pkg/tagfile.h 2006-09-30 20:50:41 +0000
> +++ apt-pkg/tagfile.h 2006-09-30 21:35:25 +0000
> @@ -77,6 +77,7 @@
>     unsigned long Size;
>     
>     bool Fill();
> +   bool Resize();

This would (unnecessarily) change the ABI of libapt, requiring a shlibs
versioned bump.  Fill() neither should've been part of the ABI (it makes
no sense to use it externally), but it is at the moment.

This symbol should instead be placed in a "private:" section of the class
(without any explicit definition, symbols are public).

Otherwise, the patch logic is as far as I can see, correct.

--Jeroen

-- 
Jeroen van Wolffelaar
[EMAIL PROTECTED] (also for Jabber & MSN; ICQ: 33944357)
http://Jeroen.A-Eskwadraat.nl


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to