On Tuesday, November 25, 2025 12:00:53 PM Mountain Standard Time Adrian Bunk 
wrote:
> Control: reopen -1
> Control: severity -1 serious
> 
> On Fri, Nov 21, 2025 at 08:29:02PM -0700, Soren Stoutner wrote:
> > Control: forwarded -1 https://github.com/feather-wallet/feather/issues/277
> > 
> > On Thursday, November 20, 2025 8:03:09 PM Mountain Standard Time zhangdandan
> > 
> > wrote:
> > > Please consider the patch I attached.
> > > I have built feather-wallet successfully on locally.
> > > Your opinions are welcome.
> > 
> > Thank you for your bug report and the patch.  I have forwarded it upstream
> > to
> > make sure they don’t foresee any negative side effects.
> 
> This is just the tip of an iceberg of issues:
> 
> 1. -maes is a baseline violation even on amd64

Can you please provide some more information on this topic, as it isn’t 
something I have 
previously read about.

> 2. Additionally the package builds with -march=native, which means it
> will run only on hardware compatible with the hardware of whatever
> buildd did build the package.
> 
> src:monero solved these two issues with:
> override_dh_auto_configure:
>         dh_auto_configure -- -DARCH=default -DNO_AES=ON

Are there any possible downsides to using the same option for feather-wallet?  
Likely a 
new bug should be filed to discuss the possibility of including these 
configuration options.

> An additional issue would be:
> 3. Do we really need two copies of the monero code in the archive?

Yes.  Feather Wallet uses a modified version of the Monero source code as 
confirmed by 
upstream here:

https://github.com/feather-wallet/feather/issues/214#issuecomment-2474005186[1]

-- 
Soren Stoutner
[email protected]

--------
[1] https://github.com/feather-wallet/feather/issues/214#issuecomment-2474005186

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to